From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDB8C4332D for ; Thu, 18 Mar 2021 13:34:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3935F64FA6 for ; Thu, 18 Mar 2021 13:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbhCRNds (ORCPT ); Thu, 18 Mar 2021 09:33:48 -0400 Received: from smtprelay0082.hostedemail.com ([216.40.44.82]:37576 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230010AbhCRNd3 (ORCPT ); Thu, 18 Mar 2021 09:33:29 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 9A5FE18016676; Thu, 18 Mar 2021 13:33:28 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: light50_061599227747 X-Filterd-Recvd-Size: 2864 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Thu, 18 Mar 2021 13:33:27 +0000 (UTC) Message-ID: <50b9ca002b7ce6c34a9c5d32126f667ec2c714b0.camel@perches.com> Subject: Re: [Linuxarm] Re: [PATCH 2/3] drivers/perf: convert sysfs scnprintf family to sysfs_emit_at From: Joe Perches To: "liuqi (BA)" , john.garry@huawei.com, zhangshaokun@hisilicon.com, will@kernel.org, mark.rutland@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Date: Thu, 18 Mar 2021 06:33:25 -0700 In-Reply-To: References: <1615974111-45601-1-git-send-email-liuqi115@huawei.com> <1615974111-45601-3-git-send-email-liuqi115@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-03-18 at 17:33 +0800, liuqi (BA) wrote: > On 2021/3/17 22:57, Joe Perches wrote: > > On Wed, 2021-03-17 at 17:41 +0800, Qi Liu wrote: > > > Use the generic sysfs_emit_at() function take place of scnprintf() > > [] > > > diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c > > [] > > > @@ -328,41 +328,37 @@ static ssize_t arm_ccn_pmu_event_show(struct device *dev, > > >    struct arm_ccn_pmu_event, attr); > > >    ssize_t res; > > >    > > > > > > > > > - res = scnprintf(buf, PAGE_SIZE, "type=0x%x", event->type); > > > + res = sysfs_emit(buf, "type=0x%x", event->type); > > >    if (event->event) > > > - res += scnprintf(buf + res, PAGE_SIZE - res, ",event=0x%x", > > > + res += sysfs_emit_at(buf + res, res, ",event=0x%x", > > >    event->event); > > > > sysfs_emit_at should always use buf, not buf + offset. > > res should be int and is the offset from buf for the output > > > > so the form should be similar to > > > > int len; > > > > len = sysfs_emit(buf, "type=0x%x", event->type); > > if (event->event) { > > len += sysfs_emit_at(buf, len, ",event=0x%x", event->event); > > > > etc... > > > Hi Joe, > > I'll fix the use of sysfs_emit_at in next version, thanks. > But I think it's better to keep the res as ssize_t, as the return value > of this function is ssize_t. The 2nd arg of sysfs_emit_at is int. On 64 bit platforms, ssize_t is 64 bit while int is 32. If res (or len) is ssize_t, there could be a lot of -Wconversion warnings like this produced when using make W= warning: conversion from ‘ssize_t’ {aka ‘long int’} to ‘int’ may change value [-Wconversion] 262 | len += sysfs_emit_at(buf, len, "\n"); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0B5BC433E0 for ; Thu, 18 Mar 2021 13:35:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 394E260238 for ; Thu, 18 Mar 2021 13:35:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 394E260238 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:Cc:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W3c2tJ8j9+ezafKI/Q3aFfgZCjALFixLxR+EJQokj9Q=; b=iDy9mrph2tysVWChUfOdb39CH MI1NdYhM6BbFhdQNBgCon8ihQI9GHhR6SGPNiCRk2jzKttvv1y+C0XokV8jMk66prRiORN1P39ztj MpOEMmjz2kXBbJnLSLOoVxKawCbbl/exDwZyITTFWsv5T29qqb8BP3oJlMK58LiwbDJZybZNddpL6 00l7UkoIPbnrczEnQAb43b7hmWYzJ8hAMNhvZeLwJQGmVIgYHv2IFEyg+leN5vk+waItKfcOULAfg p/ECqbmDMIEQ0PgevXxeoOUdmVL5IcRPze3I9xiLq//QAxVMgIi/Rx2GKj8UalDodI4NUqC04bBOp +E0dhLHHQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMsmO-005Nd2-Q0; Thu, 18 Mar 2021 13:33:38 +0000 Received: from smtprelay0198.hostedemail.com ([216.40.44.198] helo=smtprelay.hostedemail.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMsmI-005NcB-Kk for linux-arm-kernel@lists.infradead.org; Thu, 18 Mar 2021 13:33:32 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 9A5FE18016676; Thu, 18 Mar 2021 13:33:28 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: light50_061599227747 X-Filterd-Recvd-Size: 2864 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Thu, 18 Mar 2021 13:33:27 +0000 (UTC) Message-ID: <50b9ca002b7ce6c34a9c5d32126f667ec2c714b0.camel@perches.com> Subject: Re: [Linuxarm] Re: [PATCH 2/3] drivers/perf: convert sysfs scnprintf family to sysfs_emit_at From: Joe Perches To: "liuqi (BA)" , john.garry@huawei.com, zhangshaokun@hisilicon.com, will@kernel.org, mark.rutland@arm.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Date: Thu, 18 Mar 2021 06:33:25 -0700 In-Reply-To: References: <1615974111-45601-1-git-send-email-liuqi115@huawei.com> <1615974111-45601-3-git-send-email-liuqi115@huawei.com> User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210318_133330_813883_71816C64 X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMDIxLTAzLTE4IGF0IDE3OjMzICswODAwLCBsaXVxaSAoQkEpIHdyb3RlOgo+IE9u IDIwMjEvMy8xNyAyMjo1NywgSm9lIFBlcmNoZXMgd3JvdGU6Cj4gPiBPbiBXZWQsIDIwMjEtMDMt MTcgYXQgMTc6NDEgKzA4MDAsIFFpIExpdSB3cm90ZToKPiA+ID4gVXNlIHRoZSBnZW5lcmljIHN5 c2ZzX2VtaXRfYXQoKSBmdW5jdGlvbiB0YWtlIHBsYWNlIG9mIHNjbnByaW50ZigpCj4gPiBbXQo+ ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wZXJmL2FybS1jY24uYyBiL2RyaXZlcnMvcGVyZi9h cm0tY2NuLmMKPiA+IFtdCj4gPiA+IEBAIC0zMjgsNDEgKzMyOCwzNyBAQCBzdGF0aWMgc3NpemVf dCBhcm1fY2NuX3BtdV9ldmVudF9zaG93KHN0cnVjdCBkZXZpY2UgKmRldiwKPiA+ID4gwqDCoAkJ CXN0cnVjdCBhcm1fY2NuX3BtdV9ldmVudCwgYXR0cik7Cj4gPiA+IMKgwqAJc3NpemVfdCByZXM7 Cj4gPiA+IMKgwqAKPiA+ID4gCj4gPiA+IAo+ID4gPiAtCXJlcyA9IHNjbnByaW50ZihidWYsIFBB R0VfU0laRSwgInR5cGU9MHgleCIsIGV2ZW50LT50eXBlKTsKPiA+ID4gKwlyZXMgPSBzeXNmc19l bWl0KGJ1ZiwgInR5cGU9MHgleCIsIGV2ZW50LT50eXBlKTsKPiA+ID4gwqDCoAlpZiAoZXZlbnQt PmV2ZW50KQo+ID4gPiAtCQlyZXMgKz0gc2NucHJpbnRmKGJ1ZiArIHJlcywgUEFHRV9TSVpFIC0g cmVzLCAiLGV2ZW50PTB4JXgiLAo+ID4gPiArCQlyZXMgKz0gc3lzZnNfZW1pdF9hdChidWYgKyBy ZXMsIHJlcywgIixldmVudD0weCV4IiwKPiA+ID4gwqDCoAkJCQlldmVudC0+ZXZlbnQpOwo+ID4g Cj4gPiBzeXNmc19lbWl0X2F0IHNob3VsZCBhbHdheXMgdXNlIGJ1Ziwgbm90IGJ1ZiArIG9mZnNl dC4KPiA+IHJlcyBzaG91bGQgYmUgaW50IGFuZCBpcyB0aGUgb2Zmc2V0IGZyb20gYnVmIGZvciB0 aGUgb3V0cHV0Cj4gPiAKPiA+IHNvIHRoZSBmb3JtIHNob3VsZCBiZSBzaW1pbGFyIHRvCj4gPiAK PiA+IAlpbnQgbGVuOwo+ID4gCj4gPiAJbGVuID0gc3lzZnNfZW1pdChidWYsICJ0eXBlPTB4JXgi LCBldmVudC0+dHlwZSk7Cj4gPiAJaWYgKGV2ZW50LT5ldmVudCkgewo+ID4gCQlsZW4gKz0gc3lz ZnNfZW1pdF9hdChidWYsIGxlbiwgIixldmVudD0weCV4IiwgZXZlbnQtPmV2ZW50KTsKPiA+IAo+ ID4gCQlldGMuLi4KPiA+IAo+IEhpIEpvZSwKPiAKPiBJJ2xsIGZpeCB0aGUgdXNlIG9mIHN5c2Zz X2VtaXRfYXQgaW4gbmV4dCB2ZXJzaW9uLCB0aGFua3MuCj4gQnV0IEkgdGhpbmsgaXQncyBiZXR0 ZXIgdG8ga2VlcCB0aGUgcmVzIGFzIHNzaXplX3QsIGFzIHRoZSByZXR1cm4gdmFsdWUgCj4gb2Yg dGhpcyBmdW5jdGlvbiBpcyBzc2l6ZV90LgoKVGhlIDJuZCBhcmcgb2Ygc3lzZnNfZW1pdF9hdCBp cyBpbnQuCk9uIDY0IGJpdCBwbGF0Zm9ybXMsIHNzaXplX3QgaXMgNjQgYml0IHdoaWxlIGludCBp cyAzMi4KCklmIHJlcyAob3IgbGVuKSBpcyBzc2l6ZV90LCB0aGVyZSBjb3VsZCBiZSBhIGxvdCBv ZiAtV2NvbnZlcnNpb24gd2FybmluZ3MKbGlrZSB0aGlzIHByb2R1Y2VkIHdoZW4gdXNpbmcgbWFr ZSBXPQoKd2FybmluZzogY29udmVyc2lvbiBmcm9tIOKAmHNzaXplX3TigJkge2FrYSDigJhsb25n IGludOKAmX0gdG8g4oCYaW504oCZIG1heSBjaGFuZ2UgdmFsdWUgWy1XY29udmVyc2lvbl0KICAy NjIgfCAgbGVuICs9IHN5c2ZzX2VtaXRfYXQoYnVmLCBsZW4sICJcbiIpOwoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==