From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27420C433EF for ; Fri, 29 Apr 2022 08:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355803AbiD2Ijz (ORCPT ); Fri, 29 Apr 2022 04:39:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355815AbiD2Ijo (ORCPT ); Fri, 29 Apr 2022 04:39:44 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2040.outbound.protection.outlook.com [40.107.243.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D128A777E for ; Fri, 29 Apr 2022 01:36:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ncu0lO7OytiyC2WYvai7iVeHESAAhL8XMkH/gyLe5I523qjznHolWFJ/wR+6mlnGjqswgJBa/LBmhbMvaLWLmw394JJQR6QlqFSVzmswNWyrJ804MH3BysKsXn8JxfHa3aqt49vvn6ha1VUZE4klDWifCLazKxAhjMcLKcLcuykZ7hCnRDKUkStsW5kZeVT4TQV+LDzf3HaxwI8HFSyBQoZ2JxlyA6W6L+hrRfDwCXFDTGcT4WD4Xa8BZex/rTwPvIeHWJKcak9N3zvtUWXbSaB7ZNrGZbDr0cLjQXZjkAysMnBUcoRF/zdFmMqcRnwd+aNez/nA1Gk/rQLYRT5ebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nZGCC7ZajxlfZJ8cDUD0BxoPH4MAuXGnXcgI+GDLhGk=; b=S14kbxgcxgoHgN+fgYPXqdIXo+E4bzGad3stnS16u+WFFH/ZW5CZpiWCakPr99cI0sIhy1UOfAytkmNZWl+BziEXJY0vhkwmtN6VwvGse09NbxHfMW6WZSJFXumHwUTs1DCZrdaKMyjgT4HecDChXG4nDyuGZLgaKyb0JNg+3idshtDbFs6BFbMxUntK8Ebca3n7dsGOWHULQcUa+WwyhQ6OZr+ZGQyOf0ag+P6QmpqZc46WtLZFrIqeJCyiWZG8KoolilPPuFrvxQsOzmhZyHMUbXAKuwu+cqlJJOeqtDB/aImzkHW02AMl1UuC3EH0DtQuln0CDwlcxs3eVYdc2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nZGCC7ZajxlfZJ8cDUD0BxoPH4MAuXGnXcgI+GDLhGk=; b=bC9ObwgoOKyelz62YH/f5UUFm19643Eh1DhdfeBHA3kTIl1I5nK3P403RVKOjvpmuXCRc+um91eMvyCX0u1uDkjY4la7G6PTvauLnzyYWDU70vbBgu0UBzLncfiQDoh9pLSUGBygjykLhtolEfHIK7EBjcTHCKVUZ4fLIzcqEUo= Received: from BN9PR03CA0147.namprd03.prod.outlook.com (2603:10b6:408:fe::32) by DM6PR02MB4571.namprd02.prod.outlook.com (2603:10b6:5:1d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Fri, 29 Apr 2022 08:36:25 +0000 Received: from BN1NAM02FT011.eop-nam02.prod.protection.outlook.com (2603:10b6:408:fe:cafe::76) by BN9PR03CA0147.outlook.office365.com (2603:10b6:408:fe::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 29 Apr 2022 08:36:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT011.mail.protection.outlook.com (10.13.2.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:36:24 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:36:24 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:36:24 -0700 Envelope-to: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, corbet@lwn.net, linux-arm-kernel@lists.infradead.org, arnd@arndb.de Received: from [10.254.241.50] (port=34552) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkM6y-0007Nh-BR; Fri, 29 Apr 2022 01:36:24 -0700 Message-ID: <50cc8c4b-4b75-d9f4-f0e8-bc246345920a@xilinx.com> Date: Fri, 29 Apr 2022 10:36:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 4/4] firmware: xilinx: enable feature check for ZynqMP Content-Language: en-US To: Ronak Jain , , CC: , , , , , References: <1649242526-17493-1-git-send-email-ronak.jain@xilinx.com> <1649242526-17493-5-git-send-email-ronak.jain@xilinx.com> From: Michal Simek In-Reply-To: <1649242526-17493-5-git-send-email-ronak.jain@xilinx.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 755032d1-44c8-41f4-fe44-08da29bb58c2 X-MS-TrafficTypeDiagnostic: DM6PR02MB4571:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FdHiJmklwvpPt5AkVoXqpaHcs5i84kXL4p9fMXngrYjEG2xn0wkQR5McDu7JphHmrWAoMXrD2qMy+DFG6hI0qdBurOFsxKsXI/4NQzjlLKBEiFGcGlgjLC/aJ1GHU/adLXzWc1kCmXw9EnOp4XcxBfUtGoDOeEIDWMTlgbKhtcyGRUnm7Kcpf1QFDek4rcyFiPHVAT4kxKmmlpr2QjseYkMimXlki3kQCod0lkOqYTUWvdgmg+pC7tUeSJkhPzIzXZQO7r1el/wevL61MRAVjqmbbMWgZZKsJvs6BszUqeQ3yLTi/gw7l8cHMRVXlXVCYeJqh0vfYBxp/Bo9XRG5pymxlXHXFTwNVv3KB5PCWiYQ21VmSSeiVm94AHL0FmeJ0IwM+5KmnHSrGO8lAWSS6pxeOoeQ8vMsAqpjS1KjIc0C1GqbeyNxigqAcGTg0XlFQhACwyTDJiZ0paU7woNa2WfB0VS2kTcCqp2hdIYHK4egAIhx1LYl5dpoqfjIrVI9vWnargglVREJf8z6VE5lWns5RO/ZOHaQm+dov+6Qih5MIuQWqfHyzQlXFuAM0AjVzGYcNSVpnO5L4cLkke9GunZZ8PjbGLUHFUE1SdXSQqOIGzzJYWQPKpEjrFgPEkUjmsePx3EK70gEcMFkPYOWSIMQ1S78LAzrXf9DL7tGu8mp2eOpKbMiGjHzl7Uj+3+Y8bCpGUhVTpx8x2hhr1B9ozVEzA/ALH3OAeSfIym+7ok= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36756003)(26005)(31696002)(2906002)(36860700001)(31686004)(82310400005)(508600001)(8936002)(316002)(9786002)(356005)(53546011)(186003)(107886003)(2616005)(54906003)(40460700003)(110136005)(7636003)(426003)(336012)(44832011)(8676002)(83380400001)(6666004)(47076005)(4326008)(5660300002)(70586007)(70206006)(50156003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:36:24.9737 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 755032d1-44c8-41f4-fe44-08da29bb58c2 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT011.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4571 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/22 12:55, Ronak Jain wrote: > Enable the feature check if the PM_FEATURE_CHECK API returns success > with the supported version for the ZynqMP. Currently, it is enabled > for Versal only. > > Move get_set_conduit_method() at the beginning as the Linux is > requesting to TF-A for the PM_FEATURE_CHECK API version for which the > interface should be enabled with TF-A. > > Signed-off-by: Ronak Jain > --- > drivers/firmware/xilinx/zynqmp.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 6ee94f31ac98..7977a494a651 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -1662,6 +1662,10 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > struct zynqmp_devinfo *devinfo; > int ret; > > + ret = get_set_conduit_method(dev->of_node); > + if (ret) > + return ret; > + > np = of_find_compatible_node(NULL, NULL, "xlnx,zynqmp"); > if (!np) { > np = of_find_compatible_node(NULL, NULL, "xlnx,versal"); > @@ -1670,11 +1674,14 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > > feature_check_enabled = true; > } > - of_node_put(np); > > - ret = get_set_conduit_method(dev->of_node); > - if (ret) > - return ret; > + if (!feature_check_enabled) { > + ret = do_feature_check_call(PM_FEATURE_CHECK); > + if (ret >= 0) > + feature_check_enabled = true; > + } > + > + of_node_put(np); > > devinfo = devm_kzalloc(dev, sizeof(*devinfo), GFP_KERNEL); > if (!devinfo) Acked-by: Michal Simek Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFA3EC433EF for ; Fri, 29 Apr 2022 08:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FapjblbYfy6qEACAt+Ra4/ZSz8e2HzUYxNtSBL43uOY=; b=Hs+l7E0Fxg8WAA hp3x4/SB/cr3KslXL+2Ra7uKykv3rMAgC6QfziZ+mY6DCll6rhcYN/e93WoyWEHuaMN0+n5DW2VUC 2d7T3irldFzPjPr9/eSkYCRL7bHX9ZJ3YWw96a1lTSmGlSdDn2AQkdyELBLY2XsNFTdjq/YrUpb3f HhBBDHik7iJb4IbVtymgAy+Jmlz7S4xZw/CMZJVnaI62ZO9M4d3gv6SokkgC02nRqvgVTEaT0Exti bwHP37voRiltX931e38EXokvHK8tDZXXvljFPUMIcQf1VgBQpRiXUvwX2y+/I7n9qip/FImDLRQlc 2HuUF1xXsIRSmn740W5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkM7X-00ADdn-0c; Fri, 29 Apr 2022 08:36:59 +0000 Received: from mail-dm6nam12on20623.outbound.protection.outlook.com ([2a01:111:f400:fe59::623] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkM74-00ADRt-IR for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 08:36:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ncu0lO7OytiyC2WYvai7iVeHESAAhL8XMkH/gyLe5I523qjznHolWFJ/wR+6mlnGjqswgJBa/LBmhbMvaLWLmw394JJQR6QlqFSVzmswNWyrJ804MH3BysKsXn8JxfHa3aqt49vvn6ha1VUZE4klDWifCLazKxAhjMcLKcLcuykZ7hCnRDKUkStsW5kZeVT4TQV+LDzf3HaxwI8HFSyBQoZ2JxlyA6W6L+hrRfDwCXFDTGcT4WD4Xa8BZex/rTwPvIeHWJKcak9N3zvtUWXbSaB7ZNrGZbDr0cLjQXZjkAysMnBUcoRF/zdFmMqcRnwd+aNez/nA1Gk/rQLYRT5ebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nZGCC7ZajxlfZJ8cDUD0BxoPH4MAuXGnXcgI+GDLhGk=; b=S14kbxgcxgoHgN+fgYPXqdIXo+E4bzGad3stnS16u+WFFH/ZW5CZpiWCakPr99cI0sIhy1UOfAytkmNZWl+BziEXJY0vhkwmtN6VwvGse09NbxHfMW6WZSJFXumHwUTs1DCZrdaKMyjgT4HecDChXG4nDyuGZLgaKyb0JNg+3idshtDbFs6BFbMxUntK8Ebca3n7dsGOWHULQcUa+WwyhQ6OZr+ZGQyOf0ag+P6QmpqZc46WtLZFrIqeJCyiWZG8KoolilPPuFrvxQsOzmhZyHMUbXAKuwu+cqlJJOeqtDB/aImzkHW02AMl1UuC3EH0DtQuln0CDwlcxs3eVYdc2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nZGCC7ZajxlfZJ8cDUD0BxoPH4MAuXGnXcgI+GDLhGk=; b=bC9ObwgoOKyelz62YH/f5UUFm19643Eh1DhdfeBHA3kTIl1I5nK3P403RVKOjvpmuXCRc+um91eMvyCX0u1uDkjY4la7G6PTvauLnzyYWDU70vbBgu0UBzLncfiQDoh9pLSUGBygjykLhtolEfHIK7EBjcTHCKVUZ4fLIzcqEUo= Received: from BN9PR03CA0147.namprd03.prod.outlook.com (2603:10b6:408:fe::32) by DM6PR02MB4571.namprd02.prod.outlook.com (2603:10b6:5:1d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Fri, 29 Apr 2022 08:36:25 +0000 Received: from BN1NAM02FT011.eop-nam02.prod.protection.outlook.com (2603:10b6:408:fe:cafe::76) by BN9PR03CA0147.outlook.office365.com (2603:10b6:408:fe::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 29 Apr 2022 08:36:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT011.mail.protection.outlook.com (10.13.2.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:36:24 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:36:24 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:36:24 -0700 Received: from [10.254.241.50] (port=34552) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkM6y-0007Nh-BR; Fri, 29 Apr 2022 01:36:24 -0700 Message-ID: <50cc8c4b-4b75-d9f4-f0e8-bc246345920a@xilinx.com> Date: Fri, 29 Apr 2022 10:36:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 4/4] firmware: xilinx: enable feature check for ZynqMP Content-Language: en-US To: Ronak Jain , , CC: , , , , , References: <1649242526-17493-1-git-send-email-ronak.jain@xilinx.com> <1649242526-17493-5-git-send-email-ronak.jain@xilinx.com> From: Michal Simek In-Reply-To: <1649242526-17493-5-git-send-email-ronak.jain@xilinx.com> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 755032d1-44c8-41f4-fe44-08da29bb58c2 X-MS-TrafficTypeDiagnostic: DM6PR02MB4571:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FdHiJmklwvpPt5AkVoXqpaHcs5i84kXL4p9fMXngrYjEG2xn0wkQR5McDu7JphHmrWAoMXrD2qMy+DFG6hI0qdBurOFsxKsXI/4NQzjlLKBEiFGcGlgjLC/aJ1GHU/adLXzWc1kCmXw9EnOp4XcxBfUtGoDOeEIDWMTlgbKhtcyGRUnm7Kcpf1QFDek4rcyFiPHVAT4kxKmmlpr2QjseYkMimXlki3kQCod0lkOqYTUWvdgmg+pC7tUeSJkhPzIzXZQO7r1el/wevL61MRAVjqmbbMWgZZKsJvs6BszUqeQ3yLTi/gw7l8cHMRVXlXVCYeJqh0vfYBxp/Bo9XRG5pymxlXHXFTwNVv3KB5PCWiYQ21VmSSeiVm94AHL0FmeJ0IwM+5KmnHSrGO8lAWSS6pxeOoeQ8vMsAqpjS1KjIc0C1GqbeyNxigqAcGTg0XlFQhACwyTDJiZ0paU7woNa2WfB0VS2kTcCqp2hdIYHK4egAIhx1LYl5dpoqfjIrVI9vWnargglVREJf8z6VE5lWns5RO/ZOHaQm+dov+6Qih5MIuQWqfHyzQlXFuAM0AjVzGYcNSVpnO5L4cLkke9GunZZ8PjbGLUHFUE1SdXSQqOIGzzJYWQPKpEjrFgPEkUjmsePx3EK70gEcMFkPYOWSIMQ1S78LAzrXf9DL7tGu8mp2eOpKbMiGjHzl7Uj+3+Y8bCpGUhVTpx8x2hhr1B9ozVEzA/ALH3OAeSfIym+7ok= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36756003)(26005)(31696002)(2906002)(36860700001)(31686004)(82310400005)(508600001)(8936002)(316002)(9786002)(356005)(53546011)(186003)(107886003)(2616005)(54906003)(40460700003)(110136005)(7636003)(426003)(336012)(44832011)(8676002)(83380400001)(6666004)(47076005)(4326008)(5660300002)(70586007)(70206006)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:36:24.9737 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 755032d1-44c8-41f4-fe44-08da29bb58c2 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT011.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4571 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_013630_722842_95637398 X-CRM114-Status: GOOD ( 19.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/6/22 12:55, Ronak Jain wrote: > Enable the feature check if the PM_FEATURE_CHECK API returns success > with the supported version for the ZynqMP. Currently, it is enabled > for Versal only. > > Move get_set_conduit_method() at the beginning as the Linux is > requesting to TF-A for the PM_FEATURE_CHECK API version for which the > interface should be enabled with TF-A. > > Signed-off-by: Ronak Jain > --- > drivers/firmware/xilinx/zynqmp.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 6ee94f31ac98..7977a494a651 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -1662,6 +1662,10 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > struct zynqmp_devinfo *devinfo; > int ret; > > + ret = get_set_conduit_method(dev->of_node); > + if (ret) > + return ret; > + > np = of_find_compatible_node(NULL, NULL, "xlnx,zynqmp"); > if (!np) { > np = of_find_compatible_node(NULL, NULL, "xlnx,versal"); > @@ -1670,11 +1674,14 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > > feature_check_enabled = true; > } > - of_node_put(np); > > - ret = get_set_conduit_method(dev->of_node); > - if (ret) > - return ret; > + if (!feature_check_enabled) { > + ret = do_feature_check_call(PM_FEATURE_CHECK); > + if (ret >= 0) > + feature_check_enabled = true; > + } > + > + of_node_put(np); > > devinfo = devm_kzalloc(dev, sizeof(*devinfo), GFP_KERNEL); > if (!devinfo) Acked-by: Michal Simek Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel