From: Dmitry Osipenko <digetx@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 2/2] memory: tegra: Enable compile testing for all drivers
Date: Tue, 11 May 2021 21:30:53 +0300 [thread overview]
Message-ID: <50cd4ab0-95e2-4cf6-9092-53e1395af435@gmail.com> (raw)
In-Reply-To: <54acffad-97c0-56cd-46ba-5ceba454ec09@canonical.com>
11.05.2021 19:41, Krzysztof Kozlowski пишет:
> On 10/05/2021 17:37, Dmitry Osipenko wrote:
>> Enable compile testing for all Tegra memory drivers.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> drivers/memory/tegra/Kconfig | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
>> index a70967a56e52..a910f661105f 100644
>> --- a/drivers/memory/tegra/Kconfig
>> +++ b/drivers/memory/tegra/Kconfig
>> @@ -2,7 +2,7 @@
>> config TEGRA_MC
>> bool "NVIDIA Tegra Memory Controller support"
>> default y
>> - depends on ARCH_TEGRA
>> + depends on (ARCH_TEGRA || COMPILE_TEST)
>
> No need for ().
Okay
>> select INTERCONNECT
>> help
>> This driver supports the Memory Controller (MC) hardware found on
>> @@ -11,7 +11,7 @@ config TEGRA_MC
>> config TEGRA20_EMC
>> tristate "NVIDIA Tegra20 External Memory Controller driver"
>> default y
>> - depends on TEGRA_MC && ARCH_TEGRA_2x_SOC
>> + depends on TEGRA_MC && (ARCH_TEGRA_2x_SOC || COMPILE_TEST)
>
> There is a lot of "depends on TEGRA_MC". How about making it a "if
> TEGRA_MC" block?
The explicit dependencies are also good to me. Either variant is fine to
me. I can implement yours suggestion in v2 if Thierry doesn't have
objections.
prev parent reply other threads:[~2021-05-11 18:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 21:37 [PATCH v1 0/2] Enable compile-testing for Tegra memory drivers Dmitry Osipenko
2021-05-10 21:37 ` [PATCH v1 1/2] soc/tegra: fuse: Add missing stubs Dmitry Osipenko
2021-05-10 21:37 ` [PATCH v1 2/2] memory: tegra: Enable compile testing for all drivers Dmitry Osipenko
2021-05-11 13:58 ` kernel test robot
2021-05-11 13:58 ` kernel test robot
2021-05-11 15:17 ` Dmitry Osipenko
2021-05-11 15:17 ` Dmitry Osipenko
2021-05-11 15:31 ` Krzysztof Kozlowski
2021-05-11 15:31 ` Krzysztof Kozlowski
2021-05-11 16:00 ` Dmitry Osipenko
2021-05-11 16:00 ` Dmitry Osipenko
2021-05-11 17:35 ` Nathan Chancellor
2021-05-11 17:35 ` Nathan Chancellor
2021-05-11 17:57 ` Krzysztof Kozlowski
2021-05-11 17:57 ` Krzysztof Kozlowski
2021-05-11 18:36 ` Dmitry Osipenko
2021-05-11 18:36 ` Dmitry Osipenko
2021-05-11 15:43 ` kernel test robot
2021-05-11 15:43 ` kernel test robot
2021-05-11 16:22 ` Dmitry Osipenko
2021-05-11 16:22 ` Dmitry Osipenko
2021-05-11 16:41 ` Krzysztof Kozlowski
2021-05-11 18:30 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50cd4ab0-95e2-4cf6-9092-53e1395af435@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.