From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Tom St Denis <tom.stdenis@amd.com>,
christian.koenig@amd.com, amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2)
Date: Fri, 9 Feb 2018 19:44:49 +0100 [thread overview]
Message-ID: <50cdbb8f-3b64-bed3-322c-bcce05b39370@gmail.com> (raw)
In-Reply-To: <761fbdc6-bf8d-b8f4-350f-515418921b30@amd.com>
Am 09.02.2018 um 19:19 schrieb Tom St Denis:
> On 09/02/18 01:17 PM, Christian König wrote:
>> Am 09.02.2018 um 18:28 schrieb Tom St Denis:
>>> On 09/02/18 12:27 PM, Tom St Denis wrote:
>>>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>>>
>>> Oops, I'll remove this from the commit message before pushing :-)
>>>
>>> I did give you credit below though.
>>
>> The patch before this one isn't merged yet because I'm still not sure
>> if that works under all circumstances or not.
>>
>> Could you give it some extended testing? Especially if it work with
>> eviction.
>
> I supposed there is a race on the kmap'ed memory which is why I added
> a ptr check. Not perfect but since it's a debugfs entry probably
> better than it needs to be.
I think you can drop that, kmap can only return NULL on 32bit systems
when we ran out of vmap area and then you can basically call panic() as
well.
The question is if setting page->mapping during allocation has some
undesired side effect.
Christian.
>
> I'll give it a try on some live traffic next.
>
> Cheers,
> Tom
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-09 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:27 [PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2) Tom St Denis
[not found] ` <20180209172750.15675-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2018-02-09 17:28 ` Tom St Denis
[not found] ` <4708aad9-9ff0-d09f-9bb6-453c01c848a4-5C7GfCeVMHo@public.gmane.org>
2018-02-09 18:17 ` Christian König
[not found] ` <50edcafc-23dd-3c44-021f-cf5989d06dc2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-09 18:19 ` Tom St Denis
2018-02-09 18:44 ` Christian König [this message]
[not found] ` <50cdbb8f-3b64-bed3-322c-bcce05b39370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-12 16:40 ` Tom St Denis
2018-02-12 17:16 ` Christian König
[not found] ` <8c42ceb6-4c95-d82f-d347-37ee793855a6-5C7GfCeVMHo@public.gmane.org>
2018-02-12 19:08 ` Tom St Denis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50cdbb8f-3b64-bed3-322c-bcce05b39370@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tom.stdenis@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.