From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 26 Aug 2019 10:59:20 +0200 Subject: [U-Boot] [PATCH 2/4] fw_env: fix build error In-Reply-To: <471c4f31-06a0-f52f-0268-3bc776d8aee0@denx.de> References: <1566594199-25314-1-git-send-email-pjtexier@koncepto.io> <1566594199-25314-3-git-send-email-pjtexier@koncepto.io> <471c4f31-06a0-f52f-0268-3bc776d8aee0@denx.de> Message-ID: <50cf07f6-5e4c-3982-f8f8-f2f2d3adf748@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hello Pierre-Jean, Am 26.08.2019 um 08:57 schrieb Heiko Schocher: > Hello Jean-Pierre, > > Am 23.08.2019 um 23:03 schrieb Pierre-Jean Texier: >> The following error appears: >> >> tools/env/fw_env.c:1149:25: error: lvalue required as unary ‘&’ operand >>    rc = write(fd, &ENV_REDUND_OBSOLETE, sizeof(ENV_REDUND_OBSOLETE)); >> >> Fixes: d3716dd ("env: Rename the redundancy flags") >> >> Signed-off-by: Pierre-Jean Texier >> --- >>   tools/env/fw_env.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) > > See the same problem, thanks for the Fix! > > Tested-by: Heiko Schocher Testing deeper on an imx6 based board with Environment in SPI NOR, and I see: root at K30RF-5e108e:~# fw_setenv ubifitsz Could not set obsolete flag: Operation not supported Also with your patch ... :-( With follwoing change fw_setenv works again for me: hs at xmglap:u-boot [k30rf] $ git diff diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index b8b936f9ea..e2801f595f 100644 --- a/tools/env/fw_env.c +++ b/tools/env/fw_env.c @@ -1135,6 +1135,7 @@ static int flash_flag_obsolete(int dev, int fd, off_t offset) { int rc; struct erase_info_user erase; + char tmp = ENV_REDUND_OBSOLETE; erase.start = DEVOFFSET(dev); erase.length = DEVESIZE(dev); @@ -1146,7 +1147,7 @@ static int flash_flag_obsolete(int dev, int fd, off_t offset) return rc; } ioctl(fd, MEMUNLOCK, &erase); - rc = write(fd, ENV_REDUND_OBSOLETE, sizeof(ENV_REDUND_OBSOLETE)); + rc = write(fd, &tmp, sizeof(tmp)); ioctl(fd, MEMLOCK, &erase); if (rc < 0) perror("Could not set obsolete flag"); hs at xmglap:u-boot [k30rf] $ May you can try? bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de