From: Julien Grall <julien.grall@arm.com>
To: Andre Przywara <andre.przywara@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org,
Shanker Donthineni <shankerd@codeaurora.org>,
Vijay Kilari <vijay.kilari@gmail.com>
Subject: Re: [PATCH v3 03/26] ARM: GICv3 ITS: allocate device and collection table
Date: Mon, 3 Apr 2017 21:46:48 +0100 [thread overview]
Message-ID: <50dae25c-adee-6297-012e-b5a4bca52707@arm.com> (raw)
In-Reply-To: <ce08c621-ed51-e208-b2a3-580f6adfd0fe@arm.com>
On 04/03/2017 08:39 PM, Andre Przywara wrote:
> Hi,
>
> On 03/04/17 18:22, Julien Grall wrote:
>> Hi Andre,
>>
>> On 03/04/17 16:38, Julien Grall wrote:
>>> On 31/03/17 19:05, Andre Przywara wrote:
>>>> Each ITS maps a pair of a DeviceID (for instance derived from a PCI
>>>> b/d/f triplet) and an EventID (the MSI payload or interrupt ID) to a
>>>> pair of LPI number and collection ID, which points to the target CPU.
>>>> This mapping is stored in the device and collection tables, which
>>>> software
>>>> has to provide for the ITS to use.
>>>> Allocate the required memory and hand it to the ITS.
>>>> The maximum number of devices is limited to a compile-time constant
>>>> exposed in Kconfig.
>>>>
>>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>>
>>> Reviewed-by: Julien Grall <julien.grall@arm.com>
>>
>> Actually I will withdraw my reviewed-by. I didn't spot you keep the
>> command line around which I clearly say no and gave some reasons why.
>> Sorry for the mess.
> `
> I thought we were talking about the Kconfig option to drop here (which
> the commit msg wrongly states as still being around)?
>
> For implementations that don't support indirect tables, but still
> advertise high numbers, I'd find it useful to have the possibility to
> limit this to avoid memory waste.
Again, how the user will know the magic numbers? If the platform
advertises high device number, then it is none of our business. If the
number needs to be reduced, this should be a platform specific code.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-03 20:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 18:04 [PATCH v3 00/26] arm64: Dom0 ITS emulation Andre Przywara
2017-03-31 18:05 ` [PATCH v3 01/26] ARM: GICv3 ITS: parse and store ITS subnodes from hardware DT Andre Przywara
2017-03-31 23:08 ` Stefano Stabellini
2017-03-31 18:05 ` [PATCH v3 02/26] ARM: GICv3: allocate LPI pending and property table Andre Przywara
2017-03-31 22:59 ` Stefano Stabellini
2017-04-03 9:05 ` Andre Przywara
2017-04-03 18:16 ` Stefano Stabellini
2017-04-03 13:53 ` Julien Grall
2017-04-03 14:01 ` Julien Grall
2017-03-31 18:05 ` [PATCH v3 03/26] ARM: GICv3 ITS: allocate device and collection table Andre Przywara
2017-03-31 23:06 ` Stefano Stabellini
2017-04-03 15:38 ` Julien Grall
2017-04-03 17:22 ` Julien Grall
2017-04-03 19:39 ` Andre Przywara
2017-04-03 20:46 ` Julien Grall [this message]
2017-03-31 18:05 ` [PATCH v3 04/26] ARM: GICv3 ITS: map ITS command buffer Andre Przywara
2017-03-31 23:10 ` Stefano Stabellini
2017-04-03 16:00 ` Julien Grall
2017-03-31 18:05 ` [PATCH v3 05/26] ARM: GICv3 ITS: introduce ITS command handling Andre Przywara
2017-03-31 23:16 ` Stefano Stabellini
2017-04-03 17:32 ` Julien Grall
2017-03-31 18:05 ` [PATCH v3 06/26] ARM: GICv3 ITS: introduce device mapping Andre Przywara
2017-03-31 23:20 ` Stefano Stabellini
2017-04-01 8:01 ` Vijay Kilari
2017-04-03 18:33 ` Julien Grall
2017-04-03 18:56 ` Julien Grall
2017-03-31 18:05 ` [PATCH v3 07/26] ARM: GICv3 ITS: introduce host LPI array Andre Przywara
2017-03-31 23:24 ` Stefano Stabellini
2017-03-31 18:05 ` [PATCH v3 08/26] ARM: GICv3: introduce separate pending_irq structs for LPIs Andre Przywara
2017-03-31 18:05 ` [PATCH v3 09/26] ARM: GICv3: forward pending LPIs to guests Andre Przywara
2017-03-31 18:05 ` [PATCH v3 10/26] ARM: GICv3: enable ITS and LPIs on the host Andre Przywara
2017-03-31 18:05 ` [PATCH v3 11/26] ARM: vGICv3: handle virtual LPI pending and property tables Andre Przywara
2017-04-04 12:55 ` Julien Grall
2017-04-04 12:56 ` Julien Grall
2017-03-31 18:05 ` [PATCH v3 12/26] ARM: vGICv3: Handle disabled LPIs Andre Przywara
2017-03-31 18:05 ` [PATCH v3 13/26] ARM: vGICv3: introduce basic ITS emulation bits Andre Przywara
2017-03-31 18:05 ` [PATCH v3 14/26] ARM: vITS: introduce translation table walks Andre Przywara
2017-03-31 18:05 ` [PATCH v3 15/26] ARM: vITS: handle CLEAR command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 16/26] ARM: vITS: handle INT command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 17/26] ARM: vITS: handle MAPC command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 18/26] ARM: vITS: handle MAPD command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 19/26] ARM: vITS: handle MAPTI command Andre Przywara
2017-04-01 8:32 ` Vijay Kilari
2017-03-31 18:05 ` [PATCH v3 20/26] ARM: vITS: handle MOVI command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 21/26] ARM: vITS: handle DISCARD command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 22/26] ARM: vITS: handle INV command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 23/26] ARM: vITS: handle INVALL command Andre Przywara
2017-03-31 18:05 ` [PATCH v3 24/26] ARM: vITS: create and initialize virtual ITSes for Dom0 Andre Przywara
2017-03-31 18:05 ` [PATCH v3 25/26] ARM: vITS: create ITS subnodes for Dom0 DT Andre Przywara
2017-03-31 18:05 ` [PATCH v3 26/26] ARM: vGIC: advertise LPI support Andre Przywara
2017-04-04 17:06 ` Julien Grall
2017-04-01 20:37 ` [PATCH v3 00/26] arm64: Dom0 ITS emulation Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50dae25c-adee-6297-012e-b5a4bca52707@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vijay.kilari@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.