All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
	Eduardo Habkost <ehabkost@redhat.com>,
	qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-trivial@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/10] thunk.c: clean up commented out definition
Date: Thu, 4 Oct 2018 12:31:04 -0400	[thread overview]
Message-ID: <50e4aeaa-7f4f-03b3-05ae-2a29deac9662@redhat.com> (raw)
In-Reply-To: <4f0850d2-3baa-7acc-d34b-98f074f1a2f8@vivier.eu>



On 10/4/18 12:24 PM, Laurent Vivier wrote:
> Le 04/10/2018 à 18:18, Cleber Rosa a écrit :
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>>  thunk.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/thunk.c b/thunk.c
>> index d5d8645cd4..e351ae53af 100644
>> --- a/thunk.c
>> +++ b/thunk.c
>> @@ -21,8 +21,6 @@
>>  #include "qemu.h"
>>  #include "exec/user/thunk.h"
>>  
>> -//#define DEBUG
>> -
> 
> Generally we use that to enable easily existing debug traces.
> 

Oh, I wasn't aware that was intentional (I clearly lack some background
here).

> In this case, if you remove the "#define" I think you should also
> replace the "#ifdef DEBUG"s by some trace_XXXX() functions.
> 

Is that desirable? I don't want to disrupt the status quo just because
it looked odd to me.

Thanks!
- Cleber.

> Thanks,
> Laurent
> 

  reply	other threads:[~2018-10-04 16:31 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 16:18 [Qemu-devel] [PATCH 00/10] Trivial fixes and clean ups Cleber Rosa
2018-10-04 16:18 ` [Qemu-devel] [PATCH 01/10] qemu-img.c: comment typo fix Cleber Rosa
2018-10-04 16:48   ` Eric Blake
2018-10-04 16:53     ` Cleber Rosa
2018-10-05 13:31       ` Philippe Mathieu-Daudé
2018-10-05 13:40     ` Peter Maydell
2018-10-04 16:18 ` [Qemu-devel] [PATCH 02/10] tests/tcg/README: fix location for lm32 tests Cleber Rosa
2018-10-05  6:41   ` Thomas Huth
2018-10-05 13:51   ` Alex Bennée
2018-10-25 13:55   ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable Cleber Rosa
2018-10-04 16:48   ` Eric Blake
2018-10-05 13:36   ` Philippe Mathieu-Daudé
2018-10-05 17:49     ` Cleber Rosa
2018-10-05 18:02       ` Eric Blake
2018-10-05 18:19         ` Eric Blake
2018-10-25 13:57   ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 04/10] qemu-iotests: fix filename containing checks Cleber Rosa
2018-10-05 13:38   ` Philippe Mathieu-Daudé
2018-10-25 13:56   ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block Cleber Rosa
2018-10-08 19:49   ` [Qemu-devel] [Qemu-block] " John Snow
2018-10-25 13:59   ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 06/10] thunk.c: clean up commented out definition Cleber Rosa
2018-10-04 16:24   ` Laurent Vivier
2018-10-04 16:31     ` Cleber Rosa [this message]
2018-10-04 16:36       ` Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 07/10] scripts/decodetree.py: remove unused imports Cleber Rosa
2018-10-05 13:39   ` Philippe Mathieu-Daudé
2018-10-25 13:59   ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes Cleber Rosa
2018-10-05 13:40   ` Philippe Mathieu-Daudé
2018-10-04 16:18 ` [Qemu-devel] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style Cleber Rosa
2018-10-04 16:50   ` Eric Blake
2018-10-04 16:53     ` Cleber Rosa
2018-10-08 19:44   ` [Qemu-devel] [Qemu-block] " John Snow
2018-10-26 15:25     ` Eduardo Habkost
2018-10-04 16:18 ` [Qemu-devel] [PATCH 10/10] scripts/qemu.py: remove trailing quotes on docstring Cleber Rosa
2018-10-05 13:41   ` Philippe Mathieu-Daudé
2018-10-25 14:00   ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-26 15:27 ` [Qemu-devel] [PATCH 00/10] Trivial fixes and clean ups Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50e4aeaa-7f4f-03b3-05ae-2a29deac9662@redhat.com \
    --to=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.