From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91CBC4338F for ; Thu, 19 Aug 2021 15:18:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA22F60F5E for ; Thu, 19 Aug 2021 15:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238681AbhHSPTb (ORCPT ); Thu, 19 Aug 2021 11:19:31 -0400 Received: from mga02.intel.com ([134.134.136.20]:14350 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232821AbhHSPT3 (ORCPT ); Thu, 19 Aug 2021 11:19:29 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10081"; a="203777064" X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="203777064" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 08:18:48 -0700 X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="489703501" Received: from mmdandap-mobl.amr.corp.intel.com (HELO [10.213.172.210]) ([10.213.172.210]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 08:18:46 -0700 Subject: Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373 To: Cezary Rojewski , Lukasz Majczak Cc: upstream@semihalf.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Curtis Malainey , stable@vger.kernel.org References: <20210819082414.39497-1-lma@semihalf.com> <87736cce-a96f-064e-6d60-71645ba46f13@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <50eb6c88-5f1a-7a42-adaf-da16f711e5c5@linux.intel.com> Date: Thu, 19 Aug 2021 10:18:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/19/21 10:06 AM, Cezary Rojewski wrote: > On 2021-08-19 4:30 PM, Pierre-Louis Bossart wrote: >> On 8/19/21 3:24 AM, Lukasz Majczak wrote: >>> Sparse warnings triggered truncating the IDs of some platform device >>> tables. Unfortunately kbl_da7219_max98373 was also truncated. >>> This patch is reverting the original ID. >>> Tested on Atlas chromebook. >> >> Instead of reverting, how about changing the remaining occurrences of >> the old name in the machine driver? >> >> sound/soc/intel/boards/kbl_da7219_max98927.c:   if (!strcmp(pdev->name, >> "kbl_da7219_max98373") || >> sound/soc/intel/boards/kbl_da7219_max98927.c:           .name = >> "kbl_da7219_max98373", > > Mentioned by 'Fixes' tag patch clearly introduced regression. If we are > to update any name-fields, it's better to have a fresh start and update > all the boards in one-go than doing so separately. > > Apart from that, Maxim codecs go by the name of 'max' in > sound/soc/codecs/. It's more intuitive to have equivalent shortcut used > in board's name. the ACPI HID start with MX and there's not much consistency in naming, is there? .drv_name = "kbl_r5514_5663_max", .drv_name = "kbl_rt5663_m98927", .drv_name = "kbl_da7219_mx98357a", .drv_name = "kbl_da7219_max98927", .drv_name = "kbl_max98373", Reviewed-by: Pierre-Louis Bossart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9032C4338F for ; Thu, 19 Aug 2021 15:19:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A739D60F5E for ; Thu, 19 Aug 2021 15:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A739D60F5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 117FA1689; Thu, 19 Aug 2021 17:19:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 117FA1689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629386394; bh=HAVW71dZNQhgeIsQaFVyNX/AKtA5V/U7UmPSrxQma6U=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=enhgxzE4NCC0m5QrfNbpc13nZfFVEM651GKBGUlL9Vy5MU4pSM9P4xP/S7cufr6J+ HcfFzr5xQiM4FbPckpN8Xjg5bT70v98ey3FCBYwtcHMLxTWxl2cHaPmn6X2J0UQ4Pb E+JITRDqUhKc3ZYr3CuPN4FDIELgDB5oUCCJLIxs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E654CF800F8; Thu, 19 Aug 2021 17:19:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B3915F8026D; Thu, 19 Aug 2021 17:19:00 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 25C42F8026D for ; Thu, 19 Aug 2021 17:18:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 25C42F8026D X-IronPort-AV: E=McAfee;i="6200,9189,10081"; a="238696714" X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="238696714" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 08:18:47 -0700 X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="489703501" Received: from mmdandap-mobl.amr.corp.intel.com (HELO [10.213.172.210]) ([10.213.172.210]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 08:18:46 -0700 Subject: Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373 To: Cezary Rojewski , Lukasz Majczak References: <20210819082414.39497-1-lma@semihalf.com> <87736cce-a96f-064e-6d60-71645ba46f13@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <50eb6c88-5f1a-7a42-adaf-da16f711e5c5@linux.intel.com> Date: Thu, 19 Aug 2021 10:18:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: Curtis Malainey , alsa-devel@alsa-project.org, upstream@semihalf.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 8/19/21 10:06 AM, Cezary Rojewski wrote: > On 2021-08-19 4:30 PM, Pierre-Louis Bossart wrote: >> On 8/19/21 3:24 AM, Lukasz Majczak wrote: >>> Sparse warnings triggered truncating the IDs of some platform device >>> tables. Unfortunately kbl_da7219_max98373 was also truncated. >>> This patch is reverting the original ID. >>> Tested on Atlas chromebook. >> >> Instead of reverting, how about changing the remaining occurrences of >> the old name in the machine driver? >> >> sound/soc/intel/boards/kbl_da7219_max98927.c:   if (!strcmp(pdev->name, >> "kbl_da7219_max98373") || >> sound/soc/intel/boards/kbl_da7219_max98927.c:           .name = >> "kbl_da7219_max98373", > > Mentioned by 'Fixes' tag patch clearly introduced regression. If we are > to update any name-fields, it's better to have a fresh start and update > all the boards in one-go than doing so separately. > > Apart from that, Maxim codecs go by the name of 'max' in > sound/soc/codecs/. It's more intuitive to have equivalent shortcut used > in board's name. the ACPI HID start with MX and there's not much consistency in naming, is there? .drv_name = "kbl_r5514_5663_max", .drv_name = "kbl_rt5663_m98927", .drv_name = "kbl_da7219_mx98357a", .drv_name = "kbl_da7219_max98927", .drv_name = "kbl_max98373", Reviewed-by: Pierre-Louis Bossart