All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 0/1] update copyright notice
@ 2019-03-04 15:18 David Kiarie
  2019-03-04 15:18 ` [Qemu-devel] [PATCH 1/1] " David Kiarie
  2019-03-04 20:52 ` [Qemu-devel] [PATCH v4? 0/1] " Eric Blake
  0 siblings, 2 replies; 14+ messages in thread
From: David Kiarie @ 2019-03-04 15:18 UTC (permalink / raw)
  To: qemu-devel
  Cc: pbonzini, marcel.apfelbaum, rth, jan.kiszka, peterx, mst, David Kiarie

i think it is best put as i've updated.

David Kiarie (1):
  update copyright notice

 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.21.0

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 15:18 [Qemu-devel] [PATCH 0/1] update copyright notice David Kiarie
@ 2019-03-04 15:18 ` David Kiarie
  2019-03-04 17:48   ` Philippe Mathieu-Daudé
  2019-03-04 20:52 ` [Qemu-devel] [PATCH v4? 0/1] " Eric Blake
  1 sibling, 1 reply; 14+ messages in thread
From: David Kiarie @ 2019-03-04 15:18 UTC (permalink / raw)
  To: qemu-devel
  Cc: pbonzini, marcel.apfelbaum, rth, jan.kiszka, peterx, mst, David Kiarie

Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
---
 hw/i386/amd_iommu.c | 2 +-
 hw/i386/amd_iommu.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 8ad707a..6eabdf9 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -2,7 +2,7 @@
  * QEMU emulation of AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
index c52886f..0ff9095 100644
--- a/hw/i386/amd_iommu.h
+++ b/hw/i386/amd_iommu.h
@@ -2,7 +2,7 @@
  * QEMU emulation of an AMD IOMMU (AMD-Vi)
  *
  * Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
+ * Copyright (C) 2015, 2016 David Kiarie Kahurani
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 15:18 ` [Qemu-devel] [PATCH 1/1] " David Kiarie
@ 2019-03-04 17:48   ` Philippe Mathieu-Daudé
  2019-03-04 19:20     ` David Kiarie
  0 siblings, 1 reply; 14+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-04 17:48 UTC (permalink / raw)
  To: David Kiarie, qemu-devel; +Cc: mst, jan.kiszka, peterx, pbonzini, rth

On 3/4/19 4:18 PM, David Kiarie wrote:
> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/i386/amd_iommu.c | 2 +-
>  hw/i386/amd_iommu.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> index 8ad707a..6eabdf9 100644
> --- a/hw/i386/amd_iommu.c
> +++ b/hw/i386/amd_iommu.c
> @@ -2,7 +2,7 @@
>   * QEMU emulation of AMD IOMMU (AMD-Vi)
>   *
>   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
> index c52886f..0ff9095 100644
> --- a/hw/i386/amd_iommu.h
> +++ b/hw/i386/amd_iommu.h
> @@ -2,7 +2,7 @@
>   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>   *
>   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 17:48   ` Philippe Mathieu-Daudé
@ 2019-03-04 19:20     ` David Kiarie
  2019-03-04 19:29       ` David Kiarie
       [not found]       ` <546a3879-6cf6-b248-c6df-62489730be57@redhat.com>
  0 siblings, 2 replies; 14+ messages in thread
From: David Kiarie @ 2019-03-04 19:20 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> On 3/4/19 4:18 PM, David Kiarie wrote:
> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>

would i be wrong to say this patch received unwarranted scrutiny from you,
Philippe?


> > ---
> >  hw/i386/amd_iommu.c | 2 +-
> >  hw/i386/amd_iommu.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> > index 8ad707a..6eabdf9 100644
> > --- a/hw/i386/amd_iommu.c
> > +++ b/hw/i386/amd_iommu.c
> > @@ -2,7 +2,7 @@
> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
> >   *
> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
> >   *
> >   * This program is free software; you can redistribute it and/or modify
> >   * it under the terms of the GNU General Public License as published by
> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
> > index c52886f..0ff9095 100644
> > --- a/hw/i386/amd_iommu.h
> > +++ b/hw/i386/amd_iommu.h
> > @@ -2,7 +2,7 @@
> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
> >   *
> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
> >   *
> >   * This program is free software; you can redistribute it and/or modify
> >   * it under the terms of the GNU General Public License as published by
> >
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 19:20     ` David Kiarie
@ 2019-03-04 19:29       ` David Kiarie
  2019-03-04 19:30         ` David Kiarie
  2019-03-04 20:01         ` Philippe Mathieu-Daudé
       [not found]       ` <546a3879-6cf6-b248-c6df-62489730be57@redhat.com>
  1 sibling, 2 replies; 14+ messages in thread
From: David Kiarie @ 2019-03-04 19:29 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
>> On 3/4/19 4:18 PM, David Kiarie wrote:
>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>
> would i be wrong to say this patch received unwarranted scrutiny from you,
> Philippe?
>

i mean, given you have never been involved in any IOMMU work, i wouldn't
expect that you're in a position to asking questions about the copyright.


>
>
>> > ---
>> >  hw/i386/amd_iommu.c | 2 +-
>> >  hw/i386/amd_iommu.h | 2 +-
>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>> > index 8ad707a..6eabdf9 100644
>> > --- a/hw/i386/amd_iommu.c
>> > +++ b/hw/i386/amd_iommu.c
>> > @@ -2,7 +2,7 @@
>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>> >   *
>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>> >   *
>> >   * This program is free software; you can redistribute it and/or modify
>> >   * it under the terms of the GNU General Public License as published by
>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>> > index c52886f..0ff9095 100644
>> > --- a/hw/i386/amd_iommu.h
>> > +++ b/hw/i386/amd_iommu.h
>> > @@ -2,7 +2,7 @@
>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>> >   *
>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>> >   *
>> >   * This program is free software; you can redistribute it and/or modify
>> >   * it under the terms of the GNU General Public License as published by
>> >
>>
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 19:29       ` David Kiarie
@ 2019-03-04 19:30         ` David Kiarie
  2019-03-04 19:36           ` David Kiarie
  2019-03-04 20:01         ` Philippe Mathieu-Daudé
  1 sibling, 1 reply; 14+ messages in thread
From: David Kiarie @ 2019-03-04 19:30 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

On Mon, Mar 4, 2019 at 10:29 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <davidkiarie4@gmail.com>
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com>
>> wrote:
>>
>>> On 3/4/19 4:18 PM, David Kiarie wrote:
>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>
>>
>> would i be wrong to say this patch received unwarranted scrutiny from
>> you, Philippe?
>>
>
> i mean, given you have never been involved in any IOMMU work, i wouldn't
> expect that you're in a position to asking questions about the copyright.
>

yet, for some strange reason, you just couldn't help it.

ok.


>
>
>>
>>
>>> > ---
>>> >  hw/i386/amd_iommu.c | 2 +-
>>> >  hw/i386/amd_iommu.h | 2 +-
>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>> >
>>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>>> > index 8ad707a..6eabdf9 100644
>>> > --- a/hw/i386/amd_iommu.c
>>> > +++ b/hw/i386/amd_iommu.c
>>> > @@ -2,7 +2,7 @@
>>> >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>>> >   *
>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>>> >   *
>>> >   * This program is free software; you can redistribute it and/or
>>> modify
>>> >   * it under the terms of the GNU General Public License as published
>>> by
>>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>>> > index c52886f..0ff9095 100644
>>> > --- a/hw/i386/amd_iommu.h
>>> > +++ b/hw/i386/amd_iommu.h
>>> > @@ -2,7 +2,7 @@
>>> >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>>> >   *
>>> >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com>
>>> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>>> >   *
>>> >   * This program is free software; you can redistribute it and/or
>>> modify
>>> >   * it under the terms of the GNU General Public License as published
>>> by
>>> >
>>>
>>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 19:30         ` David Kiarie
@ 2019-03-04 19:36           ` David Kiarie
  0 siblings, 0 replies; 14+ messages in thread
From: David Kiarie @ 2019-03-04 19:36 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

>>>
>>> On 3/4/19 4:18 PM, David Kiarie wrote:
>>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>>>
>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>
>>>
>>> would i be wrong to say this patch received unwarranted scrutiny from
>>> you, Philippe?
>>>
>>
>> i mean, given you have never been involved in any IOMMU work, i wouldn't
>> expect that you're in a position to asking questions about the copyright.
>>
>
> yet, for some strange reason, you just couldn't help it.
>
> ok.
>

and, by the way, if you can't answer my question, then your review is just
as good as none.


>
>
>>
>>
>>>
>>>>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 19:29       ` David Kiarie
  2019-03-04 19:30         ` David Kiarie
@ 2019-03-04 20:01         ` Philippe Mathieu-Daudé
  2019-03-04 20:11           ` David Kiarie
  1 sibling, 1 reply; 14+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-04 20:01 UTC (permalink / raw)
  To: David Kiarie
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

Hi David,

On 3/4/19 8:29 PM, David Kiarie wrote:
> 
> 
> On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <davidkiarie4@gmail.com
> <mailto:davidkiarie4@gmail.com>> wrote:
> 
> 
> 
>     On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé
>     <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
> 
>         On 3/4/19 4:18 PM, David Kiarie wrote:
>         > Signed-off-by: David Kiarie <davidkiarie4@gmail.com
>         <mailto:davidkiarie4@gmail.com>>
> 
>         Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com
>         <mailto:philmd@redhat.com>>
> 
> 
>     would i be wrong to say this patch received unwarranted scrutiny
>     from you, Philippe?
> 
> 
> i mean, given you have never been involved in any IOMMU work, i wouldn't
> expect that you're in a position to asking questions about the copyright.

IANAL and I have no knowledge of IOMMU indeed.
I noticed first this patch is sent from the same email used in this
copyright notice, then the patch content merged in commit d29a09ca684
was accepted in 2016 with a copyright date of 2015, hence your copyright
modification looks correct to me.

Regards,

Philippe.

>  
> 
> 
> 
>         > ---
>         >  hw/i386/amd_iommu.c | 2 +-
>         >  hw/i386/amd_iommu.h | 2 +-
>         >  2 files changed, 2 insertions(+), 2 deletions(-)
>         >
>         > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
>         > index 8ad707a..6eabdf9 100644
>         > --- a/hw/i386/amd_iommu.c
>         > +++ b/hw/i386/amd_iommu.c
>         > @@ -2,7 +2,7 @@
>         >   * QEMU emulation of AMD IOMMU (AMD-Vi)
>         >   *
>         >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>         > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com
>         <mailto:davidkiarie4@gmail.com>>
>         > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>         >   *
>         >   * This program is free software; you can redistribute it
>         and/or modify
>         >   * it under the terms of the GNU General Public License as
>         published by
>         > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
>         > index c52886f..0ff9095 100644
>         > --- a/hw/i386/amd_iommu.h
>         > +++ b/hw/i386/amd_iommu.h
>         > @@ -2,7 +2,7 @@
>         >   * QEMU emulation of an AMD IOMMU (AMD-Vi)
>         >   *
>         >   * Copyright (C) 2011 Eduard - Gabriel Munteanu
>         > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com
>         <mailto:davidkiarie4@gmail.com>>
>         > + * Copyright (C) 2015, 2016 David Kiarie Kahurani
>         >   *
>         >   * This program is free software; you can redistribute it
>         and/or modify
>         >   * it under the terms of the GNU General Public License as
>         published by
>         >
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-04 20:01         ` Philippe Mathieu-Daudé
@ 2019-03-04 20:11           ` David Kiarie
  0 siblings, 0 replies; 14+ messages in thread
From: David Kiarie @ 2019-03-04 20:11 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, Daniel P. Berrange
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

>
> IANAL and I have no knowledge of IOMMU indeed.
> I noticed first this patch is sent from the same email used in this
> copyright notice, then the patch content merged in commit d29a09ca684
> was accepted in 2016 with a copyright date of 2015, hence your copyright
> modification looks correct to me.
>
> Regards,
>
> Philippe.


it looks like i already discarded(in the confusion that issued from Qemu
not being able to merge a simple patch and creating theories around it)
Daniel's review, wouldn't it be unfair to keep yours?


> >
> >
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH v4? 0/1] update copyright notice
  2019-03-04 15:18 [Qemu-devel] [PATCH 0/1] update copyright notice David Kiarie
  2019-03-04 15:18 ` [Qemu-devel] [PATCH 1/1] " David Kiarie
@ 2019-03-04 20:52 ` Eric Blake
  2019-03-05 14:16   ` David Kiarie
  1 sibling, 1 reply; 14+ messages in thread
From: Eric Blake @ 2019-03-04 20:52 UTC (permalink / raw)
  To: David Kiarie, qemu-devel; +Cc: mst, jan.kiszka, peterx, pbonzini, rth

On 3/4/19 9:18 AM, David Kiarie wrote:
> i think it is best put as i've updated.
> 
> David Kiarie (1):
>    update copyright notice
> 
>   hw/i386/amd_iommu.c | 2 +-
>   hw/i386/amd_iommu.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

You have now posted two separate threads with identical subjects but 
with different contents. As a courtesy to your reviewers, and to help 
the maintainers know for sure which version you want incorporated, it 
would have been nicer if you had used 'git send-email -v4' for this 
series, to differentiate it from v3 (if I counted right) sent at 
https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06457.html, as 
well as summarizing how this version differs from the previous.

That said, I do not think you need to send a v5 just to fix the subject 
line in the cover letter (as the cover letter doesn't end up in git 
anyways), especially since Paolo has already said he will queue your 
patch, and I trust Paolo to get the right version included.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH v4? 0/1] update copyright notice
  2019-03-04 20:52 ` [Qemu-devel] [PATCH v4? 0/1] " Eric Blake
@ 2019-03-05 14:16   ` David Kiarie
  2019-03-05 14:30     ` David Kiarie
  0 siblings, 1 reply; 14+ messages in thread
From: David Kiarie @ 2019-03-05 14:16 UTC (permalink / raw)
  To: Eric Blake
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

On Mon, Mar 4, 2019 at 11:52 PM Eric Blake <eblake@redhat.com> wrote:

> On 3/4/19 9:18 AM, David Kiarie wrote:
> > i think it is best put as i've updated.
> >
> > David Kiarie (1):
> >    update copyright notice
> >
> >   hw/i386/amd_iommu.c | 2 +-
> >   hw/i386/amd_iommu.h | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
>
> You have now posted two separate threads with identical subjects but
> with different contents. As a courtesy to your reviewers, and to help
> the maintainers know for sure which version you want incorporated, it
> would have been nicer if you had used 'git send-email -v4' for this
> series, to differentiate it from v3 (if I counted right) sent at
> https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06457.html, as
> well as summarizing how this version differs from the previous.
>
> That said, I do not think you need to send a v5 just to fix the subject
> line in the cover letter (as the cover letter doesn't end up in git
> anyways), especially since Paolo has already said he will queue your
> patch, and I trust Paolo to get the right version included.
>

i am not okay with maintainer behaviour, this is just something personal.

i will definitely send v4 but this series will include a patch stripping
all AMD IOMMU code from for Paolo to choose what to merge.


> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH v4? 0/1] update copyright notice
  2019-03-05 14:16   ` David Kiarie
@ 2019-03-05 14:30     ` David Kiarie
  0 siblings, 0 replies; 14+ messages in thread
From: David Kiarie @ 2019-03-05 14:30 UTC (permalink / raw)
  To: Eric Blake
  Cc: QEMU Developers, Michael S. Tsirkin, Jan Kiszka, Peter Xu,
	Paolo Bonzini, Richard Henderson

On Tue, Mar 5, 2019 at 5:16 PM David Kiarie <davidkiarie4@gmail.com> wrote:

>
>
> On Mon, Mar 4, 2019 at 11:52 PM Eric Blake <eblake@redhat.com> wrote:
>
>> On 3/4/19 9:18 AM, David Kiarie wrote:
>> > i think it is best put as i've updated.
>> >
>> > David Kiarie (1):
>> >    update copyright notice
>> >
>> >   hw/i386/amd_iommu.c | 2 +-
>> >   hw/i386/amd_iommu.h | 2 +-
>> >   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> You have now posted two separate threads with identical subjects but
>> with different contents. As a courtesy to your reviewers, and to help
>> the maintainers know for sure which version you want incorporated, it
>> would have been nicer if you had used 'git send-email -v4' for this
>> series, to differentiate it from v3 (if I counted right) sent at
>> https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06457.html, as
>> well as summarizing how this version differs from the previous.
>>
>> That said, I do not think you need to send a v5 just to fix the subject
>> line in the cover letter (as the cover letter doesn't end up in git
>> anyways), especially since Paolo has already said he will queue your
>> patch, and I trust Paolo to get the right version included.
>>
>
> i am not okay with maintainer behaviour, this is just something personal.
>

Paolo noted that code doesn't get merged right away on Qemu.

consider this:

i)  i don't have any interests whatsoever in Qemu and will never have

ii) i will never have any interests in Qemu

iii) i have zero interests in the code we are updating let alone the bugs i
recently helped report on this list.

iv)i am taking my own time to send this patch which was merely supposed to
reduce any such confusion reporting bugs in the future.

v)* maintainer - patches don't merged right away unless they fix broken
things, i have your patch queued. honestly?*

what are we queuing for? why not just rid of rest of my code because this
is the epitome of maintainer arrogance.


> i will definitely send v4 but this series will include a patch stripping
> all AMD IOMMU code from for Paolo to choose what to merge.
>
>
>> --
>> Eric Blake, Principal Software Engineer
>> Red Hat, Inc.           +1-919-301-3226
>> Virtualization:  qemu.org | libvirt.org
>>
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Qemu-devel] Fwd:  [PATCH 1/1] update copyright notice
       [not found]       ` <546a3879-6cf6-b248-c6df-62489730be57@redhat.com>
@ 2019-03-05 14:36         ` David Kiarie
  2019-03-05 15:19           ` [Qemu-devel] " David Kiarie
  0 siblings, 1 reply; 14+ messages in thread
From: David Kiarie @ 2019-03-05 14:36 UTC (permalink / raw)
  To: Jan Kiszka, Eric Blake, QEMU Developers, Michael S. Tsirkin,
	Paolo Bonzini, Philippe Mathieu-Daudé

i hope you don't find this offensive, Eric but i'm forwarding this message
to all the people on this thread.

i don't find anything exactly private in this email.

[off-list]

On 3/4/19 1:20 PM, David Kiarie wrote:
> On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
>> On 3/4/19 4:18 PM, David Kiarie wrote:
>>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>
> would i be wrong to say this patch received unwarranted scrutiny from you,
> Philippe?

David, please calm down, and don't write emails that can sound like you
are attacking your reviewers on list.  Assume good intent - Philippe
reviewed your patch with the same level of scrutiny as many other
patches he reviews, and his question for your previous patch revision
about whether you intended to change the copyright year was not an
attack, but an honest question.

Open source works best when anyone feels like they can contribute.
Copyright lines are an interesting beast - they carry legal
significance, so care should be taken that they aren't changed by
mistake, but at the same time, you do not have to know the code that the
copyright is protecting to ask an honest question about whether a change
is intentional.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Qemu-devel] [PATCH 1/1] update copyright notice
  2019-03-05 14:36         ` [Qemu-devel] Fwd: " David Kiarie
@ 2019-03-05 15:19           ` David Kiarie
  0 siblings, 0 replies; 14+ messages in thread
From: David Kiarie @ 2019-03-05 15:19 UTC (permalink / raw)
  To: Jan Kiszka, Eric Blake, QEMU Developers, Michael S. Tsirkin,
	Paolo Bonzini, Philippe Mathieu-Daudé

On Tue, Mar 5, 2019 at 5:36 PM David Kiarie <davidkiarie4@gmail.com> wrote:

> i hope you don't find this offensive, Eric but i'm forwarding this message
> to all the people on this thread.
>
> i don't find anything exactly private in this email.
>
> [off-list]
>
> On 3/4/19 1:20 PM, David Kiarie wrote:
> > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com
> >
> > wrote:
> >
> >> On 3/4/19 4:18 PM, David Kiarie wrote:
> >>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
> >>
> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >>
> >
> > would i be wrong to say this patch received unwarranted scrutiny from
> you,
> > Philippe?
>
> David, please calm down, and don't write emails that can sound like you
> are attacking your reviewers on list.  Assume good intent - Philippe
> reviewed your patch with the same level of scrutiny as many other
> patches he reviews, and his question for your previous patch revision
> about whether you intended to change the copyright year was not an
> attack, but an honest question.
>
> Open source works best when anyone feels like they can contribute.
> Copyright lines are an interesting beast - they carry legal
> significance, so care should be taken that they aren't changed by
> mistake, but at the same time, you do not have to know the code that the
> copyright is protecting to ask an honest question about whether a change
> is intentional.
>

it's simply not fair for me to waiting for you guys to merge this patch. i
sent both, you can pick whichever.


>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-03-05 15:19 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 15:18 [Qemu-devel] [PATCH 0/1] update copyright notice David Kiarie
2019-03-04 15:18 ` [Qemu-devel] [PATCH 1/1] " David Kiarie
2019-03-04 17:48   ` Philippe Mathieu-Daudé
2019-03-04 19:20     ` David Kiarie
2019-03-04 19:29       ` David Kiarie
2019-03-04 19:30         ` David Kiarie
2019-03-04 19:36           ` David Kiarie
2019-03-04 20:01         ` Philippe Mathieu-Daudé
2019-03-04 20:11           ` David Kiarie
     [not found]       ` <546a3879-6cf6-b248-c6df-62489730be57@redhat.com>
2019-03-05 14:36         ` [Qemu-devel] Fwd: " David Kiarie
2019-03-05 15:19           ` [Qemu-devel] " David Kiarie
2019-03-04 20:52 ` [Qemu-devel] [PATCH v4? 0/1] " Eric Blake
2019-03-05 14:16   ` David Kiarie
2019-03-05 14:30     ` David Kiarie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.