From: Dmitry Osipenko <digetx@gmail.com>
To: Wei Yang <richardw.yang@linux.intel.com>,
akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
kirill@shutemov.name, dan.j.williams@intel.com,
yang.shi@linux.alibaba.com, thellstrom@vmware.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little
Date: Fri, 31 Jan 2020 01:18:00 +0300 [thread overview]
Message-ID: <50f408bd-502e-bd02-53d4-719300736ce2@gmail.com> (raw)
In-Reply-To: <20200129002642.13508-1-richardw.yang@linux.intel.com>
29.01.2020 03:26, Wei Yang пишет:
> move_page_tables() tries to move page table by PMD or PTE.
>
> The root reason is if it tries to move PMD, both old and new range should
> be PMD aligned. But current code calculate old range and new range
> separately. This leads to some redundant check and calculation.
>
> This cleanup tries to consolidate the range check in one place to reduce
> some extra range handling.
>
> v2:
> * remove 3rd patch which doesn't work on ARM platform. Thanks report from
> Dmitry Osipenko
>
> Wei Yang (4):
> mm/mremap: format the check in move_normal_pmd() same as
> move_huge_pmd()
> mm/mremap: it is sure to have enough space when extent meets
> requirement
> mm/mremap: calculate extent in one place
> mm/mremap: start addresses are properly aligned
>
> include/linux/huge_mm.h | 2 +-
> mm/huge_memory.c | 8 +-------
> mm/mremap.c | 17 ++++++-----------
> 3 files changed, 8 insertions(+), 19 deletions(-)
>
Hello Wei,
I haven't noticed any problems using the v2. Thank you very much for
addressing the problem!
Tested-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2020-01-30 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 0:26 [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-01-29 0:26 ` [Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd() Wei Yang
2020-01-29 0:26 ` [Patch v2 2/4] mm/mremap: it is sure to have enough space when extent meets requirement Wei Yang
2020-01-29 0:26 ` [Patch v2 3/4] mm/mremap: calculate extent in one place Wei Yang
2020-01-29 0:26 ` [Patch v2 4/4] mm/mremap: start addresses are properly aligned Wei Yang
2020-01-30 22:18 ` Dmitry Osipenko [this message]
2020-01-30 23:05 ` [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50f408bd-502e-bd02-53d4-719300736ce2@gmail.com \
--to=digetx@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=thellstrom@vmware.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.