From: saravanan sekar <sravanhome@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: lee.jones@linaro.org, andy.shevchenko@gmail.com,
robh+dt@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, sre@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v10 1/6] dt-bindings: mfd: add document bindings for mp2629
Date: Sat, 18 Apr 2020 17:01:17 +0200 [thread overview]
Message-ID: <50ffb42e-4080-415e-dd3d-e38f7b0a6071@gmail.com> (raw)
In-Reply-To: <20200418155308.681df38f@archlinux>
Hi Jonathan,
On 18/04/20 4:53 pm, Jonathan Cameron wrote:
> On Fri, 17 Apr 2020 10:49:58 +0200
> Saravanan Sekar <sravanhome@gmail.com> wrote:
>
>> Add device tree binding information for mp2629 mfd driver.
>>
>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>> .../devicetree/bindings/mfd/mps,mp2629.yaml | 61 +++++++++++++++++++
>> 1 file changed, 61 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>> new file mode 100644
>> index 000000000000..b25b29259d67
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>> @@ -0,0 +1,61 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/mps,mp2629.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: MP2629 Battery Charger PMIC from Monolithic Power System.
>> +
>> +maintainers:
>> + - Saravanan Sekar <sravanhome@gmail.com>
>> +
>> +description: |
>> + MP2629 is a PMIC providing battery charging and power supply for smartphones,
>> + wireless camera and portable devices. Chip is controlled over I2C.
>> +
>> + The battery charge management device handles battery charger controller and
>> + ADC IIO device for battery, system voltage
>> +
>> +properties:
>> + compatible:
>> + const: mps,mp2629
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + interrupt-controller: true
>> +
>> + "#interrupt-cells":
>> + const: 2
>> + description:
>> + The first cell is the IRQ number, the second cell is the trigger type.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - interrupt-controller
>> + - "#interrupt-cells"
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + #include <dt-bindings/input/linux-event-codes.h>
>> + i2c@7e205000 {
> I thought the general trend for i2c devices was to leave the i2c
> part 'vague'.
>
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> pmic@4b.. etc
I agree with you and initial patch was as like above, but Lee was
somehow unhappy and not satisfied with
my explanations. Please find more info on v4.
> Guess it doesn't matter if example contains too much information. Rob?
>
> Otherwise looks good to me.
>
> Thanks,
>
> Jonathan
>
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0x7e205000 0x200>;
>> +
>> + pmic@4b {
>> + compatible = "mps,mp2629";
>> + reg = <0x4b>;
>> +
>> + interrupt-controller;
>> + interrupt-parent = <&gpio2>;
>> + #interrupt-cells = <2>;
>> + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> + };
next prev parent reply other threads:[~2020-04-18 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 8:49 [PATCH v10 0/6] Add battery charger driver support for MP2629 Saravanan Sekar
2020-04-17 8:49 ` [PATCH v10 1/6] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-04-18 14:53 ` Jonathan Cameron
2020-04-18 15:01 ` saravanan sekar [this message]
2020-04-18 16:06 ` Jonathan Cameron
2020-04-20 7:19 ` Lee Jones
2020-04-29 21:42 ` Rob Herring
2020-04-17 8:49 ` [PATCH v10 2/6] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-04-18 14:50 ` Jonathan Cameron
2020-04-17 8:50 ` [PATCH v10 3/6] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-04-17 14:35 ` Randy Dunlap
2020-04-17 14:51 ` saravanan sekar
2020-04-17 15:14 ` Randy Dunlap
2020-04-18 14:48 ` Jonathan Cameron
2020-04-17 8:50 ` [PATCH v10 4/6] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-04-26 20:02 ` Sebastian Reichel
2020-04-17 8:50 ` [PATCH v10 5/6] power: supply: mp2629: Add impedance compensation config Saravanan Sekar
2020-04-17 8:50 ` [PATCH v10 6/6] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ffb42e-4080-415e-dd3d-e38f7b0a6071@gmail.com \
--to=sravanhome@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.