From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board/common: Add support for QIXIS read/write using i2c
Date: Thu, 24 Jan 2013 08:58:24 +0530 [thread overview]
Message-ID: <5100AA58.9090500@freescale.com> (raw)
In-Reply-To: <CAKWjMd4CCBmC+prdp4O9SQV6x3kHONrW=LNkyZOe7jGO5Q_npw@mail.gmail.com>
On 01/24/2013 03:36 AM, Andy Fleming wrote:
>
>
> +u8 qixis_read_i2c(unsigned int reg)
> +{
> + return i2c_reg_read(CONFIG_SYS_I2C_FPGA_ADDR, reg);
> +}
> +
> +void qixis_write_i2c(unsigned int reg, u8 value)
> +{
> + u8 val = value;
> + i2c_reg_write(CONFIG_SYS_I2C_FPGA_ADDR, reg, val);
> +}
> +
>
>
>
> This breaks ALL other boards with QIXIS, as they don't all define
> CONFIG_SYS_I2C_FPGA_ADDR.
oh..
Then, I will put this code under #ifdef CONFIG_SYS_I2C_FPGA_ADDR and
provide v2 version of this patch.
Regards,
Prabhakar
prev parent reply other threads:[~2013-01-24 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 4:26 [U-Boot] [PATCH] board/common: Add support for QIXIS read/write using i2c Prabhakar Kushwaha
2013-01-23 22:06 ` Andy Fleming
2013-01-24 3:28 ` Prabhakar Kushwaha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100AA58.9090500@freescale.com \
--to=prabhakar@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.