From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754353Ab3AYCqv (ORCPT ); Thu, 24 Jan 2013 21:46:51 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:58932 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755572Ab3AYCqm (ORCPT ); Thu, 24 Jan 2013 21:46:42 -0500 Message-ID: <5101F207.6040603@linux.vnet.ibm.com> Date: Fri, 25 Jan 2013 10:46:31 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Marcelo Tosatti CC: Avi Kivity , Gleb Natapov , LKML , KVM Subject: Re: [PATCH v2 06/12] KVM: MMU: introduce a static table to map guest access to spte access References: <50FFB5A1.5090708@linux.vnet.ibm.com> <50FFB658.6040205@linux.vnet.ibm.com> <20130125001550.GB22875@amt.cnet> In-Reply-To: <20130125001550.GB22875@amt.cnet> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13012502-1618-0000-0000-0000033E5C5B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2013 08:15 AM, Marcelo Tosatti wrote: > On Wed, Jan 23, 2013 at 06:07:20PM +0800, Xiao Guangrong wrote: >> It makes set_spte more clean and reduces branch prediction >> >> Signed-off-by: Xiao Guangrong >> --- >> arch/x86/kvm/mmu.c | 37 ++++++++++++++++++++++++++----------- >> 1 files changed, 26 insertions(+), 11 deletions(-) > > Don't see set_spte as being a performance problem? > IMO the current code is quite simple. Yes, this is not a performance problem. I just dislike this many continuous "if"-s in the function: if (xxx) xxx if (xxx) xxx .... Totally, it has 7 "if"-s before this patch. Okay, if you think this is unnecessary, i will drop this patch. :)