All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Zykov <ilya@ilyx.ru>
To: Karthik Manamcheri <Karthik.Manamcheri@ni.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew McGregor <andrew.mcgregor@alliedtelesis.co.nz>
Subject: Re: [PATCH] n_tty: Unthrottle tty when flushing read buffer
Date: Tue, 29 Jan 2013 02:17:26 +0400	[thread overview]
Message-ID: <5106F8F6.80101@ilyx.ru> (raw)
In-Reply-To: <1358980578-8811-1-git-send-email-Karthik.Manamcheri@ni.com>

On 24.01.2013 2:36, Karthik Manamcheri wrote:
> When the tty input buffer is full and thereby throttled,
> flushing/resetting the read buffer should unthrottle to allow more
> data to be received.
> 
> Signed-off-by: Karthik Manamcheri <Karthik.Manamcheri@ni.com>
> ---
>  drivers/tty/n_tty.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 19083efa2314660b25e0fb5bc793af6fb7e9af57..d5cea3bb01eaeec61b577de6c58a8000412c0c37 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -229,6 +229,8 @@ static void reset_buffer_flags(struct tty_struct *tty)
>  	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
>  	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
>  	n_tty_set_room(tty);
> +
> +	check_unthrottle(tty);
>  }
>  
>  /**
> 

It's revert - tty: fix "IRQ45: nobody cared".
commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304

Please, read these for this subject:
https://lkml.org/lkml/2012/11/27/440
https://lkml.org/lkml/2012/11/21/568

https://lkml.org/lkml/2012/11/22/686

It's already fixed in the:
commit a1bf9584429d61b7096f93ae09325e1ba538e9e8
tty: Add driver unthrottle in ioctl(...,TCFLSH,..).


  parent reply	other threads:[~2013-01-28 22:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 22:36 [PATCH] n_tty: Unthrottle tty when flushing read buffer Karthik Manamcheri
2013-01-28 21:38 ` Peter Hurley
2013-01-28 22:17 ` Ilya Zykov [this message]
2013-01-30  4:36   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5106F8F6.80101@ilyx.ru \
    --to=ilya@ilyx.ru \
    --cc=Karthik.Manamcheri@ni.com \
    --cc=andrew.mcgregor@alliedtelesis.co.nz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.