All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: JBottomley@parallels.com
Cc: David Miller <davem@davemloft.net>,
	kxie@chelsio.com, michaelc@cs.wisc.edu,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.
Date: Tue, 29 Jan 2013 15:35:15 +0800	[thread overview]
Message-ID: <51077BB3.2010809@asianux.com> (raw)
In-Reply-To: <50FB9A33.2090204@asianux.com>

Hello JBottomley@parallels.com

  have you already fixed it by another patches ?

  if so:
    better to let me know about it, so I should not bother you, again.
  else
    please give a glance to this patch, when you have time
     (since compiling errors are always belong to critical errors)

  thanks.


by the way:
   I get the sending mail address from ./script/get_maintainer.pl.
   if I sent to an incorrect member, please tell me.

  thanks.

gchen.


于 2013年01月20日 15:18, Chen Gang 写道:
> Hello JBottomley@parallels.com
> 
>   when you have free time, could you give a glance for this patch ?
> 
>   thanks.
> 
> gchen.
> 
> 
> 于 2013年01月12日 20:42, Chen Gang 写道:
>>
>>   correct the include path,
>>   or the compiler will report can not find "common.h"...
>>
>>   both cxgb3/ and cxgb4/ sub directly have l2t.h (they are different).
>>   so it is not suitable to '-I' sub-directy, directly.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>>  drivers/scsi/cxgbi/Makefile        |    4 ++++
>>  drivers/scsi/cxgbi/cxgb3i/cxgb3i.c |   14 +++++++-------
>>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |   10 +++++-----
>>  3 files changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/scsi/cxgbi/Makefile b/drivers/scsi/cxgbi/Makefile
>> index 86007e3..aff2998 100644
>> --- a/drivers/scsi/cxgbi/Makefile
>> +++ b/drivers/scsi/cxgbi/Makefile
>> @@ -1,2 +1,6 @@
>> +
>> +ccflags-y			:= -Idrivers/net/ethernet/chelsio
>> +subdir-ccflags-y		:= -Idrivers/net/ethernet/chelsio
>> +
>>  obj-$(CONFIG_SCSI_CXGB3_ISCSI)	+= libcxgbi.o cxgb3i/
>>  obj-$(CONFIG_SCSI_CXGB4_ISCSI)	+= libcxgbi.o cxgb4i/
>> diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>> index 49692a1..ca92e72 100644
>> --- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>> +++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>> @@ -18,13 +18,13 @@
>>  #include <linux/moduleparam.h>
>>  #include <scsi/scsi_host.h>
>>  
>> -#include "common.h"
>> -#include "t3_cpl.h"
>> -#include "t3cdev.h"
>> -#include "cxgb3_defs.h"
>> -#include "cxgb3_ctl_defs.h"
>> -#include "cxgb3_offload.h"
>> -#include "firmware_exports.h"
>> +#include "cxgb3/common.h"
>> +#include "cxgb3/t3_cpl.h"
>> +#include "cxgb3/t3cdev.h"
>> +#include "cxgb3/cxgb3_defs.h"
>> +#include "cxgb3/cxgb3_ctl_defs.h"
>> +#include "cxgb3/cxgb3_offload.h"
>> +#include "cxgb3/firmware_exports.h"
>>  #include "cxgb3i.h"
>>  
>>  static unsigned int dbg_level;
>> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>> index f924b3c..a5795d5 100644
>> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>> @@ -20,11 +20,11 @@
>>  #include <net/dst.h>
>>  #include <linux/netdevice.h>
>>  
>> -#include "t4_msg.h"
>> -#include "cxgb4.h"
>> -#include "cxgb4_uld.h"
>> -#include "t4fw_api.h"
>> -#include "l2t.h"
>> +#include "cxgb4/t4_msg.h"
>> +#include "cxgb4/cxgb4.h"
>> +#include "cxgb4/cxgb4_uld.h"
>> +#include "cxgb4/t4fw_api.h"
>> +#include "cxgb4/l2t.h"
>>  #include "cxgb4i.h"
>>  
>>  static unsigned int dbg_level;
>>
> 
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-01-29  7:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-12 12:42 [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling Chen Gang
2013-01-20  7:18 ` Chen Gang
2013-01-29  7:35   ` Chen Gang [this message]
2013-02-28  3:24     ` Chen Gang
2013-02-28  3:24       ` Chen Gang
2013-02-28  6:07       ` Chen Gang
2013-02-28  6:34         ` [PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild Chen Gang
2013-04-07  3:17           ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51077BB3.2010809@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=JBottomley@parallels.com \
    --cc=davem@davemloft.net \
    --cc=kxie@chelsio.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.