From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/2] ASoC: clock gating is decided by bool on snd_soc_of_parse_daifmt() Date: Wed, 30 Jan 2013 09:39:30 -0700 Message-ID: <51094CC2.3000109@wwwdotorg.org> References: <87zk11487a.wl%kuninori.morimoto.gx@renesas.com> <87sj6t484z.wl%kuninori.morimoto.gx@renesas.com> <50E71618.8090302@wwwdotorg.org> <20130104193712.GN4627@opensource.wolfsonmicro.com> <87y5fvyy18.wl%kuninori.morimoto.gx@renesas.com> <87vcazyxr1.wl%kuninori.morimoto.gx@renesas.com> <20130127035943.GJ4650@opensource.wolfsonmicro.com> <87vcag3hcj.wl%kuninori.morimoto.gx@renesas.com> <20130129014808.GC4748@opensource.wolfsonmicro.com> <87sj5k3f83.wl%kuninori.morimoto.gx@renesas.com> <87obg8z4u4.wl%kuninori.morimoto.gx@renesas.com> <5107FF97.1070601@wwwdotorg.org> <87halz461n.wl%kuninori.morimoto.gx@renesas.com> <87ehh345zu.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org (avon.wwwdotorg.org [70.85.31.133]) by alsa0.perex.cz (Postfix) with ESMTP id 2BAF126507F for ; Wed, 30 Jan 2013 17:39:35 +0100 (CET) In-Reply-To: <87ehh345zu.wl%kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto Cc: Linux-ALSA , Mark Brown , Liam Girdwood , Kuninori Morimoto List-Id: alsa-devel@alsa-project.org On 01/29/2013 10:03 PM, Kuninori Morimoto wrote: > ASoC clock gate settings are continuous/gated only. > This patch decides it as bool, then, gated clock will be default. > Special thanks to Stephen > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > + snprintf(prop, sizeof(prop), "%scontinuous-clock", prefix); > + if (of_get_property(np, prop, NULL)) That should really use of_property_read_bool(), although it makes little practical difference.