From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init Date: Wed, 30 Jan 2013 10:49:54 -0700 Message-ID: <51095D42.1020701@wwwdotorg.org> References: <1358731326-2979-1-git-send-email-thomas.abraham@linaro.org> <50FD7904.1070201@wwwdotorg.org> <20130122110456.GC18876@e106331-lin.cambridge.arm.com> <20130130171930.GA23801@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130130171930.GA23801@e106331-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Rutland Cc: "swarren@nvidia.com" , "johnstul@us.ibm.com" , "devicetree-discuss@lists.ozlabs.org" , "rob.herring@calxeda.com" , Thomas Abraham , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 01/30/2013 10:19 AM, Mark Rutland wrote: > Thomas, > > On Tue, Jan 22, 2013 at 11:04:56AM +0000, Mark Rutland wrote: >> On Mon, Jan 21, 2013 at 06:30:47PM +0000, Thomas Abraham wrote: >>> Hi Stephen, >>> >>> On 21 January 2013 09:21, Stephen Warren wrote: >>>> On 01/20/2013 06:22 PM, Thomas Abraham wrote: >>>>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is >>>>> discoverable using call to clocksource_of_init. >>>> >>>>> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c >>>> >>>>> +#ifdef CONFIG_CLKSRC_OF >>>>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer", arch_timer_of_register) >>>>> +#endif >>>> >>>> I wonder if we shouldn't enhance include/linux/clocksource.h to define >>>> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers >>>> wouldn't need that ifdef. >>> >>> Yes, it will be helpful to have a !CONFIG_CLKSRC_OF version of >>> CLOCKSOURCE_OF_DECLARE. And can CONFIG_CLKSRC_OF be enabled by default >>> for all ARM platforms? >>> >>> Thanks, >>> Thomas. >> >> Thomas, >> >> Once the above is worked out, could you send me the updated patch with a >> pointer to whichever {branch,patch}(es) I need for CLKSRC_OF? > > Is there any news on this? I'd like to be able to push out a branch ready for > merging soon. I just sent a patch for this. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Wed, 30 Jan 2013 10:49:54 -0700 Subject: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init In-Reply-To: <20130130171930.GA23801@e106331-lin.cambridge.arm.com> References: <1358731326-2979-1-git-send-email-thomas.abraham@linaro.org> <50FD7904.1070201@wwwdotorg.org> <20130122110456.GC18876@e106331-lin.cambridge.arm.com> <20130130171930.GA23801@e106331-lin.cambridge.arm.com> Message-ID: <51095D42.1020701@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/30/2013 10:19 AM, Mark Rutland wrote: > Thomas, > > On Tue, Jan 22, 2013 at 11:04:56AM +0000, Mark Rutland wrote: >> On Mon, Jan 21, 2013 at 06:30:47PM +0000, Thomas Abraham wrote: >>> Hi Stephen, >>> >>> On 21 January 2013 09:21, Stephen Warren wrote: >>>> On 01/20/2013 06:22 PM, Thomas Abraham wrote: >>>>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is >>>>> discoverable using call to clocksource_of_init. >>>> >>>>> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c >>>> >>>>> +#ifdef CONFIG_CLKSRC_OF >>>>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer", arch_timer_of_register) >>>>> +#endif >>>> >>>> I wonder if we shouldn't enhance include/linux/clocksource.h to define >>>> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers >>>> wouldn't need that ifdef. >>> >>> Yes, it will be helpful to have a !CONFIG_CLKSRC_OF version of >>> CLOCKSOURCE_OF_DECLARE. And can CONFIG_CLKSRC_OF be enabled by default >>> for all ARM platforms? >>> >>> Thanks, >>> Thomas. >> >> Thomas, >> >> Once the above is worked out, could you send me the updated patch with a >> pointer to whichever {branch,patch}(es) I need for CLKSRC_OF? > > Is there any news on this? I'd like to be able to push out a branch ready for > merging soon. I just sent a patch for this.