From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
stable@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Amit Shah <amit.shah@redhat.com>,
sjur.brandeland@stericsson.com
Subject: Re: [PATCH] virtio_console: Don't access uninitialized data.
Date: Wed, 06 Feb 2013 10:14:59 +0800 [thread overview]
Message-ID: <5111BCA3.4040303__31340.1344269097$1360116983$gmane$org@cn.fujitsu.com> (raw)
In-Reply-To: <20130206014015.GB816@kroah.com>
On 02/06/2013 09:40 AM, Greg KH wrote:
> On Wed, Feb 06, 2013 at 10:38:36AM +1030, Rusty Russell wrote:
>> Amit Shah <amit.shah@redhat.com> writes:
>>> On (Mon) 04 Feb 2013 [10:09:05], Rusty Russell wrote:
>>>> Amit Shah <amit.shah@redhat.com> writes:
>>>>> On (Thu) 17 Jan 2013 [13:21:32], sjur.brandeland@stericsson.com wrote:
>>>>>> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
>>>>>>
>>>>>> Don't access uninitialized work-queue when removing device.
>>>>>> The work queue is initialized only if the device multi-queue.
>>>>>> So don't call cancel_work unless this is a multi-queue device.
>>>>>>
>>>>>> This fixes the following panic:
>>>>>
>>>>> [snip]
>>>>>
>>>>>> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
>>>>>
>>>>> Acked-by: Amit Shah <amit.shah@redhat.com>
>>>>>
>>>>>> This fix is intended of v3.8.
>>>>>
>>>>> Should also be CC'ed to stable@
>> ...
>>>> I've already sent it to Linus. Sjur said: "This fix is intended of
>>>> v3.8.". If it needs to be in -stable, please tell me and I'll fwd it
>>>> manually.
>>>
>>> This can result in a panic when removing the device or module (when
>>> not using multiport). I'd vote for submitting to stable.
>>>
>>> Amit
>>
>> OK stable, please cherry-pick from Linus' tree:
>>
>> commit b26ada9abe26290b1dcd06075935b977548c50db
>> Author: Sjur Brændeland <sjur.brandeland@stericsson.com>
>> Date: Tue Jan 22 09:50:26 2013 +1030
>>
>> virtio_console: Don't access uninitialized data.
>
> $ git show b26ada9abe26290b1dcd06075935b977548c50db
> fatal: bad object b26ada9abe26290b1dcd06075935b977548c50db
>
> What am I missing here?
It seems just in rusty's tree but not in linus' tree.
http://git.kernel.org/?p=linux/kernel/git/rusty/linux.git;a=commitdiff;h=b26ada9abe26290b1dcd06075935b977548c50db
Thanks,
Wanlong Gao
>
> greg k-h
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
>
next prev parent reply other threads:[~2013-02-06 2:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 12:21 [PATCH] virtio_console: Don't access uninitialized data sjur.brandeland
2013-01-21 23:20 ` Rusty Russell
2013-01-25 9:08 ` Amit Shah
2013-02-03 23:39 ` Rusty Russell
2013-02-04 6:32 ` Amit Shah
2013-02-06 0:08 ` Rusty Russell
[not found] ` <871ucul2wr.fsf@rustcorp.com.au>
2013-02-06 1:40 ` Greg KH
2013-02-06 2:14 ` Wanlong Gao [this message]
[not found] ` <5111BCA3.4040303@cn.fujitsu.com>
2013-02-06 2:22 ` Greg KH
2013-02-07 1:07 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5111BCA3.4040303__31340.1344269097$1360116983$gmane$org@cn.fujitsu.com' \
--to=gaowanlong@cn.fujitsu.com \
--cc=amit.shah@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=mst@redhat.com \
--cc=sjur.brandeland@stericsson.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.