From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 1/2] AMD IOMMU: also spot missing IO-APIC
 entries in IVRS table
Date: Wed, 06 Feb 2013 09:41:39 -0500
Message-ID: <51126BA3.9020307@oracle.com>
References: <511262E302000078000BC738@nat28.tlf.novell.com>
	<511264B402000078000BC754@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <511264B402000078000BC754@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Sherry Hurwitz <sherry.hurwitz@amd.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 2/6/2013 8:12 AM, Jan Beulich wrote:

>
> +    /* Each IO-APIC must have been mentioned in the table. */
> +    for ( apic = 0; !error&&  apic<  nr_ioapics; ++apic )
> +    {
> +        if ( !nr_ioapic_entries[apic] ||
> +             ioapic_sbdf[IO_APIC_ID(apic)].pin_setup )
> +            continue;
> +
> +        printk(XENLOG_ERR "IVHD Error: no information for IO-APIC %#x\n",
> +               IO_APIC_ID(apic));
> +        if ( amd_iommu_perdev_intremap )
> +            error = -ENXIO;
> +        else
> +        {
> +            ioapic_sbdf[IO_APIC_ID(apic)].pin_setup = xzalloc_array(
> +                unsigned long, BITS_TO_LONGS(nr_ioapic_entries[apic]));
> +            if ( !ioapic_sbdf[IO_APIC_ID(apic)].pin_setup )
> +            {
> +                printk(XENLOG_ERR "IVHD Error: Out of memory\n");
> +                error = -ENOMEM;
> +            }
> +        }
> +    }
> +
>       return error;
>   }
>

Don't we end up with ioapic_sbdf[IO_APIC_ID(apic)].bdf/seg being 
uninitialized? They are usually set in parse_ivhd_device_special(), at 
the same time pin_setup is allocated, but with IVRS broken in this way 
we'll never get there, will we?

-boris