All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ángel González" <ingenit@zoho.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org, kerolasa@iki.fi
Subject: Re: [PATCH 1/3] a pointer should not be compared to zero [coccinelle]
Date: Wed, 06 Feb 2013 18:47:15 +0100	[thread overview]
Message-ID: <51129723.3010102@zoho.com> (raw)
In-Reply-To: <20130206110006.GD24476@x2.net.home>

On 06/02/13 12:01, Karel Zak wrote:
> On Sat, Feb 02, 2013 at 11:58:05PM +0100, Ángel González wrote:
>> On 30/01/13 21:33, Sami Kerola wrote "a pointer should not be compared
>> to zero":
>>> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> 
>  Applied, thanks.
> 
>> Why not? It is perfectly legal.
>> See http://www.c-faq.com/null/null2.html
> 
>  It's usually legal from compiler or C standard point of view, but
>  it's horrible coding style manner.

I agree it's nicer, but if it's just for coding style I would have
expected a commit message about that, not "should not be compared".


>  For example:
>     http://lwn.net/Articles/93574/

Funny Linus remarks :)

      reply	other threads:[~2013-02-06 17:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 20:33 [PATCH 1/3] a pointer should not be compared to zero [coccinelle] Sami Kerola
2013-01-30 20:33 ` [PATCH 2/3] translation: unify exec error messages Sami Kerola
2013-02-06 10:53   ` Karel Zak
2013-01-30 20:33 ` [PATCH 3/3] eject: remove a duplicate command name from error message Sami Kerola
2013-02-02 23:00   ` Ángel González
2013-02-06 10:53   ` Karel Zak
2013-02-02 22:58 ` [PATCH 1/3] a pointer should not be compared to zero [coccinelle] Ángel González
2013-02-06 11:01   ` Karel Zak
2013-02-06 17:47     ` Ángel González [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51129723.3010102@zoho.com \
    --to=ingenit@zoho.com \
    --cc=kerolasa@iki.fi \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.