[PATCH] iio: mxs-lradc: Fix 'duplicate const' warning

[PATCH] iio: mxs-lradc: Fix 'duplicate const' warning

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

The following warning is generated by sparse:

drivers/staging/iio/adc/mxs-lradc.c:118:47: warning: duplicate const 

Remove the duplicate const.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/staging/iio/adc/mxs-lradc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index 33a2747..55a459b 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -115,7 +115,7 @@ struct mxs_lradc_of_config {
 	const char * const	*irq_name;
 };
 
-static const struct mxs_lradc_of_config const mxs_lradc_of_config[] = {
+static const struct mxs_lradc_of_config mxs_lradc_of_config[] = {
 	[IMX23_LRADC] = {
 		.irq_count	= ARRAY_SIZE(mx23_lradc_irq_names),
 		.irq_name	= mx23_lradc_irq_names,
-- 
1.7.9.5

Re: [PATCH] iio: mxs-lradc: Fix 'duplicate const' warning

[Marek Vasut]

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The following warning is generated by sparse:
> 
> drivers/staging/iio/adc/mxs-lradc.c:118:47: warning: duplicate const
> 
> Remove the duplicate const.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/staging/iio/adc/mxs-lradc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> b/drivers/staging/iio/adc/mxs-lradc.c index 33a2747..55a459b 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -115,7 +115,7 @@ struct mxs_lradc_of_config {
>  	const char * const	*irq_name;
>  };
> 
> -static const struct mxs_lradc_of_config const mxs_lradc_of_config[] = {
> +static const struct mxs_lradc_of_config mxs_lradc_of_config[] = {
>  	[IMX23_LRADC] = {
>  		.irq_count	= ARRAY_SIZE(mx23_lradc_irq_names),
>  		.irq_name	= mx23_lradc_irq_names,

Isn't it const variable/array const array elements ... thus correct with the two 
consts ?

Best regards,
Marek Vasut

Re: [PATCH] iio: mxs-lradc: Fix 'duplicate const' warning

[Jonathan Cameron]

On 02/06/2013 02:59 AM, Marek Vasut wrote:
> Dear Fabio Estevam,
> 
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> The following warning is generated by sparse:
>>
>> drivers/staging/iio/adc/mxs-lradc.c:118:47: warning: duplicate const
>>
>> Remove the duplicate const.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>>  drivers/staging/iio/adc/mxs-lradc.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>> b/drivers/staging/iio/adc/mxs-lradc.c index 33a2747..55a459b 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -115,7 +115,7 @@ struct mxs_lradc_of_config {
>>  	const char * const	*irq_name;
>>  };
>>
>> -static const struct mxs_lradc_of_config const mxs_lradc_of_config[] = {
>> +static const struct mxs_lradc_of_config mxs_lradc_of_config[] = {
>>  	[IMX23_LRADC] = {
>>  		.irq_count	= ARRAY_SIZE(mx23_lradc_irq_names),
>>  		.irq_name	= mx23_lradc_irq_names,
> 
> Isn't it const variable/array const array elements ... thus correct with the two 
> consts ?

Sadly not.   c99 c.7.3.8 (first sentence)
or c11 c.7.3.9

If the specification of an array type includes any type qualifiers, the element type is so-
qualified, not the array type.

I think that covers it though I'll admit I'm never that good at following
these specs and got the reference from googling.


Jonathan

Re: [PATCH] iio: mxs-lradc: Fix 'duplicate const' warning

[Jonathan Cameron]

On 02/06/2013 06:37 PM, Jonathan Cameron wrote:
> On 02/06/2013 02:59 AM, Marek Vasut wrote:
>> Dear Fabio Estevam,
>>
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> The following warning is generated by sparse:
>>>
>>> drivers/staging/iio/adc/mxs-lradc.c:118:47: warning: duplicate const
>>>
>>> Remove the duplicate const.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

applied to togreg branch of iio.git. Thanks,

Jonathan
>>> ---
>>>  drivers/staging/iio/adc/mxs-lradc.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>>> b/drivers/staging/iio/adc/mxs-lradc.c index 33a2747..55a459b 100644
>>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>>> @@ -115,7 +115,7 @@ struct mxs_lradc_of_config {
>>>  	const char * const	*irq_name;
>>>  };
>>>
>>> -static const struct mxs_lradc_of_config const mxs_lradc_of_config[] = {
>>> +static const struct mxs_lradc_of_config mxs_lradc_of_config[] = {
>>>  	[IMX23_LRADC] = {
>>>  		.irq_count	= ARRAY_SIZE(mx23_lradc_irq_names),
>>>  		.irq_name	= mx23_lradc_irq_names,
>>
>> Isn't it const variable/array const array elements ... thus correct with the two 
>> consts ?
> 
> Sadly not.   c99 c.7.3.8 (first sentence)
> or c11 c.7.3.9
> 
> If the specification of an array type includes any type qualifiers, the element type is so-
> qualified, not the array type.
> 
> I think that covers it though I'll admit I'm never that good at following
> these specs and got the reference from googling.
> 
> 
> Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>