All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <tushar.behera@linaro.org>
To: Manish Badarkhe <badarkhe.manish@gmail.com>
Cc: "Kumar, Anil" <anilkumar.v@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
	"patches@linaro.org" <patches@linaro.org>
Subject: Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Date: Thu, 07 Feb 2013 12:26:29 +0530	[thread overview]
Message-ID: <5113501D.5060603@linaro.org> (raw)
In-Reply-To: <CAKDJKT5xE9WWOC0pM8h1UWrF=OOtSr1D2WKPww9F6bhcO7VM_w@mail.gmail.com>

On 02/07/2013 12:06 PM, Manish Badarkhe wrote:
> Hi Tushar
> 
> On Thu, Feb 7, 2013 at 11:56 AM, Tushar Behera <tushar.behera@linaro.org> wrote:
>> On 02/07/2013 11:47 AM, Kumar, Anil wrote:
>>> On Thu, Feb 07, 2013 at 10:45:25, Tushar Behera wrote:
>>>> Added GPIO buttons DT node to Arndale board file.
>>>>
>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> ---
>>>> This series is based on for-next branch of Kukjin Kim's tree
>>>> and added on top of the below patch:
>>>> https://patchwork.kernel.org/patch/2042451/
>>>> ---
>>>>  arch/arm/boot/dts/exynos5250-arndale.dts |   48 ++++++++++++++++++++++++++++++
>>>>  1 files changed, 48 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
>>>> index 63572f9..9ce40df 100644
>>>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>>>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>>>> @@ -119,4 +119,52 @@
>>>>      spi_2: spi@12d40000 {
>>>>              status = "disabled";
>>>>      };
>>>> +
>>>> +    gpio_keys {
>>>> +            compatible = "gpio-keys";
>>>> +            #address-cells = <1>;
>>>> +            #size-cells = <0>;
>>>
>>> Just want to understand why these properties are here?
>>> As these properties are for child dt node. But have not seen
>>> anyone is using here.
>>>
>>
>> That is how gpio_keys node entries are defined in other .dts files.
> 
> I have gone through example for address-cells and size-cells in following link:
> http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing
> 
> which indicates that these fields are for child "reg".
> I think, here in child node there is no "reg". so there is no use
> of address-cells and size-cells propeties.
> 

Please check Documentation/devicetree/bindings/gpio/gpio_keys.txt

And whether these properties are required or not, I will let device tree
experts to comment on that.

As such, currently all node entries for gpio_keys use these properties.

-- 
Tushar Behera

WARNING: multiple messages have this Message-ID
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Date: Thu, 07 Feb 2013 12:26:29 +0530	[thread overview]
Message-ID: <5113501D.5060603@linaro.org> (raw)
In-Reply-To: <CAKDJKT5xE9WWOC0pM8h1UWrF=OOtSr1D2WKPww9F6bhcO7VM_w@mail.gmail.com>

On 02/07/2013 12:06 PM, Manish Badarkhe wrote:
> Hi Tushar
> 
> On Thu, Feb 7, 2013 at 11:56 AM, Tushar Behera <tushar.behera@linaro.org> wrote:
>> On 02/07/2013 11:47 AM, Kumar, Anil wrote:
>>> On Thu, Feb 07, 2013 at 10:45:25, Tushar Behera wrote:
>>>> Added GPIO buttons DT node to Arndale board file.
>>>>
>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> ---
>>>> This series is based on for-next branch of Kukjin Kim's tree
>>>> and added on top of the below patch:
>>>> https://patchwork.kernel.org/patch/2042451/
>>>> ---
>>>>  arch/arm/boot/dts/exynos5250-arndale.dts |   48 ++++++++++++++++++++++++++++++
>>>>  1 files changed, 48 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
>>>> index 63572f9..9ce40df 100644
>>>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>>>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>>>> @@ -119,4 +119,52 @@
>>>>      spi_2: spi at 12d40000 {
>>>>              status = "disabled";
>>>>      };
>>>> +
>>>> +    gpio_keys {
>>>> +            compatible = "gpio-keys";
>>>> +            #address-cells = <1>;
>>>> +            #size-cells = <0>;
>>>
>>> Just want to understand why these properties are here?
>>> As these properties are for child dt node. But have not seen
>>> anyone is using here.
>>>
>>
>> That is how gpio_keys node entries are defined in other .dts files.
> 
> I have gone through example for address-cells and size-cells in following link:
> http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing
> 
> which indicates that these fields are for child "reg".
> I think, here in child node there is no "reg". so there is no use
> of address-cells and size-cells propeties.
> 

Please check Documentation/devicetree/bindings/gpio/gpio_keys.txt

And whether these properties are required or not, I will let device tree
experts to comment on that.

As such, currently all node entries for gpio_keys use these properties.

-- 
Tushar Behera

  reply	other threads:[~2013-02-07  6:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07  5:15 Tushar Behera
2013-02-07  5:15 ` Tushar Behera
2013-02-07  5:15 ` [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  5:49   ` Kumar, Anil
2013-02-07  5:49     ` Kumar, Anil
2013-02-07  5:56     ` Tushar Behera
2013-02-07  5:56       ` Tushar Behera
2013-02-11  0:38       ` amit daniel kachhap
2013-02-11  0:38         ` amit daniel kachhap
2013-03-11  2:05         ` Kukjin Kim
2013-03-11  2:05           ` Kukjin Kim
2013-02-07  5:15 ` [PATCH 3/5] ARM: dts: exynos5250-arndale: Add vmmc regulator support Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  5:15 ` [PATCH 4/5] ARM: dts: exynos5250-arndale: Add MFC codec support Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  5:15 ` [PATCH 5/5] ARM: dts: exynos5250-arndale: Add HDMI HPD and regulator node Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  6:17 ` [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons Kumar, Anil
2013-02-07  6:17   ` Kumar, Anil
2013-02-07  6:26   ` Tushar Behera
2013-02-07  6:26     ` Tushar Behera
2013-02-07  6:36     ` Manish Badarkhe
2013-02-07  6:36       ` Manish Badarkhe
2013-02-07  6:56       ` Tushar Behera [this message]
2013-02-07  6:56         ` Tushar Behera
2013-02-07  7:43         ` Girish KS
2013-02-07  7:43           ` Girish KS
2013-02-07  9:40           ` Tushar Behera
2013-02-07  9:40             ` Tushar Behera
2013-02-07 11:25             ` Tomasz Figa
2013-02-07 11:25               ` Tomasz Figa
2013-02-07 10:30 ` Tomasz Figa
2013-02-07 10:30   ` Tomasz Figa
2013-03-11  2:05   ` Kukjin Kim
2013-03-11  2:05     ` Kukjin Kim
2013-03-11  9:44     ` Tushar Behera
2013-03-11  9:44       ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5113501D.5060603@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=anilkumar.v@ti.com \
    --cc=badarkhe.manish@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --subject='Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.