All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <tushar.behera@linaro.org>
To: Girish KS <girishks2000@gmail.com>
Cc: Manish Badarkhe <badarkhe.manish@gmail.com>,
	"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
	"patches@linaro.org" <patches@linaro.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"Kumar, Anil" <anilkumar.v@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	david@protonic.nl, dtor@mail.ru
Subject: Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Date: Thu, 07 Feb 2013 15:10:27 +0530	[thread overview]
Message-ID: <5113768B.90102@linaro.org> (raw)
In-Reply-To: <CAKrE-Ke1WZt-PqVReGdNwcD+R_-4iHKPhgkgtgS-LQAPbx34mQ@mail.gmail.com>

+CC: David Jander <david@protonic.nl>
+CC: Dmitry Torokhov <dtor@mail.ru>

On 02/07/2013 01:13 PM, Girish KS wrote:
>>>>>> +
>>>>>> +    gpio_keys {
>>>>>> +            compatible = "gpio-keys";
>>>>>> +            #address-cells = <1>;
>>>>>> +            #size-cells = <0>;
>>>>>
>>>>> Just want to understand why these properties are here?
>>>>> As these properties are for child dt node. But have not seen
>>>>> anyone is using here.
>>>>>
>>>>
>>>> That is how gpio_keys node entries are defined in other .dts files.
>>>
>>> I have gone through example for address-cells and size-cells in following link:
>>> http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing
>>>
>>> which indicates that these fields are for child "reg".
>>> I think, here in child node there is no "reg". so there is no use
>>> of address-cells and size-cells propeties.
>>>
>>
>> Please check Documentation/devicetree/bindings/gpio/gpio_keys.txt
>>
>> And whether these properties are required or not, I will let device tree
>> experts to comment on that.
>>
>> As such, currently all node entries for gpio_keys use these properties.
> you can just verify by a simple test.
> delete the 2 lines. address-cells and size cells.
> this will have no affect.
> now with these 2 lines deleted lines add a dummy reg property with
> address and cell. dtb compiler will warn.
> So I think what manish reffered is right.
> There is also a reference of smdk4210 for kepads.

Right. Compilation is ok even after removing the address-cell and
size-cell properties.

But since this is used across all the instances, I would like to know
the view of the authors on this.

David, Dimitry,

Can you please let us know your opinion on this? If these properties are
not required, then we can remove them from the documentation and from
node entries in several other dts files.

>>
>> --
>> Tushar Behera
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Tushar Behera

WARNING: multiple messages have this Message-ID
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Date: Thu, 07 Feb 2013 15:10:27 +0530	[thread overview]
Message-ID: <5113768B.90102@linaro.org> (raw)
In-Reply-To: <CAKrE-Ke1WZt-PqVReGdNwcD+R_-4iHKPhgkgtgS-LQAPbx34mQ@mail.gmail.com>

+CC: David Jander <david@protonic.nl>
+CC: Dmitry Torokhov <dtor@mail.ru>

On 02/07/2013 01:13 PM, Girish KS wrote:
>>>>>> +
>>>>>> +    gpio_keys {
>>>>>> +            compatible = "gpio-keys";
>>>>>> +            #address-cells = <1>;
>>>>>> +            #size-cells = <0>;
>>>>>
>>>>> Just want to understand why these properties are here?
>>>>> As these properties are for child dt node. But have not seen
>>>>> anyone is using here.
>>>>>
>>>>
>>>> That is how gpio_keys node entries are defined in other .dts files.
>>>
>>> I have gone through example for address-cells and size-cells in following link:
>>> http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing
>>>
>>> which indicates that these fields are for child "reg".
>>> I think, here in child node there is no "reg". so there is no use
>>> of address-cells and size-cells propeties.
>>>
>>
>> Please check Documentation/devicetree/bindings/gpio/gpio_keys.txt
>>
>> And whether these properties are required or not, I will let device tree
>> experts to comment on that.
>>
>> As such, currently all node entries for gpio_keys use these properties.
> you can just verify by a simple test.
> delete the 2 lines. address-cells and size cells.
> this will have no affect.
> now with these 2 lines deleted lines add a dummy reg property with
> address and cell. dtb compiler will warn.
> So I think what manish reffered is right.
> There is also a reference of smdk4210 for kepads.

Right. Compilation is ok even after removing the address-cell and
size-cell properties.

But since this is used across all the instances, I would like to know
the view of the authors on this.

David, Dimitry,

Can you please let us know your opinion on this? If these properties are
not required, then we can remove them from the documentation and from
node entries in several other dts files.

>>
>> --
>> Tushar Behera
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Tushar Behera

  reply	other threads:[~2013-02-07  9:40 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07  5:15 Tushar Behera
2013-02-07  5:15 ` Tushar Behera
2013-02-07  5:15 ` [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  5:49   ` Kumar, Anil
2013-02-07  5:49     ` Kumar, Anil
2013-02-07  5:56     ` Tushar Behera
2013-02-07  5:56       ` Tushar Behera
2013-02-11  0:38       ` amit daniel kachhap
2013-02-11  0:38         ` amit daniel kachhap
2013-03-11  2:05         ` Kukjin Kim
2013-03-11  2:05           ` Kukjin Kim
2013-02-07  5:15 ` [PATCH 3/5] ARM: dts: exynos5250-arndale: Add vmmc regulator support Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  5:15 ` [PATCH 4/5] ARM: dts: exynos5250-arndale: Add MFC codec support Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  5:15 ` [PATCH 5/5] ARM: dts: exynos5250-arndale: Add HDMI HPD and regulator node Tushar Behera
2013-02-07  5:15   ` Tushar Behera
2013-02-07  6:17 ` [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons Kumar, Anil
2013-02-07  6:17   ` Kumar, Anil
2013-02-07  6:26   ` Tushar Behera
2013-02-07  6:26     ` Tushar Behera
2013-02-07  6:36     ` Manish Badarkhe
2013-02-07  6:36       ` Manish Badarkhe
2013-02-07  6:56       ` Tushar Behera
2013-02-07  6:56         ` Tushar Behera
2013-02-07  7:43         ` Girish KS
2013-02-07  7:43           ` Girish KS
2013-02-07  9:40           ` Tushar Behera [this message]
2013-02-07  9:40             ` Tushar Behera
2013-02-07 11:25             ` Tomasz Figa
2013-02-07 11:25               ` Tomasz Figa
2013-02-07 10:30 ` Tomasz Figa
2013-02-07 10:30   ` Tomasz Figa
2013-03-11  2:05   ` Kukjin Kim
2013-03-11  2:05     ` Kukjin Kim
2013-03-11  9:44     ` Tushar Behera
2013-03-11  9:44       ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5113768B.90102@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=anilkumar.v@ti.com \
    --cc=badarkhe.manish@gmail.com \
    --cc=david@protonic.nl \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dtor@mail.ru \
    --cc=girishks2000@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --subject='Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.