From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 2/4] cover: Adding support for coverage
	information
Date: Thu, 7 Feb 2013 11:59:39 +0000
Message-ID: <5113972B.3090802@eu.citrix.com>
References: <1360236482-25452-1-git-send-email-frediano.ziglio@citrix.com>
	<1360236482-25452-3-git-send-email-frediano.ziglio@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1360236482-25452-3-git-send-email-frediano.ziglio@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Frediano Ziglio <frediano.ziglio@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>, "Keir (Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 07/02/13 11:28, Frediano Ziglio wrote:
> diff --git a/xen/common/gcov/gcov.c b/xen/common/gcov/gcov.c
> new file mode 100644
> index 0000000..733d020
> --- /dev/null
> +++ b/xen/common/gcov/gcov.c
> @@ -0,0 +1,74 @@
> +/*
> + *  This code maintains a list of active profiling data structures.
> + *
> + *    Copyright IBM Corp. 2009
> + *    Author(s): Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> + *
> + *    Uses gcc-internal data definitions.
> + *    Based on the gcov-kernel patch by:
> + *       Hubertus Franke <frankeh@us.ibm.com>
> + *       Nigel Hinds <nhinds@us.ibm.com>
> + *       Rajan Ravindran <rajancr@us.ibm.com>
> + *       Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> + *       Paul Larson
> + */
> +
> +#include <xen/config.h>
> +#include <xen/init.h>
> +#include <xen/lib.h>
> +#include <xen/hypercall.h>
> +#include <xen/gcov.h>
> +#include <xen/errno.h>
> +
> +static struct gcov_info *info_list;
> +static unsigned num_info = 0;

This is a bit of a nit, but you seem to remove this variable in the next 
patch, which is bad form.  If it's not necessary, just don't add it in 
this patch.

> +
> +/*
> + * __gcov_init is called by gcc-generated constructor code for each object
> + * file compiled with -fprofile-arcs.
> + *
> + * Although this function is called only during initialization is called from
> + * a .text section which is still present after initialization so not declare
> + * as __init.
> + */
> +void __gcov_init(struct gcov_info *info)
> +{
> +    /* add new profiling data structure to list */
> +    info->next = info_list;
> +    info_list = info;
> +    ++num_info;

Ditto.

  -George