From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 2/3] qemu-xen-trad: Correctly expose PCH ISA bridge for IGD passthrough Date: Fri, 08 Feb 2013 07:51:58 +0000 Message-ID: <5114BCAE02000078000BD12D@nat28.tlf.novell.com> References: <1360253528-5424-1-git-send-email-firemeteor@users.sourceforge.net> <1360253528-5424-3-git-send-email-firemeteor@users.sourceforge.net> <5113E4C302000078000BCF6B@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: stefano.stabellini@citrix.com, "G.R." Cc: ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 07.02.13 at 18:43, "G.R." wrote: >> >> For one I wonder whether this is really _always_ correct. I.e. >> the device at 00:1f.0 always being an ISA bridge. Wouldn't it >> be better to mirror whatever the host device says? >> > From the Intel driver code, it's looking for an intel ISA bridge. That doesn't mean that it always will be. > So your question would be should it be always at 00:1f.0. > So far it seems that it is. Same thing here. We ought to be careful, or else we risk to introduce issues that pretty hard to locate, debug, and fix. Jan