From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v2 0/8] ARM: omap2: GPMC cleanup Date: Tue, 12 Feb 2013 10:32:33 -0600 Message-ID: <511A6EA1.80301@ti.com> References: <1360682305-20935-1-git-send-email-ezequiel.garcia@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:47128 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932330Ab3BLQcj (ORCPT ); Tue, 12 Feb 2013 11:32:39 -0500 In-Reply-To: <1360682305-20935-1-git-send-email-ezequiel.garcia@free-electrons.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ezequiel Garcia Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Tony Lindgren , Afzal Mohammed On 02/12/2013 09:18 AM, Ezequiel Garcia wrote: > This patchset is v2 of the small cleanup consisting in: > * mark some functions as 'static' when appropriate > * remove an unused function from gpmc.c > * improve error messages when a CS request fails > * migrate to dev_err and dev_warn > > Changelog from v1: > * fix gpmc_cs_reserved to return a boolean instead > of an integer error code > * add a new patch to the patchset cleaning redundant checks > > It has been tested on a IGEP v2 board with OneNAND, > which means the gpmc-nand patch is tested by compilation only. > > Altough these patchset is almost trivial, > any feedback or testing is more than welcome. > > Ezequiel Garcia (8): > ARM: omap2: gpmc: Mark local scoped functions static > ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function > ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value > ARM: omap2: gpmc-nand: Print something useful on CS request failure > ARM: omap2: gpmc-onenand: Print something useful on CS request failure > ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err() > ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn() > ARM: omap2: gpmc: Remove redundant chip select out of range check > > arch/arm/mach-omap2/gpmc-nand.c | 3 ++- > arch/arm/mach-omap2/gpmc-onenand.c | 8 +++++--- > arch/arm/mach-omap2/gpmc.c | 27 ++++++--------------------- > arch/arm/mach-omap2/gpmc.h | 7 ------- > 4 files changed, 13 insertions(+), 32 deletions(-) Looks good to me. I noticed that for some patches there is no changelog and I understand that that is because they are some what trivial clean-ups and the subject explains the patch. However, typically it is good to have a changelog in the patch no matter how trivial it is. Tony may ask you to add a changelog. Otherwise ... Reviewed-by: Jon Hunter Cheers Jon From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon-hunter@ti.com (Jon Hunter) Date: Tue, 12 Feb 2013 10:32:33 -0600 Subject: [PATCH v2 0/8] ARM: omap2: GPMC cleanup In-Reply-To: <1360682305-20935-1-git-send-email-ezequiel.garcia@free-electrons.com> References: <1360682305-20935-1-git-send-email-ezequiel.garcia@free-electrons.com> Message-ID: <511A6EA1.80301@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/12/2013 09:18 AM, Ezequiel Garcia wrote: > This patchset is v2 of the small cleanup consisting in: > * mark some functions as 'static' when appropriate > * remove an unused function from gpmc.c > * improve error messages when a CS request fails > * migrate to dev_err and dev_warn > > Changelog from v1: > * fix gpmc_cs_reserved to return a boolean instead > of an integer error code > * add a new patch to the patchset cleaning redundant checks > > It has been tested on a IGEP v2 board with OneNAND, > which means the gpmc-nand patch is tested by compilation only. > > Altough these patchset is almost trivial, > any feedback or testing is more than welcome. > > Ezequiel Garcia (8): > ARM: omap2: gpmc: Mark local scoped functions static > ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function > ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value > ARM: omap2: gpmc-nand: Print something useful on CS request failure > ARM: omap2: gpmc-onenand: Print something useful on CS request failure > ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err() > ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn() > ARM: omap2: gpmc: Remove redundant chip select out of range check > > arch/arm/mach-omap2/gpmc-nand.c | 3 ++- > arch/arm/mach-omap2/gpmc-onenand.c | 8 +++++--- > arch/arm/mach-omap2/gpmc.c | 27 ++++++--------------------- > arch/arm/mach-omap2/gpmc.h | 7 ------- > 4 files changed, 13 insertions(+), 32 deletions(-) Looks good to me. I noticed that for some patches there is no changelog and I understand that that is because they are some what trivial clean-ups and the subject explains the patch. However, typically it is good to have a changelog in the patch no matter how trivial it is. Tony may ask you to add a changelog. Otherwise ... Reviewed-by: Jon Hunter Cheers Jon