From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs Date: Thu, 14 Feb 2013 16:29:06 -0700 Message-ID: <511D7342.2070205@wwwdotorg.org> References: <1360868369-20093-1-git-send-email-hdoyu@nvidia.com><1360868369-20093-2-git-send-email-hdoyu@nvidia.com><511D45E0.1080105@wwwdotorg.org> <20130214.223422.1106350409475384652.hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130214.223422.1106350409475384652.hdoyu@nvidia.com> Sender: linux-doc-owner@vger.kernel.org To: Hiroshi Doyu Cc: "linux-tegra@vger.kernel.org" , "grant.likely@secretlab.ca" , "rob.herring@calxeda.com" , "rob@landley.net" , "linux@arm.linux.org.uk" , "sjg@chromium.org" , Prashant Gaikwad , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-tegra@vger.kernel.org On 02/14/2013 01:34 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Thu, 14 Feb 2013 21:15:28 +0100: > >> Oh, and I don't think you updated e.g. nvidia,tegra20-car.txt to remove >> the list of clocks. > > Not yet removed. I think that this could be done with the patch which > allows kernel source to include DT header files. By defining the header file, you're really causing that header to be part of the binding definition. I think we should move the code from the binding .txt file to the header, rather than duplicating it and then removing it. The kernel doesn't include the binding .txt file right now, so I don't see any correlation with making it include the header vs. when we remove the list from the binding document. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935115Ab3BNX3O (ORCPT ); Thu, 14 Feb 2013 18:29:14 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:58526 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935087Ab3BNX3M (ORCPT ); Thu, 14 Feb 2013 18:29:12 -0500 Message-ID: <511D7342.2070205@wwwdotorg.org> Date: Thu, 14 Feb 2013 16:29:06 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Hiroshi Doyu CC: "linux-tegra@vger.kernel.org" , "grant.likely@secretlab.ca" , "rob.herring@calxeda.com" , "rob@landley.net" , "linux@arm.linux.org.uk" , "sjg@chromium.org" , Prashant Gaikwad , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs References: <1360868369-20093-1-git-send-email-hdoyu@nvidia.com><1360868369-20093-2-git-send-email-hdoyu@nvidia.com><511D45E0.1080105@wwwdotorg.org> <20130214.223422.1106350409475384652.hdoyu@nvidia.com> In-Reply-To: <20130214.223422.1106350409475384652.hdoyu@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/2013 01:34 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Thu, 14 Feb 2013 21:15:28 +0100: > >> Oh, and I don't think you updated e.g. nvidia,tegra20-car.txt to remove >> the list of clocks. > > Not yet removed. I think that this could be done with the patch which > allows kernel source to include DT header files. By defining the header file, you're really causing that header to be part of the binding definition. I think we should move the code from the binding .txt file to the header, rather than duplicating it and then removing it. The kernel doesn't include the binding .txt file right now, so I don't see any correlation with making it include the header vs. when we remove the list from the binding document. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Thu, 14 Feb 2013 16:29:06 -0700 Subject: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs In-Reply-To: <20130214.223422.1106350409475384652.hdoyu@nvidia.com> References: <1360868369-20093-1-git-send-email-hdoyu@nvidia.com><1360868369-20093-2-git-send-email-hdoyu@nvidia.com><511D45E0.1080105@wwwdotorg.org> <20130214.223422.1106350409475384652.hdoyu@nvidia.com> Message-ID: <511D7342.2070205@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/14/2013 01:34 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Thu, 14 Feb 2013 21:15:28 +0100: > >> Oh, and I don't think you updated e.g. nvidia,tegra20-car.txt to remove >> the list of clocks. > > Not yet removed. I think that this could be done with the patch which > allows kernel source to include DT header files. By defining the header file, you're really causing that header to be part of the binding definition. I think we should move the code from the binding .txt file to the header, rather than duplicating it and then removing it. The kernel doesn't include the binding .txt file right now, so I don't see any correlation with making it include the header vs. when we remove the list from the binding document.