From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933362Ab3BSSTq (ORCPT ); Tue, 19 Feb 2013 13:19:46 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33628 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932858Ab3BSSTp (ORCPT ); Tue, 19 Feb 2013 13:19:45 -0500 Message-ID: <5123C217.3040609@oracle.com> Date: Tue, 19 Feb 2013 13:19:03 -0500 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: "H. Peter Anvin" , Ingo Molnar CC: Konrad Rzeszutek Wilk , Borislav Petkov , Linus Torvalds , linux-kernel@vger.kernel.org, Thomas Gleixner , Andrew Morton Subject: Re: [GIT PULL] x86/cpu changes for v3.9 References: <20130219152503.GA14862@gmail.com> <20130219153655.GD26748@pd.tnic> <20130219154721.GA15876@gmail.com> <5123B897.9010607@zytor.com> <20130219174758.GB4465@pd.tnic> <20130219175726.GA18244@phenom.dumpdata.com> In-Reply-To: <20130219175726.GA18244@phenom.dumpdata.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2013 12:57 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Feb 19, 2013 at 06:47:58PM +0100, Borislav Petkov wrote: >> On Tue, Feb 19, 2013 at 09:38:31AM -0800, H. Peter Anvin wrote: >>> My fault... I was tracking the fix and lost track of the thread. >>> >>> The problem is that the fix is necessary but not sufficient, as it >>> introduces an undesirable host-guest dependency. In order to allow >>> neerw guests to work on older hosts we also should use the >>> {rd,wr}msr_safe() functions to manipulate this MSR, with a comment >>> as to why. >>> >>> Boris, could you prepare such a patch, please? >> I don't think Boris O. is at AMD anymore. Want me to add that to my fix >> for kvm or prep a separate patch? > CC-ing Boris. BorisP's patch is what I should have done. Can you take it? -boris