From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753183Ab3BUKTf (ORCPT ); Thu, 21 Feb 2013 05:19:35 -0500 Received: from smtp-out-108.synserver.de ([212.40.185.108]:1114 "EHLO smtp-out-108.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011Ab3BUKTd (ORCPT ); Thu, 21 Feb 2013 05:19:33 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 15832 Message-ID: <5125F3D3.6040309@metafoo.de> Date: Thu, 21 Feb 2013 11:15:47 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Len Brown CC: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown , linux-ia64@vger.kernel.org Subject: Re: [PATCH 09/16] ia64 idle: delete pm_idle References: <1360475903-30007-1-git-send-email-lenb@kernel.org> <7dc2a692a27e9c3da86acf150c4a89024e48bd05.1360475150.git.len.brown@intel.com> In-Reply-To: <7dc2a692a27e9c3da86acf150c4a89024e48bd05.1360475150.git.len.brown@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2013 06:58 AM, Len Brown wrote: > From: Len Brown > > pm_idle() on ia64 was a synonym for default_idle(). > So simply invoke default_idle() directly. > > Signed-off-by: Len Brown > Cc: linux-ia64@vger.kernel.org > --- > arch/ia64/kernel/process.c | 3 --- > arch/ia64/kernel/setup.c | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c > index 31360cb..e34f565 100644 > --- a/arch/ia64/kernel/process.c > +++ b/arch/ia64/kernel/process.c > @@ -57,8 +57,6 @@ void (*ia64_mark_idle)(int); > > unsigned long boot_option_idle_override = IDLE_NO_OVERRIDE; > EXPORT_SYMBOL(boot_option_idle_override); > -void (*pm_idle) (void); > -EXPORT_SYMBOL(pm_idle); > void (*pm_power_off) (void); > EXPORT_SYMBOL(pm_power_off); > > @@ -301,7 +299,6 @@ cpu_idle (void) > if (mark_idle) > (*mark_idle)(1); > > - idle = pm_idle; > if (!idle) Hm, if I'm not mistaken idle will uninitialized at this point, so this could quite likely lead to a crash. > idle = default_idle; > (*idle)(); > diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c > index aaefd9b..2029cc0 100644 > --- a/arch/ia64/kernel/setup.c > +++ b/arch/ia64/kernel/setup.c > @@ -1051,7 +1051,6 @@ cpu_init (void) > max_num_phys_stacked = num_phys_stacked; > } > platform_cpu_init(); > - pm_idle = default_idle; > } > > void __init From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Date: Thu, 21 Feb 2013 10:15:47 +0000 Subject: Re: [PATCH 09/16] ia64 idle: delete pm_idle Message-Id: <5125F3D3.6040309@metafoo.de> List-Id: References: <1360475903-30007-1-git-send-email-lenb@kernel.org> <7dc2a692a27e9c3da86acf150c4a89024e48bd05.1360475150.git.len.brown@intel.com> In-Reply-To: <7dc2a692a27e9c3da86acf150c4a89024e48bd05.1360475150.git.len.brown@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Len Brown Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown , linux-ia64@vger.kernel.org On 02/10/2013 06:58 AM, Len Brown wrote: > From: Len Brown > > pm_idle() on ia64 was a synonym for default_idle(). > So simply invoke default_idle() directly. > > Signed-off-by: Len Brown > Cc: linux-ia64@vger.kernel.org > --- > arch/ia64/kernel/process.c | 3 --- > arch/ia64/kernel/setup.c | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c > index 31360cb..e34f565 100644 > --- a/arch/ia64/kernel/process.c > +++ b/arch/ia64/kernel/process.c > @@ -57,8 +57,6 @@ void (*ia64_mark_idle)(int); > > unsigned long boot_option_idle_override = IDLE_NO_OVERRIDE; > EXPORT_SYMBOL(boot_option_idle_override); > -void (*pm_idle) (void); > -EXPORT_SYMBOL(pm_idle); > void (*pm_power_off) (void); > EXPORT_SYMBOL(pm_power_off); > > @@ -301,7 +299,6 @@ cpu_idle (void) > if (mark_idle) > (*mark_idle)(1); > > - idle = pm_idle; > if (!idle) Hm, if I'm not mistaken idle will uninitialized at this point, so this could quite likely lead to a crash. > idle = default_idle; > (*idle)(); > diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c > index aaefd9b..2029cc0 100644 > --- a/arch/ia64/kernel/setup.c > +++ b/arch/ia64/kernel/setup.c > @@ -1051,7 +1051,6 @@ cpu_init (void) > max_num_phys_stacked = num_phys_stacked; > } > platform_cpu_init(); > - pm_idle = default_idle; > } > > void __init