From: Phileas Fogg <phileas-fogg@mail.ru>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: PS3: Strange issue with kexec and FreeBSD loader
Date: Fri, 22 Feb 2013 21:49:18 +0100 [thread overview]
Message-ID: <5127D9CE.2090500@mail.ru> (raw)
In-Reply-To: <1361490374.4676.58.camel@pasglop>
Benjamin Herrenschmidt wrote:
> On Thu, 2013-02-21 at 22:44 +0100, Phileas Fogg wrote:
>> Stripped OpenWRT image:
>> ------------------------
>>
>> c00000000001a474: 48 00 00 05 bl 0xc00000000001a478
>> c00000000001a478: 7c a8 02 a6 mflr r5
>> c00000000001a47c: 38 a5 00 1c addi r5,r5,28
>> c00000000001a480: 7c 21 0b 78 mr r1,r1
>> c00000000001a484: 80 85 00 00 lwz r4,0(r5)
>> c00000000001a488: 2c 04 00 00 cmpwi r4,0
>> c00000000001a48c: 40 82 00 62 bnea- 0x60
>> c00000000001a490: 4b ff ff f0 b 0xc00000000001a480
>> c00000000001a494: 00 00 00 00 .long 0x0
>> c00000000001a498: a0 6d 00 48 lhz r3,72(r13)
>> c00000000001a49c: 48 00 00 11 bl 0xc00000000001a4ac
>
>
> Smell like a bad stack pointer to me...
>
> One thing I noticed is that kexec doesn't seem to hard disable
> interrupts, which is ... fishy at best. It should do that
> before it switches stacks around. Dunno if that's the cause
> of the problem but it might be worth adding a hard_irq_disable()
> after all the local_irq_disable(), making sure we are hard
> disabled before going into asm.
>
> Cheers,
> Ben.
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
Hi,
i wanted to let you know that i tested your advice. And let me say, it's was a
damn good advice :) I can boot FreeBSD loader on Linux 3.8 now, no SHA256
checksum failures. And no panics with FreeBSD LiveCD anymore too.
I just inserted hard_irq_disable() after each local_irq_disable() in
arch/powerpc/kernel/machine_kexec_64.c
Thanks
regards
next prev parent reply other threads:[~2013-02-22 19:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 23:10 PS3: Strange issue with kexec and FreeBSD loader Phileas Fogg
2013-02-16 10:53 ` Phileas Fogg
2013-02-16 22:14 ` Phileas Fogg
2013-02-16 23:12 ` Phileas Fogg
2013-02-17 8:53 ` Geert Uytterhoeven
2013-02-17 12:40 ` Phileas Fogg
2013-02-21 0:14 ` Geoff Levand
2013-02-16 18:51 ` Phileas Fogg
2013-02-19 18:40 ` Phileas Fogg
2013-02-19 19:54 ` Phileas Fogg
2013-02-20 20:43 ` Phileas Fogg
2013-02-21 0:32 ` Benjamin Herrenschmidt
2013-02-21 20:38 ` Phileas Fogg
2013-02-21 20:35 ` Benjamin Herrenschmidt
2013-02-21 21:44 ` Phileas Fogg
2013-02-21 23:46 ` Benjamin Herrenschmidt
2013-02-22 20:49 ` Phileas Fogg [this message]
2013-02-22 19:52 ` Benjamin Herrenschmidt
2013-02-22 23:41 ` Phileas Fogg
2013-02-22 22:45 ` Benjamin Herrenschmidt
2013-02-22 23:53 ` Phileas Fogg
2013-02-21 22:06 ` Phileas Fogg
2013-02-21 23:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5127D9CE.2090500@mail.ru \
--to=phileas-fogg@mail.ru \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.