From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v4 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation Date: Tue, 26 Feb 2013 22:57:15 +0100 Message-ID: <512D2FBB.5090507@gmail.com> References: <1360912200-26377-1-git-send-email-vikas.sajjan@linaro.org> <1360912200-26377-6-git-send-email-vikas.sajjan@linaro.org> <511E1008.6010308@samsung.com> <5122A119.7070501@gmail.com> <5127E533.4060702@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Vikas Sajjan Cc: Sylwester Nawrocki , linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, devicetree-discuss@lists.ozlabs.org, sunil joshi , Inki Dae , Tom Gall List-Id: devicetree@vger.kernel.org On 02/26/2013 05:19 AM, Vikas Sajjan wrote: > ok thanks. Will modify the documentation as below. > > compatible = "samsung, exynos4-fimd"; for Exynos4 SoCs > compatible = "samsung, exynos5-fimd" ; for Exynos5 SoCs > compatible = "samsung, s3c64xx-fimd" ; for S3C64XX SoCs > compatible = "samsung, s3c24xx-fimd" ; for S3C24XX SoCs > compatible = "samsung, s5p64x0-fimd" ; for S5P64X0 SoCs There should be no wildcards in the compatible property. I guess we can just add the two first one above for now and leave other out for when someone actually adds support for these SoCs at the drivers. I suppose we could, for example, have something like: compatible = "samsung,s3c2410-fimd"; // for s3c2410 compatible = "samsung,s3c2440-fimd", "samsung,s3c2410-fimd"; // for s3c2440 etc. But this really needs to be checked with the documentation in each case. > compatible = "samsung, s5pc100-fimd" ; for S5PC100 SoCs > compatible = "samsung, s5pv210-fimd" ; for S5PV210 SoCs