From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v4 5/5] ARM: exynos: dts: Add FIMD DT binding Documentation Date: Tue, 26 Feb 2013 23:48:24 +0100 Message-ID: <512D3BB8.50807@gmail.com> References: <1360912200-26377-1-git-send-email-vikas.sajjan@linaro.org> <512D2FBB.5090507@gmail.com> <3726480.lf0XiLbqs9@flatron> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3726480.lf0XiLbqs9@flatron> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tomasz Figa Cc: Vikas Sajjan , Sylwester Nawrocki , linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, devicetree-discuss@lists.ozlabs.org, sunil joshi , Inki Dae , Tom Gall List-Id: devicetree@vger.kernel.org On 02/26/2013 11:11 PM, Tomasz Figa wrote: > We should stick to the rule that compatible value should be named after > first specific SoC model in which this particular IP version was included. > > So this is what I would suggest: > > compatible = "samsung,s3c2443-fimd"; // for S3C24XX SoCs > compatible = "samsung,s3c6400-fimd"; // for S3C64XX SoCs > compatible = "samsung,s5p6440-fimd"; // for S5P64X0 SoCs > compatible = "samsung,s5pc100-fimd"; // for S5PC100 SoC > compatible = "samsung,s5pv210-fimd"; // for S5PV210 SoC > compatible = "samsung,exynos4210-fimd"; // for Exynos4 SoCs > compatible = "samsung,exynos5250-fimd"; // for Exynos5 SoCs Yes, that looks good to me. I'm just not sure though if there is any reference to "fimd" in the s3c2443 SoC documentation. Or is it simply called lcd controller there ?