From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759878Ab3B0QJJ (ORCPT ); Wed, 27 Feb 2013 11:09:09 -0500 Received: from smtp5.epfl.ch ([128.178.224.8]:53218 "HELO smtp5.epfl.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752265Ab3B0QJG (ORCPT ); Wed, 27 Feb 2013 11:09:06 -0500 Message-ID: <512E2F98.6070404@epfl.ch> Date: Wed, 27 Feb 2013 17:08:56 +0100 From: Florian Vaussard Reply-To: florian.vaussard@epfl.ch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Bryan Wu CC: Thierry Reding , Richard Purdie , Peter Ujfalusi , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep References: <1359381659-24454-1-git-send-email-florian.vaussard@epfl.ch> <1359381659-24454-4-git-send-email-florian.vaussard@epfl.ch> <20130130081728.GC13568@avionic-0098.mockup.avionic-design.de> In-Reply-To: <20130130081728.GC13568@avionic-0098.mockup.avionic-design.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bryan, On 01/30/2013 09:17 AM, Thierry Reding wrote: > On Mon, Jan 28, 2013 at 03:00:59PM +0100, Florian Vaussard wrote: >> Call to led_pwm_set() can happen inside atomic context, like triggers. >> If the PWM call can sleep, defer using a worker. >> >> Cc: Peter Ujfalusi >> Signed-off-by: Florian Vaussard >> --- >> drivers/leds/leds-pwm.c | 50 +++++++++++++++++++++++++++++++++++++++------- >> 1 files changed, 42 insertions(+), 8 deletions(-) > > Bryan, I assume that you'll be taking this? It doesn't apply cleanly to > my tree, probably because of Peter's recent changes that you took > through your tree and Florian based his patches on top of that. The > conflict resolution should be trivial, though. > It seems that this patch was not taken. Could you pull it, as the other part is already in linux-pwm? Or is there any show stopper? Many thanks. Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: florian.vaussard@epfl.ch (Florian Vaussard) Date: Wed, 27 Feb 2013 17:08:56 +0100 Subject: [PATCH v3 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep In-Reply-To: <20130130081728.GC13568@avionic-0098.mockup.avionic-design.de> References: <1359381659-24454-1-git-send-email-florian.vaussard@epfl.ch> <1359381659-24454-4-git-send-email-florian.vaussard@epfl.ch> <20130130081728.GC13568@avionic-0098.mockup.avionic-design.de> Message-ID: <512E2F98.6070404@epfl.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bryan, On 01/30/2013 09:17 AM, Thierry Reding wrote: > On Mon, Jan 28, 2013 at 03:00:59PM +0100, Florian Vaussard wrote: >> Call to led_pwm_set() can happen inside atomic context, like triggers. >> If the PWM call can sleep, defer using a worker. >> >> Cc: Peter Ujfalusi >> Signed-off-by: Florian Vaussard >> --- >> drivers/leds/leds-pwm.c | 50 +++++++++++++++++++++++++++++++++++++++------- >> 1 files changed, 42 insertions(+), 8 deletions(-) > > Bryan, I assume that you'll be taking this? It doesn't apply cleanly to > my tree, probably because of Peter's recent changes that you took > through your tree and Florian based his patches on top of that. The > conflict resolution should be trivial, though. > It seems that this patch was not taken. Could you pull it, as the other part is already in linux-pwm? Or is there any show stopper? Many thanks. Florian