From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-da0-f45.google.com ([209.85.210.45]:40687 "EHLO mail-da0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802Ab3B1ADD (ORCPT ); Wed, 27 Feb 2013 19:03:03 -0500 Received: by mail-da0-f45.google.com with SMTP id v40so556125dad.4 for ; Wed, 27 Feb 2013 16:03:02 -0800 (PST) Message-ID: <512E9EAC.9050700@gmail.com> Date: Thu, 28 Feb 2013 08:02:52 +0800 From: Wang Sheng-Hui MIME-Version: 1.0 To: Dave Chinner CC: xfstests , linux-btrfs@vger.kernel.org, list.btrfs@jan-o-sch.net Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' References: <512DB284.1090806@gmail.com> <20130227230443.GB5551@dastard> In-Reply-To: <20130227230443.GB5551@dastard> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 2013年02月28日 07:04, Dave Chinner wrote: > On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote: >> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by >> -x option of filefrag, and will fail with >> 'FIBMAP: Invalid argument' >> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with >> 'FIEMAP failed with unsupported flags 2' >> Remove the '-x' option. >> >> Signed-off-by: Wang Sheng-Hui > > I can see that this changes what gets dumped into the $seq.full > file, but it seems to me that also changes the extent list returned > to the checking functions. So either the test previously worked and > now it fails with this change, or the test never worked and now it > does, or perhaps something else? > > IOWs, I can't tell why you want to change this from the patch > description, hence I don't know if the original behaviour was > intentional or not. Can you say describe what the overall effect of > the change is in the commit description? Hi Dave, I run xfstests for btrfs against SLES11SP2, not upstream kernel. In the seq.full, I can get the messages 'FIEMAP failed with unsupported flags 2' Then I found that the test will run 'filefrag -vx' on btrfs, and '-v' will run FIEMAP_FLAG_XATTR, which is not supported by btrfs yet, at least in 3.8 kernel. Without the patch, I failed the testcase and got: ============================================= 276 8s ... - output mismatch (see 276.out.bad) --- 276.out 2013-02-25 19:08:58.000000000 -0600 +++ 276.out.bad 2013-02-27 17:59:48.000000000 -0600 @@ -1,4 +1,867 @@ QA output created by 276 *** test backref walking +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument +FIBMAP: Invalid argument ... (Run 'diff -u 276.out 276.out.bad' to see the entire diff) Ran: 276 Failures: 276 Failed 1 of 1 tests In the 276.full, I got something like: ============================================= # filefrag -vx /mnt/scratch/snap1/p0/d4/d21/d4a/f58 Filesystem type is: 9123683e File size of /mnt/scratch/snap1/p0/d4/d21/d4a/f58 is 2125615 (33 blocks, blocksize 65536) FIEMAP failed with unsupported flags 2 With the patch, I can pass the testcase: ============================================= 276 8s ... 7s Ran: 276 Passed all 1 tests > > Cheers, > > Dave. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id C16097F6B for ; Wed, 27 Feb 2013 18:03:06 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 755A1AC004 for ; Wed, 27 Feb 2013 16:03:03 -0800 (PST) Received: from mail-da0-f50.google.com (mail-da0-f50.google.com [209.85.210.50]) by cuda.sgi.com with ESMTP id ePX7s7DzfkAoN3jc (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Wed, 27 Feb 2013 16:03:02 -0800 (PST) Received: by mail-da0-f50.google.com with SMTP id h15so548571dan.9 for ; Wed, 27 Feb 2013 16:03:02 -0800 (PST) Message-ID: <512E9EAC.9050700@gmail.com> Date: Thu, 28 Feb 2013 08:02:52 +0800 From: Wang Sheng-Hui MIME-Version: 1.0 Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' References: <512DB284.1090806@gmail.com> <20130227230443.GB5551@dastard> In-Reply-To: <20130227230443.GB5551@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: list.btrfs@jan-o-sch.net, linux-btrfs@vger.kernel.org, xfstests T24gMjAxM+W5tDAy5pyIMjjml6UgMDc6MDQsIERhdmUgQ2hpbm5lciB3cm90ZToKPiBPbiBXZWQs IEZlYiAyNywgMjAxMyBhdCAwMzoxNToxNlBNICswODAwLCBXYW5nIFNoZW5nLUh1aSB3cm90ZToK Pj4gQnRyZnMgZG9lc24ndCBzdXBwb3J0IEZJRU1BUF9GTEFHX1hBVFRSLCB3aGljaCBpcyBlbmFi bGVkIGJ5Cj4+IC14IG9wdGlvbiBvZiBmaWxlZnJhZywgYW5kIHdpbGwgZmFpbCB3aXRoCj4+IAkn RklCTUFQOiBJbnZhbGlkIGFyZ3VtZW50Jwo+PiBmb3IgJ2ZpbGVmcmFnIC12eCcuICdmaWxlZnJh ZyAtdngnIGZhaWxzIG9uIGJ0cmZzIHdpdGgKPj4gICAgICAnRklFTUFQIGZhaWxlZCB3aXRoIHVu c3VwcG9ydGVkIGZsYWdzIDInCj4+IFJlbW92ZSB0aGUgJy14JyBvcHRpb24uCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IFdhbmcgU2hlbmctSHVpIDxzaGh1aXdAZ21haWwuY29tPgo+Cj4gSSBjYW4gc2Vl IHRoYXQgdGhpcyBjaGFuZ2VzIHdoYXQgZ2V0cyBkdW1wZWQgaW50byB0aGUgJHNlcS5mdWxsCj4g ZmlsZSwgYnV0IGl0IHNlZW1zIHRvIG1lIHRoYXQgYWxzbyBjaGFuZ2VzIHRoZSBleHRlbnQgbGlz dCByZXR1cm5lZAo+IHRvIHRoZSBjaGVja2luZyBmdW5jdGlvbnMuIFNvIGVpdGhlciB0aGUgdGVz dCBwcmV2aW91c2x5IHdvcmtlZCBhbmQKPiBub3cgaXQgZmFpbHMgd2l0aCB0aGlzIGNoYW5nZSwg b3IgdGhlIHRlc3QgbmV2ZXIgd29ya2VkIGFuZCBub3cgaXQKPiBkb2VzLCBvciBwZXJoYXBzIHNv bWV0aGluZyBlbHNlPwo+Cj4gSU9XcywgSSBjYW4ndCB0ZWxsIHdoeSB5b3Ugd2FudCB0byBjaGFu Z2UgdGhpcyBmcm9tIHRoZSBwYXRjaAo+IGRlc2NyaXB0aW9uLCBoZW5jZSBJIGRvbid0IGtub3cg aWYgdGhlIG9yaWdpbmFsIGJlaGF2aW91ciB3YXMKPiBpbnRlbnRpb25hbCBvciBub3QuICBDYW4g eW91IHNheSBkZXNjcmliZSB3aGF0IHRoZSBvdmVyYWxsIGVmZmVjdCBvZgo+IHRoZSBjaGFuZ2Ug aXMgaW4gdGhlIGNvbW1pdCBkZXNjcmlwdGlvbj8KCkhpIERhdmUsCgpJIHJ1biB4ZnN0ZXN0cyBm b3IgYnRyZnMgYWdhaW5zdCBTTEVTMTFTUDIsIG5vdCB1cHN0cmVhbSBrZXJuZWwuCkluIHRoZSBz ZXEuZnVsbCwgSSBjYW4gZ2V0IHRoZSBtZXNzYWdlcwoJJ0ZJRU1BUCBmYWlsZWQgd2l0aCB1bnN1 cHBvcnRlZCBmbGFncyAyJwoKVGhlbiBJIGZvdW5kIHRoYXQgdGhlIHRlc3Qgd2lsbCBydW4gJ2Zp bGVmcmFnIC12eCcgb24gYnRyZnMsIGFuZAonLXYnIHdpbGwgcnVuIEZJRU1BUF9GTEFHX1hBVFRS LCB3aGljaCBpcyBub3Qgc3VwcG9ydGVkIGJ5IGJ0cmZzCnlldCwgYXQgbGVhc3QgaW4gMy44IGtl cm5lbC4KCldpdGhvdXQgdGhlIHBhdGNoLCBJIGZhaWxlZCB0aGUgdGVzdGNhc2UgYW5kIGdvdDoK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CjI3NiA4cyAuLi4g LSBvdXRwdXQgbWlzbWF0Y2ggKHNlZSAyNzYub3V0LmJhZCkKICAgICAtLS0gMjc2Lm91dAkyMDEz LTAyLTI1IDE5OjA4OjU4LjAwMDAwMDAwMCAtMDYwMAogICAgICsrKyAyNzYub3V0LmJhZAkyMDEz LTAyLTI3IDE3OjU5OjQ4LjAwMDAwMDAwMCAtMDYwMAogICAgIEBAIC0xLDQgKzEsODY3IEBACiAg ICAgIFFBIG91dHB1dCBjcmVhdGVkIGJ5IDI3NgogICAgICAqKiogdGVzdCBiYWNrcmVmIHdhbGtp bmcKICAgICArRklCTUFQOiBJbnZhbGlkIGFyZ3VtZW50CiAgICAgK0ZJQk1BUDogSW52YWxpZCBh cmd1bWVudAogICAgICtGSUJNQVA6IEludmFsaWQgYXJndW1lbnQKICAgICArRklCTUFQOiBJbnZh bGlkIGFyZ3VtZW50CiAgICAgK0ZJQk1BUDogSW52YWxpZCBhcmd1bWVudAogICAgICAuLi4KICAg ICAgKFJ1biAnZGlmZiAtdSAyNzYub3V0IDI3Ni5vdXQuYmFkJyB0byBzZWUgdGhlIGVudGlyZSBk aWZmKQpSYW46IDI3NgpGYWlsdXJlczogMjc2CkZhaWxlZCAxIG9mIDEgdGVzdHMKCkluIHRoZSAy NzYuZnVsbCwgSSBnb3Qgc29tZXRoaW5nIGxpa2U6Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQojIGZpbGVmcmFnIC12eCAvbW50L3NjcmF0Y2gvc25hcDEvcDAv ZDQvZDIxL2Q0YS9mNTgKRmlsZXN5c3RlbSB0eXBlIGlzOiA5MTIzNjgzZQpGaWxlIHNpemUgb2Yg L21udC9zY3JhdGNoL3NuYXAxL3AwL2Q0L2QyMS9kNGEvZjU4IGlzIDIxMjU2MTUgKDMzIGJsb2Nr cywgYmxvY2tzaXplIDY1NTM2KQpGSUVNQVAgZmFpbGVkIHdpdGggdW5zdXBwb3J0ZWQgZmxhZ3Mg MgoKCldpdGggdGhlIHBhdGNoLCBJIGNhbiBwYXNzIHRoZSB0ZXN0Y2FzZToKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CjI3NiA4cyAuLi4gN3MKUmFuOiAyNzYK UGFzc2VkIGFsbCAxIHRlc3RzCgoKPgo+IENoZWVycywKPgo+IERhdmUuCj4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCnhmcyBtYWlsaW5nIGxpc3QKeGZz QG9zcy5zZ2kuY29tCmh0dHA6Ly9vc3Muc2dpLmNvbS9tYWlsbWFuL2xpc3RpbmZvL3hmcwo=