From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696AbdIKTxD (ORCPT ); Mon, 11 Sep 2017 15:53:03 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:38850 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbdIKTw7 (ORCPT ); Mon, 11 Sep 2017 15:52:59 -0400 X-Google-Smtp-Source: AOwi7QBtKc/vXDJfeeAY9H09gvGX0E7OmD85R/rtKVc1NzrH0aCrVxr5IOHNKOQkbb/d5+JHtluuYg== Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' To: Christophe JAILLET , jack@suse.cz, tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> From: Jens Axboe Message-ID: <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> Date: Mon, 11 Sep 2017 13:52:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2017 01:43 PM, Christophe JAILLET wrote: > If the 'kmalloc' fails, we must go through the existing error handling > path. Looks good to me, probably wants a Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") line as well. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Mon, 11 Sep 2017 19:52:56 +0000 Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' Message-Id: <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> List-Id: References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET , jack@suse.cz, tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/11/2017 01:43 PM, Christophe JAILLET wrote: > If the 'kmalloc' fails, we must go through the existing error handling > path. Looks good to me, probably wants a Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") line as well. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f72.google.com (mail-it0-f72.google.com [209.85.214.72]) by kanga.kvack.org (Postfix) with ESMTP id C74676B02E5 for ; Mon, 11 Sep 2017 15:53:00 -0400 (EDT) Received: by mail-it0-f72.google.com with SMTP id o200so13454666itg.2 for ; Mon, 11 Sep 2017 12:53:00 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id m15sor1812528iod.275.2017.09.11.12.52.59 for (Google Transport Security); Mon, 11 Sep 2017 12:52:59 -0700 (PDT) Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> From: Jens Axboe Message-ID: <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> Date: Mon, 11 Sep 2017 13:52:56 -0600 MIME-Version: 1.0 In-Reply-To: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christophe JAILLET , jack@suse.cz, tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/11/2017 01:43 PM, Christophe JAILLET wrote: > If the 'kmalloc' fails, we must go through the existing error handling > path. Looks good to me, probably wants a Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") line as well. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org