All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/11] sandbox: Add a way of obtaining directory listings
Date: Fri, 1 Mar 2013 13:26:46 -0500	[thread overview]
Message-ID: <5130F2E6.3010806@ti.com> (raw)
In-Reply-To: <CAPnjgZ0EPNk+YtSAUHJj7aUL_GbMBWCS2UNuX2-MF6AbyGhPnQ@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/01/2013 01:21 PM, Simon Glass wrote:
> Hi Tom,
> 
> On Fri, Mar 1, 2013 at 9:37 AM, Tom Rini <trini@ti.com> wrote:
>> On Wed, Dec 26, 2012 at 11:53:34AM -0800, Simon Glass wrote:
>>> This implementation uses opendir()/readdir() to access the
>>> directory information and then puts it in a linked list for the
>>> caller's use.
>>> 
>>> Signed-off-by: Simon Glass <sjg@chromium.org> --- 
>>> arch/sandbox/cpu/os.c |  101
>>> +++++++++++++++++++++++++++++++++++++++++++++++++ include/os.h
>>> |   48 +++++++++++++++++++++++ 2 files changed, 149
>>> insertions(+), 0 deletions(-)
>> 
>> Since the code looks fine,
>> 
>> Reviewed-by: Tom Rini <trini@ti.com>
>> 
>> But a question.  Do you really want this in cpu/os.c rather than
>> some new file for filesystem stuff (since this is the arch side
>> of sandboxfs) ?  I can see you saying it should stay here since
>> it's all OS interaction related stuff.
> 
> Thanks for reviewing. The practical reason why everything is in
> os.c is that this file is the interface between files which
> include common.h and files which include system headers. But
> logically speaking, I have tended to make os.c hold anything that
> interfaces with or calls a Linux API function.
> 
> We could certainly create something like os_filedir,c or similar
> if os.c is getting a bit large. But it would still need to include
> system headers. I don't think we want anything like this in in
> drivers/ at present.

I agree with not putting this into drivers/ as it's sandbox-side
stuff.  If os.c isn't yet unwieldy to you, OK, we can go as-is.  But
I'll ask next time you add another big hunk to os.c I'll ask if it's
unwieldy yet.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRMPLmAAoJENk4IS6UOR1W+1YP/Rveu5b/OoEPqTqo6akhTiZa
chVnl0td2tFYW6SQmLfCn8qPLBjsprsxlUzAywkvBzn8HJ33wPtKx00vCj04m9Fw
ELbFuGpEkLEkHL6UEF2j9PGtZKudqybl7m0RRWIZfVA3ku4rPvav0w59WFzhNKF7
5EqzMyfvVX9XlnkVJ6H75H/JkNFxF3DaJ9jYs7zeOxmlyhgPby4df8GQEENpOvRs
co2DvlbcuT3pHXAW7jqUYMb3wGphvCKlb2NE8fOjPszCm9F5En/M3i01lKFVRPZ1
MSLszZaUmMm6K4UjLVdnAAl8lPmP7SdwpsH0EhmehsVlh7jshbjhbEgAcN4tr2+V
nUP/yW8gJl3oJ0JL04HV0ggYY7U71WnTRC+AMJcFdfen/4btfqGkJbERp5fiO6La
qO8kx+mhl4hycMB+2pAhux6b4wK+vPXuyK7QbnliKA715S9FK3huf/u/QiPntKMA
6kE23ROuZMzvpnRu39brPCSAXLjDgyxWR+ofT/BuKPyrcXvOFjTa+IyI3EcFPKFX
0CdaGU6b/cxBVOHkBBeRLq0a5I2NNjV3dEXW78B9HmRNSpeDpCiZrNKDOe5ov1XH
MVqthVBxQWgvoSZrQ+t4ff8dnP2fjNJfaUn15+EzmM8YZDPownNlaLaiSMuKL3dR
XmF60m4s5kHSYpLOWa9l
=jsTJ
-----END PGP SIGNATURE-----

  reply	other threads:[~2013-03-01 18:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-26 19:53 [U-Boot] [PATCH 0/11] sandbox: Add filesystem support Simon Glass
2012-12-26 19:53 ` [U-Boot] [PATCH 01/11] ext4: Split write support into its own file Simon Glass
2012-12-27 14:46   ` Lukasz Majewski
2013-02-07 11:35     ` Lukasz Majewski
2013-02-08  6:51       ` Simon Glass
2013-02-08  7:23         ` Lukasz Majewski
2013-03-01 17:35   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 02/11] fs: Fully populate the filesystem method struct Simon Glass
2013-03-01 17:35   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 03/11] fs: Use filesystem methods instead of switch() Simon Glass
2013-03-01 17:35   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 04/11] fs: Tell probe functions where to put their results Simon Glass
2013-03-01 17:36   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 05/11] fs: Use map_sysmem() on read Simon Glass
2013-03-01 17:36   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 06/11] fs: Move ls and read methods into ext4, fat Simon Glass
2013-03-01 17:36   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 07/11] sandbox: Add a way of obtaining directory listings Simon Glass
2013-03-01 17:37   ` Tom Rini
2013-03-01 18:21     ` Simon Glass
2013-03-01 18:26       ` Tom Rini [this message]
2013-03-01 18:27         ` Simon Glass
2012-12-26 19:53 ` [U-Boot] [PATCH 08/11] sandbox: Add host filesystem Simon Glass
2013-03-01 17:37   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 09/11] sandbox: Add 'sb' command to access filesystem features Simon Glass
2013-03-01 17:37   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 10/11] sandbox: Enable ext4 and fat filesystems Simon Glass
2013-03-01 17:37   ` Tom Rini
2012-12-26 19:53 ` [U-Boot] [PATCH 11/11] sandbox: config: Enable sandbox command Simon Glass
2013-03-01 17:37   ` Tom Rini
2013-02-24 17:35 ` [U-Boot] [PATCH 0/11] sandbox: Add filesystem support Simon Glass
2013-03-04 21:27   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5130F2E6.3010806@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.