From: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Richard Weinberger <richard@nod.at>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/8] mtd-utils: Add flash torture test utility
Date: Wed, 27 Apr 2016 11:28:57 +0200 [thread overview]
Message-ID: <5130ded8-10e2-584b-a7a2-ebc0cdaa1ad8@sigma-star.at> (raw)
In-Reply-To: <CAAEAJfCP1Lsxe+9r1vp-iaZsJhjfa+uZi+=kPpocSpc-zaA_cg@mail.gmail.com>
On 04/26/2016 04:34 PM, Ezequiel Garcia wrote:
> mtd_torture seems to print its own message when the torture fails:
>
> normsg("PEB %d passed torture test, do not mark it a bad", eb);
>
> Isn't confusing to print "do not mark it a bad" (sic) in the torture test?
> I mean: this would imply that the test would mark as bad if the torture fails?
>
Presumably mtd_torture was specifically written for ubiformat or moved over from
the ubiformat utility to libmtd, judging from the kind of diagnostics it generates
on its own.
It would probably be better to move these kinds of those diagnostics back/over to
ubiformat that uses the function to determine if it should mark a block as bad.
David
next prev parent reply other threads:[~2016-04-27 9:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 22:13 [RFC] Porting kernel MTD tests to user space Richard Weinberger
2016-04-25 22:13 ` [PATCH 1/8] mtd-utils: Fix return status in mtd_torture test function Richard Weinberger
2016-04-26 7:57 ` Boris Brezillon
2016-07-13 17:30 ` Brian Norris
2016-07-13 21:59 ` Richard Weinberger
2016-07-13 22:06 ` Brian Norris
2016-04-25 22:13 ` [PATCH 2/8] mtd-utils: Add multi-block erase function Richard Weinberger
2016-04-26 8:04 ` Boris Brezillon
2016-04-27 9:21 ` David Oberhollenzer
2016-04-27 9:27 ` Boris Brezillon
2016-04-25 22:13 ` [PATCH 3/8] mtd-utils: Add flash torture test utility Richard Weinberger
2016-04-26 8:13 ` Boris Brezillon
2016-04-26 14:34 ` Ezequiel Garcia
2016-04-27 9:28 ` David Oberhollenzer [this message]
2016-04-25 22:13 ` [PATCH 4/8] mtd-utils: Add flash stress test Utility Richard Weinberger
2016-04-26 8:18 ` Boris Brezillon
2016-04-26 9:22 ` Richard Weinberger
2016-04-26 9:47 ` Boris Brezillon
2016-04-27 16:38 ` Brian Norris
2016-04-25 22:13 ` [PATCH 5/8] mtd-utils: Add flash speed " Richard Weinberger
2016-04-25 22:13 ` [PATCH 6/8] mtd-utils: Add nand flash bit errors test Richard Weinberger
2016-04-25 22:13 ` [PATCH 7/8] mtd-utils: Add flash read test utility Richard Weinberger
2016-04-25 22:13 ` [PATCH 8/8] mtd-utils: Add nand page " Richard Weinberger
2016-04-26 3:13 ` [RFC] Porting kernel MTD tests to user space Ezequiel Garcia
2016-04-26 7:00 ` Richard Weinberger
2016-04-27 16:32 ` Brian Norris
2016-04-26 5:17 ` Artem Bityutskiy
2016-04-26 6:58 ` Richard Weinberger
2016-04-26 7:45 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130ded8-10e2-584b-a7a2-ebc0cdaa1ad8@sigma-star.at \
--to=david.oberhollenzer@sigma-star.at \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.