All of lore.kernel.org
 help / color / mirror / Atom feed
From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
To: leirao <lei.rao@intel.com>,
	"chen.zhang@intel.com" <chen.zhang@intel.com>,
	 "jasowang@redhat.com" <jasowang@redhat.com>,
	"quintela@redhat.com" <quintela@redhat.com>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"lukasstraub2@web.de" <lukasstraub2@web.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 01/10] Remove some duplicate trace code.
Date: Fri, 12 Mar 2021 06:32:52 +0000	[thread overview]
Message-ID: <5130eb60-8b81-6d4b-bd60-c48508fa3ba5@fujitsu.com> (raw)
In-Reply-To: <1615525383-59071-2-git-send-email-lei.rao@intel.com>



On 3/12/21 1:02 PM, leirao wrote:
> From: "Rao, Lei" <lei.rao@intel.com>
>
> There is the same trace code in the colo_compare_packet_payload.
>
> Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>

> ---
>   net/colo-compare.c | 13 -------------
>   1 file changed, 13 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 84db497..9e18baa 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -590,19 +590,6 @@ static int colo_packet_compare_other(Packet *spkt, Packet *ppkt)
>       uint16_t offset = ppkt->vnet_hdr_len;
>   
>       trace_colo_compare_main("compare other");
> -    if (trace_event_get_state_backends(TRACE_COLO_COMPARE_IP_INFO)) {
> -        char pri_ip_src[20], pri_ip_dst[20], sec_ip_src[20], sec_ip_dst[20];
> -
> -        strcpy(pri_ip_src, inet_ntoa(ppkt->ip->ip_src));
> -        strcpy(pri_ip_dst, inet_ntoa(ppkt->ip->ip_dst));
> -        strcpy(sec_ip_src, inet_ntoa(spkt->ip->ip_src));
> -        strcpy(sec_ip_dst, inet_ntoa(spkt->ip->ip_dst));
> -
> -        trace_colo_compare_ip_info(ppkt->size, pri_ip_src,
> -                                   pri_ip_dst, spkt->size,
> -                                   sec_ip_src, sec_ip_dst);
> -    }
> -
>       if (ppkt->size != spkt->size) {
>           trace_colo_compare_main("Other: payload size of packets are different");
>           return -1;

  reply	other threads:[~2021-03-12  9:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  5:02 [PATCH v2 00/10] Fixed some bugs and optimized some codes for COLO leirao
2021-03-12  5:02 ` [PATCH v2 01/10] Remove some duplicate trace code leirao
2021-03-12  6:32   ` lizhijian [this message]
2021-03-12  5:02 ` [PATCH v2 02/10] Fix the qemu crash when guest shutdown during checkpoint leirao
2021-03-12  6:25   ` lizhijian
2021-03-12  5:02 ` [PATCH v2 03/10] Optimize the function of filter_send leirao
2021-03-12  6:36   ` lizhijian
2021-03-12  5:02 ` [PATCH v2 04/10] Remove migrate_set_block_enabled in checkpoint leirao
2021-03-12 10:11   ` lizhijian
2021-03-12  5:02 ` [PATCH v2 05/10] Optimize the function of packet_new leirao
2021-03-12  6:53   ` lizhijian
2021-03-12  9:56     ` Rao, Lei
2021-03-12 10:23       ` lizhijian
2021-03-12 11:50         ` Rao, Lei
2021-03-12  5:02 ` [PATCH v2 06/10] Add the function of colo_compare_cleanup leirao
2021-03-12  5:03 ` [PATCH v2 07/10] Reset the auto-converge counter at every checkpoint leirao
2021-03-12  5:03 ` [PATCH v2 08/10] Reduce the PVM stop time during Checkpoint leirao
2021-03-12  7:54   ` lizhijian
2021-03-12 10:12     ` Rao, Lei
2021-03-12  5:03 ` [PATCH v2 09/10] Add the function of colo_bitmap_clear_diry leirao
2021-03-12 10:28   ` lizhijian
2021-03-12  5:03 ` [PATCH v2 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() leirao
2021-03-12  8:00   ` lizhijian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5130eb60-8b81-6d4b-bd60-c48508fa3ba5@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=chen.zhang@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lei.rao@intel.com \
    --cc=lukasstraub2@web.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.