From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e56h3-0004Nj-Ry for qemu-devel@nongnu.org; Thu, 19 Oct 2017 05:00:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e56gu-00082h-0e for qemu-devel@nongnu.org; Thu, 19 Oct 2017 05:00:45 -0400 Received: from smtp.citrix.com.au ([103.14.252.240]:35995) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e56gt-0007wt-Cr for qemu-devel@nongnu.org; Thu, 19 Oct 2017 05:00:35 -0400 From: Owen Smith Date: Thu, 19 Oct 2017 09:00:27 +0000 Message-ID: <5136b1e64d2c412aab5f5a5264a599e2@AMSPEX02CL02.citrite.net> References: <1506437019-17946-1-git-send-email-owen.smith@citrix.com> <1506437019-17946-4-git-send-email-owen.smith@citrix.com> <20171002170132.GA2116@perard.uk.xensource.com> <20171011154718.GQ1771@perard.uk.xensource.com> <1507800365.26812.11.camel@redhat.com> <0941888f3e184161a54e9c4509a1faab@AMSPEX02CL03.citrite.net> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , Paul Durrant Cc: 'Gerd Hoffmann' , Anthony Perard , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" > -----Original Message----- > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > Sent: 12 October 2017 18:27 > To: Paul Durrant > Cc: 'Gerd Hoffmann' ; 'Stefano Stabellini' > ; Anthony Perard ; > qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Owen Smith > > Subject: RE: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw- > pointer >=20 > On Thu, 12 Oct 2017, Paul Durrant wrote: > > > -----Original Message----- > > > From: Gerd Hoffmann [mailto:kraxel@redhat.com] > > > Sent: 12 October 2017 10:26 > > > To: Paul Durrant ; 'Stefano Stabellini' > > > ; Anthony Perard > > > Cc: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Owen > > > Smith > > > Subject: Re: [Xen-devel] [PATCH 3/3 v4] xenfb: Add > > > [feature|request]-raw- pointer > > > > > > Hi, > > > > > > > It's probably OS specific though. I guess the behaviour changed > > > > because the OS favours absolute pointing devices over relative > > > > ones and how it has two absolute ones to choose from. How it > > > > reconciles those, who knows? > > > > > > Typically hid emulation calls qemu_input_handler_activate() when the > > > guest initializes the device, which moves the device to the top of > > > the priority list. > > > > > > Visible effect on a typical guest with ps/2 mouse and usb-tablet is > > > that qemu switches from relative mode (mouse) to absolute mode > > > (tablet) when the guest loads the usb hid driver. > > > > > > I suspect pvmouse is doing the same thing. So it may simply depend > > > on guest driver load order whenever pvmouse or usb-tablet is used. > > > > > > Simplest fix is probably to only attach the device you plan to use > > > to the guest. If you can't turn off pvmouse for xen guests then you > > > might want drop the qemu_input_handler_activate() call, so it > > > behaves simliar to the ps/2 mouse (is used in case no other pointer > device is present). > > > > Avoiding the activate call sounds reasonable and should avoid the > behavioural change. >=20 > +1 >=20 > Owen, are you up for resubmitting the series with this small change? Having just rebuilt my xen / linux host, and checked qemu, it looks like th= e keycodemapdb patches have gone in, so I'll rebase and re-submit this seri= es Owen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Owen Smith Subject: Re: [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer Date: Thu, 19 Oct 2017 09:00:27 +0000 Message-ID: <5136b1e64d2c412aab5f5a5264a599e2@AMSPEX02CL02.citrite.net> References: <1506437019-17946-1-git-send-email-owen.smith@citrix.com> <1506437019-17946-4-git-send-email-owen.smith@citrix.com> <20171002170132.GA2116@perard.uk.xensource.com> <20171011154718.GQ1771@perard.uk.xensource.com> <1507800365.26812.11.camel@redhat.com> <0941888f3e184161a54e9c4509a1faab@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e56gs-0000NG-6h for xen-devel@lists.xenproject.org; Thu, 19 Oct 2017 09:00:34 +0000 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini , Paul Durrant Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , 'Gerd Hoffmann' , "qemu-devel@nongnu.org" List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSBb bWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmddCj4gU2VudDogMTIgT2N0b2JlciAyMDE3IDE4 OjI3Cj4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+Cj4gQ2M6ICdH ZXJkIEhvZmZtYW5uJyA8a3JheGVsQHJlZGhhdC5jb20+OyAnU3RlZmFubyBTdGFiZWxsaW5pJwo+ IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQW50aG9ueSBQZXJhcmQgPGFudGhvbnkucGVyYXJk QGNpdHJpeC5jb20+Owo+IHFlbXUtZGV2ZWxAbm9uZ251Lm9yZzsgeGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnOyBPd2VuIFNtaXRoCj4gPG93ZW4uc21pdGhAY2l0cml4LmNvbT4KPiBTdWJq ZWN0OiBSRTogW1hlbi1kZXZlbF0gW1BBVENIIDMvMyB2NF0geGVuZmI6IEFkZCBbZmVhdHVyZXxy ZXF1ZXN0XS1yYXctCj4gcG9pbnRlcgo+IAo+IE9uIFRodSwgMTIgT2N0IDIwMTcsIFBhdWwgRHVy cmFudCB3cm90ZToKPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+ID4gRnJvbTog R2VyZCBIb2ZmbWFubiBbbWFpbHRvOmtyYXhlbEByZWRoYXQuY29tXQo+ID4gPiBTZW50OiAxMiBP Y3RvYmVyIDIwMTcgMTA6MjYKPiA+ID4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNp dHJpeC5jb20+OyAnU3RlZmFubyBTdGFiZWxsaW5pJwo+ID4gPiA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz47IEFudGhvbnkgUGVyYXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgo+ID4gPiBD YzogcWVtdS1kZXZlbEBub25nbnUub3JnOyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7 IE93ZW4KPiA+ID4gU21pdGggPG93ZW4uc21pdGhAY2l0cml4LmNvbT4KPiA+ID4gU3ViamVjdDog UmU6IFtYZW4tZGV2ZWxdIFtQQVRDSCAzLzMgdjRdIHhlbmZiOiBBZGQKPiA+ID4gW2ZlYXR1cmV8 cmVxdWVzdF0tcmF3LSBwb2ludGVyCj4gPiA+Cj4gPiA+ICAgSGksCj4gPiA+Cj4gPiA+ID4gSXQn cyBwcm9iYWJseSBPUyBzcGVjaWZpYyB0aG91Z2guIEkgZ3Vlc3MgdGhlIGJlaGF2aW91ciBjaGFu Z2VkCj4gPiA+ID4gYmVjYXVzZSB0aGUgT1MgZmF2b3VycyBhYnNvbHV0ZSBwb2ludGluZyBkZXZp Y2VzIG92ZXIgcmVsYXRpdmUKPiA+ID4gPiBvbmVzIGFuZCBob3cgaXQgaGFzIHR3byBhYnNvbHV0 ZSBvbmVzIHRvIGNob29zZSBmcm9tLiBIb3cgaXQKPiA+ID4gPiByZWNvbmNpbGVzIHRob3NlLCB3 aG8ga25vd3M/Cj4gPiA+Cj4gPiA+IFR5cGljYWxseSBoaWQgZW11bGF0aW9uIGNhbGxzIHFlbXVf aW5wdXRfaGFuZGxlcl9hY3RpdmF0ZSgpIHdoZW4gdGhlCj4gPiA+IGd1ZXN0IGluaXRpYWxpemVz IHRoZSBkZXZpY2UsIHdoaWNoIG1vdmVzIHRoZSBkZXZpY2UgdG8gdGhlIHRvcCBvZgo+ID4gPiB0 aGUgcHJpb3JpdHkgbGlzdC4KPiA+ID4KPiA+ID4gVmlzaWJsZSBlZmZlY3Qgb24gYSB0eXBpY2Fs IGd1ZXN0IHdpdGggcHMvMiBtb3VzZSBhbmQgdXNiLXRhYmxldCBpcwo+ID4gPiB0aGF0IHFlbXUg c3dpdGNoZXMgZnJvbSByZWxhdGl2ZSBtb2RlIChtb3VzZSkgdG8gYWJzb2x1dGUgbW9kZQo+ID4g PiAodGFibGV0KSAgd2hlbiB0aGUgZ3Vlc3QgbG9hZHMgdGhlIHVzYiBoaWQgZHJpdmVyLgo+ID4g Pgo+ID4gPiBJIHN1c3BlY3QgcHZtb3VzZSBpcyBkb2luZyB0aGUgc2FtZSB0aGluZy4gIFNvIGl0 IG1heSBzaW1wbHkgZGVwZW5kCj4gPiA+IG9uIGd1ZXN0IGRyaXZlciBsb2FkIG9yZGVyIHdoZW5l dmVyIHB2bW91c2Ugb3IgdXNiLXRhYmxldCBpcyB1c2VkLgo+ID4gPgo+ID4gPiBTaW1wbGVzdCBm aXggaXMgcHJvYmFibHkgdG8gb25seSBhdHRhY2ggdGhlIGRldmljZSB5b3UgcGxhbiB0byB1c2UK PiA+ID4gdG8gdGhlIGd1ZXN0LiAgSWYgeW91IGNhbid0IHR1cm4gb2ZmIHB2bW91c2UgZm9yIHhl biBndWVzdHMgdGhlbiB5b3UKPiA+ID4gbWlnaHQgd2FudCBkcm9wIHRoZSBxZW11X2lucHV0X2hh bmRsZXJfYWN0aXZhdGUoKSBjYWxsLCBzbyBpdAo+ID4gPiBiZWhhdmVzIHNpbWxpYXIgdG8gdGhl IHBzLzIgbW91c2UgKGlzIHVzZWQgaW4gY2FzZSBubyBvdGhlciBwb2ludGVyCj4gZGV2aWNlIGlz IHByZXNlbnQpLgo+ID4KPiA+IEF2b2lkaW5nIHRoZSBhY3RpdmF0ZSBjYWxsIHNvdW5kcyByZWFz b25hYmxlIGFuZCBzaG91bGQgYXZvaWQgdGhlCj4gYmVoYXZpb3VyYWwgY2hhbmdlLgo+IAo+ICsx Cj4gCj4gT3dlbiwgYXJlIHlvdSB1cCBmb3IgcmVzdWJtaXR0aW5nIHRoZSBzZXJpZXMgd2l0aCB0 aGlzIHNtYWxsIGNoYW5nZT8KCkhhdmluZyBqdXN0IHJlYnVpbHQgbXkgeGVuIC8gbGludXggaG9z dCwgYW5kIGNoZWNrZWQgcWVtdSwgaXQgbG9va3MgbGlrZSB0aGUga2V5Y29kZW1hcGRiIHBhdGNo ZXMgaGF2ZSBnb25lIGluLCBzbyBJJ2xsIHJlYmFzZSBhbmQgcmUtc3VibWl0IHRoaXMgc2VyaWVz CgpPd2VuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK