All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: Prabhakar Lad <prabhakar.lad@ti.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	<davinci-linux-open-source@linux.davincidsp.com>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	<linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: davinci: kconfig: fix incorrect selects
Date: Wed, 6 Mar 2013 15:37:15 +0530	[thread overview]
Message-ID: <51371553.5030103@ti.com> (raw)
In-Reply-To: <CA+V-a8u0XLAN72ky05JO_4vvoMjnHXoXS7JAk6OPO3r8r46CLw@mail.gmail.com>

On 3/6/2013 2:59 PM, Prabhakar Lad wrote:

>>  config VIDEO_DAVINCI_VPIF_DISPLAY
>>         tristate "DM646x/DA850/OMAPL138 EVM Video Display"
>> -       depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM)
>> +       depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM) && VIDEO_DAVINCI_VPIF
>>         select VIDEOBUF2_DMA_CONTIG
>> -       select VIDEO_DAVINCI_VPIF
>>         select VIDEO_ADV7343 if MEDIA_SUBDRV_AUTOSELECT
>>         select VIDEO_THS7303 if MEDIA_SUBDRV_AUTOSELECT
>>         help
>> @@ -15,9 +14,8 @@ config VIDEO_DAVINCI_VPIF_DISPLAY
>>
>>  config VIDEO_DAVINCI_VPIF_CAPTURE
>>         tristate "DM646x/DA850/OMAPL138 EVM Video Capture"
>> -       depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM)
>> +       depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM) && VIDEO_DAVINCI_VPIF
>>         select VIDEOBUF2_DMA_CONTIG
>> -       select VIDEO_DAVINCI_VPIF
>>         help
>>           Enables Davinci VPIF module used for captur devices.
>>           This module is common for following DM6467/DA850/OMAPL138
>> @@ -28,7 +26,7 @@ config VIDEO_DAVINCI_VPIF_CAPTURE
>>
>>  config VIDEO_DAVINCI_VPIF
>>         tristate "DaVinci VPIF Driver"
>> -       depends on VIDEO_DAVINCI_VPIF_DISPLAY || VIDEO_DAVINCI_VPIF_CAPTURE
>> +       depends on ARCH_DAVINCI
> 
> It would be better if this was  depends on MACH_DAVINCI_DM6467_EVM ||
> MACH_DAVINCI_DA850_EVM
> rather than 'ARCH_DAVINCI' then you can remove 'MACH_DAVINCI_DM6467_EVM' and
> 'MACH_DAVINCI_DA850_EVM' dependency from VIDEO_DAVINCI_VPIF_DISPLAY and
> VIDEO_DAVINCI_VPIF_CAPTURE. So it would be just 'depends on VIDEO_DEV
> && VIDEO_DAVINCI_VPIF'

I could, but vpif.c seems pretty board independent to me. Are you sure
no other board would like to build vpif.c? BTW, are vpif_display.c and
vpif_capture.c really that board specific? May be we can all make them
depend on ARCH_DAVINCI?

> 
> BTW this patch doesn’t apply on3.9.0-rc1.

Oops. I based this on a handy v3.8. I will fix.

Thanks,
sekhar

  reply	other threads:[~2013-03-06 10:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1362492801-13202-1-git-send-email-nsekhar@ti.com>
2013-03-06  9:29 ` [PATCH] media: davinci: kconfig: fix incorrect selects Prabhakar Lad
2013-03-06 10:07   ` Sekhar Nori [this message]
2013-03-06 10:16     ` Prabhakar Lad
2013-03-06 10:21       ` Prabhakar Lad
2013-03-06 10:23       ` Sekhar Nori
2013-03-06 10:35         ` Prabhakar Lad
2013-03-06 14:21           ` Sekhar Nori
2013-03-07  7:17             ` Prabhakar Lad
2013-03-07 11:24               ` Sekhar Nori
2013-03-07 11:39                 ` Prabhakar Lad
     [not found]                   ` <1363004536-27314-1-git-send-email-nsekhar@ti.com>
2013-03-12  5:14                     ` Prabhakar Lad
2013-03-12  6:48                       ` cstsai
2013-03-12  8:16                       ` Sekhar Nori
2013-03-19 10:39                         ` Sekhar Nori
     [not found]                         ` <1363079692-16683-1-git-send-email-nsekhar@ti.com>
2013-03-16  8:36                           ` [PATCH v3] " Prabhakar Lad
2013-03-18  8:42                             ` Sekhar Nori
2013-04-08  8:09                           ` Prabhakar Lad
2013-04-08  9:53                             ` Sekhar Nori
2013-05-13  9:41                           ` [v3] " Paul Bolle
2013-05-13  9:57                             ` Prabhakar Lad
2013-05-13 10:05                               ` Paul Bolle
2013-05-13 10:41                                 ` Prabhakar Lad
2013-05-23 10:23                                   ` Hans Verkuil
2013-05-23 10:25                                     ` Prabhakar Lad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51371553.5030103@ti.com \
    --to=nsekhar@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.lad@ti.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.