From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3tA-0005da-K8 for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:27:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UE3t5-0007Fj-LA for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:27:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3t5-0007Fe-CK for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:27:31 -0500 Message-ID: <513A49AF.6090100@redhat.com> Date: Fri, 08 Mar 2013 13:27:27 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-4-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1362636445-7188-4-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MCTMPCCDJJIBRAWHAKWU" Subject: Re: [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MCTMPCCDJJIBRAWHAKWU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2013 11:07 PM, Wenchao Xia wrote: > This patch also fix small code style error reported by check script. >=20 > Signed-off-by: Wenchao Xia > --- > block/snapshot.c | 23 +++++++++++++++++++++++ > include/block/snapshot.h | 9 +++++++++ > savevm.c | 23 +---------------------- > 3 files changed, 33 insertions(+), 22 deletions(-) >=20 > +++ b/include/block/snapshot.h > @@ -1,4 +1,13 @@ > #ifndef SNAPSHOT_H > #define SNAPSHOT_H > =20 > +#include "qemu-common.h" > +/* > + * block.h is needed for QEMUSnapshotInfo, it can be removed when defi= ne is > + * moved here. > + */ > +#include "block.h" Why not move QEMUSnapshotInfo here as part of this patch, and/or reorder the series to do the code motion of that type before you move the functio= n? That said, this looks like an accurate code motion patch. But see my comments earlier in the series about merging this with 1/20. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MCTMPCCDJJIBRAWHAKWU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJROkmvAAoJEKeha0olJ0NqAC0IAJ3pyLZv9ClOA03NWwZqdEBL wpsX0oS4W1jimGrNpCOwIiEPNAdFlDgyLvivjQ5jLuDj3ZRLeGrdRHec/mnz6blU BK8hAEiofct/LJ73fdXY7KADQx5hDdBpIXSdZErRJeq7W0XFULxz0ubBwznv89eW EHze8+Zqe2PcVYGL8qxATl/KmmtdhXoee+nmUfGqIRob3Lcj6Znwm12Ye72+uPHO aTn7haBkX9bVIq7ysmeduyyL49S2DGlDh9bSKQ0LJBlK9uUiVKyHkCoZ0EYOeGcd xD6c+0xB0RPKqFUSjdo8tC6voeSVkaPsAzdNCZan4mE8TYDEx2hFQddGqdwbAZk= =aWtf -----END PGP SIGNATURE----- ------enig2MCTMPCCDJJIBRAWHAKWU--