From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEB3K-0008Ah-MC for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:06:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEB3F-0002vF-TM for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:06:34 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:52793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEB3F-0002v0-CV for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:06:29 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 9 Mar 2013 09:32:20 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 67351E002D for ; Sat, 9 Mar 2013 09:37:39 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2946J8Z29098152 for ; Sat, 9 Mar 2013 09:36:19 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2946NGN026863 for ; Sat, 9 Mar 2013 15:06:23 +1100 Message-ID: <513AB527.9080001@linux.vnet.ibm.com> Date: Sat, 09 Mar 2013 12:05:59 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-3-git-send-email-xiawenc@linux.vnet.ibm.com> <513A48A3.40102@redhat.com> In-Reply-To: <513A48A3.40102@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V8 02/20] build: add block/qapi.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com ÓÚ 2013-3-9 4:22, Eric Blake дµÀ: > On 03/06/2013 11:07 PM, Wenchao Xia wrote: >> This file will have qmp related functions for block. To avoid conflict and >> tip better, macro in header file is BLOCK_QAPI_H instead of QAPI_H. >> >> Signed-off-by: Wenchao Xia >> --- > >> --- /dev/null >> +++ b/include/block/qapi.h >> @@ -0,0 +1,4 @@ >> +#ifndef BLOCK_QAPI_H > > Again, introducing a new file without a copyright notice is a no-no. > > Why are you adding stub files in two separate patches? If you're going > to bother with stub files, then add all of them in one commit. But my > preference would be to add one file at a time, but with contents instead > of being a stub (for example, merge patch 1 and 3, and merge patch 2 and > 6). It just feels like you have subdivided this series too far. > Just to make it easy for review, one patch for one step. I am OK to merge if you insist, but prefer not for that these stub brings no trouble, to save effort. -- Best Regards Wenchao Xia