From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEBEn-00026k-Rj for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:18:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEBEe-0005iE-V0 for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:18:25 -0500 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:52696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEBEe-0005i6-DN for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:18:16 -0500 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 9 Mar 2013 09:44:25 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 66D39125804E for ; Sat, 9 Mar 2013 09:49:11 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r294I8uu25165978 for ; Sat, 9 Mar 2013 09:48:08 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r294IANB017504 for ; Sat, 9 Mar 2013 15:18:10 +1100 Message-ID: <513AB7F6.7020801@linux.vnet.ibm.com> Date: Sat, 09 Mar 2013 12:17:58 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-4-git-send-email-xiawenc@linux.vnet.ibm.com> <513A49AF.6090100@redhat.com> In-Reply-To: <513A49AF.6090100@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com > On 03/06/2013 11:07 PM, Wenchao Xia wrote: >> This patch also fix small code style error reported by check script. >> >> Signed-off-by: Wenchao Xia >> --- >> block/snapshot.c | 23 +++++++++++++++++++++++ >> include/block/snapshot.h | 9 +++++++++ >> savevm.c | 23 +---------------------- >> 3 files changed, 33 insertions(+), 22 deletions(-) >> > >> +++ b/include/block/snapshot.h >> @@ -1,4 +1,13 @@ >> #ifndef SNAPSHOT_H >> #define SNAPSHOT_H >> >> +#include "qemu-common.h" >> +/* >> + * block.h is needed for QEMUSnapshotInfo, it can be removed when define is >> + * moved here. >> + */ >> +#include "block.h" > > Why not move QEMUSnapshotInfo here as part of this patch, and/or reorder > the series to do the code motion of that type before you move the function? > This is along serial which modify the file several times, so I placed the important parts first, to avoid trouble if later patch need modification. You can see patches 1 to 16 are clear and closely related small patches, each of which do one step to archieve the goal, but 17 to 20 are "cleaning" patches, I'd rather drop them to make the serial shorter, instead of move them front. > That said, this looks like an accurate code motion patch. But see my > comments earlier in the series about merging this with 1/20. > -- Best Regards Wenchao Xia