From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEBFT-0002sX-VD for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:19:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEBFM-0005mj-Ea for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:19:07 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:39498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEBFL-0005mV-TR for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:19:00 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 9 Mar 2013 09:44:47 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 68D053940023 for ; Sat, 9 Mar 2013 09:48:52 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r294Intt32637008 for ; Sat, 9 Mar 2013 09:48:49 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r294IpWg018974 for ; Sat, 9 Mar 2013 15:18:51 +1100 Message-ID: <513AB827.9060402@linux.vnet.ibm.com> Date: Sat, 09 Mar 2013 12:18:47 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-6-git-send-email-xiawenc@linux.vnet.ibm.com> <513A4B42.6000200@redhat.com> In-Reply-To: <513A4B42.6000200@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com 于 2013-3-9 4:34, Eric Blake 写道: > On 03/06/2013 11:07 PM, Wenchao Xia wrote: >> Parameter *fmt was not used, so remove it. >> >> Reviewed-by: Eric Blake >> >> Signed-off-by: Wenchao Xia > > Typically, these annotations should be kept in chronological order. > That is, the first line should always be a Signed-off-by (you have to > write a patch before anyone else can add their Reviewed-by). Also, we > tend to avoid blank lines in the attribution section. So, the preferred > way to write this would be: > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > > But that's cosmetic, and my review still stands. > OK. -- Best Regards Wenchao Xia