From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEBMT-00069l-Ir for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:26:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEBMM-00088s-Um for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:26:21 -0500 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:56277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEBMM-00088h-DI for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:26:14 -0500 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 9 Mar 2013 09:52:37 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id BD0A93940023 for ; Sat, 9 Mar 2013 09:56:09 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r294Q4rH36175922 for ; Sat, 9 Mar 2013 09:56:04 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r294Q92H010951 for ; Sat, 9 Mar 2013 15:26:09 +1100 Message-ID: <513AB9DC.2040604@linux.vnet.ibm.com> Date: Sat, 09 Mar 2013 12:26:04 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-10-git-send-email-xiawenc@linux.vnet.ibm.com> <513A6F85.3050801@redhat.com> In-Reply-To: <513A6F85.3050801@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_query_image_info() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com 于 2013-3-9 7:08, Eric Blake 写道: > On 03/06/2013 11:07 PM, Wenchao Xia wrote: >> This patch adds function bdrv_query_image_info(), which will >> retrieve image info in qmp object format. The implementation are > > s/are/is/ > OK. >> based on the code moved from qemu-img.c, but use block layer > > s/use/uses/ > OK. >> function to get snapshot info. >> >> Signed-off-by: Wenchao Xia >> --- >> block/qapi.c | 39 ++++++++++++++++++++++++++++++++------- >> include/block/qapi.h | 7 +++---- >> qemu-img.c | 7 ++----- >> 3 files changed, 37 insertions(+), 16 deletions(-) > > Reviewed-by: Eric Blake > -- Best Regards Wenchao Xia