All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5 REPOST 6/7] mmc: add bcm2835 driver
Date: Sat, 09 Mar 2013 23:34:21 -0700	[thread overview]
Message-ID: <513C296D.9030002@wwwdotorg.org> (raw)
In-Reply-To: <20130203122728.45189b85@lilith>

On 02/03/2013 04:27 AM, Albert ARIBAUD wrote:
> On Tue, 15 Jan 2013 19:26:58 -0700, Stephen Warren <swarren@wwwdotorg.org> wrote:
> 
>> This adds a simple driver for the BCM2835's SD controller.
>>
>> Workarounds are implemented for:
>> * Register writes can't be too close to each-other in time, or they will
>>   be lost.
>> * Register accesses must all be 32-bit, so implement custom accessors.
>>
>> This code was extracted from:
>> git://github.com/gonzoua/u-boot-pi.git master
>> which was created by Oleksandr Tymoshenko.
>>
>> Portions of the code there were obviously based on the Linux kernel at:
>> git://github.com/raspberrypi/linux.git rpi-3.6.y
>> commit f5b930b "Main bcm2708 linux port" signed-off-by Dom Cobley.
>>
>> swarren changed the following for upstream:
>> * Removed hack udelay()s in bcm2835_sdhci_raw_writel(); setting
>>   SDHCI_QUIRK_WAIT_SEND_CMD appears to solve the issues.
>> * Remove register logging from read*/write* functions.
>> * Sort out confusion with min/max_freq values passed to add_sdhci().
>> * Use more descriptive variable names and calculations in IO accessors.
>> * Simplified and commented twoticks_delay calculation.
>> * checkpatch fixes.
>>
>> Cc: Andy Fleming <afleming@gmail.com>
>> Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> ---
>> Andy, could you please ack this so Albert can take it through the ARM tree;
>> patch 7/7 depends is an ARM patch and depends on this. Thanks.
...
> Andy, can you give a formal Acked-By to this patch as per Stephen's
> request?
> 
> Thanks in advance!

Albert, it looks like Andy actually did already Ack this, back in
November last year; see:

http://lists.denx.de/pipermail/u-boot/2012-November/141064.html

Note that when I reposted V5 in January, I merged the ARM/mailbox/video
patches and MMC series together, hence the different patch numbers.

Are you OK pulling this series out of patchwork to be applied, or should
I repost? Thanks.

  parent reply	other threads:[~2013-03-10  6:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16  2:26 [U-Boot] [PATCH V5 REPOST 1/7] ARM: bcm2835: add mailbox driver Stephen Warren
2013-01-16  2:26 ` [U-Boot] [PATCH V5 REPOST 2/7] ARM: rpi_b: use bcm2835 mbox driver to get memory size Stephen Warren
2013-03-20 15:31   ` Albert ARIBAUD
2013-01-16  2:26 ` [U-Boot] [PATCH V5 REPOST 3/7] lcd: calculate line_length after lcd_ctrl_init() Stephen Warren
2013-03-20 15:46   ` Albert ARIBAUD
2013-01-16  2:26 ` [U-Boot] [PATCH V5 REPOST 4/7] ARM: rpi_b: disable rpi_b dcache explicitly Stephen Warren
2013-03-20 15:31   ` Albert ARIBAUD
2013-01-16  2:26 ` [U-Boot] [PATCH V5 REPOST 5/7] video: add a driver for the bcm2835 Stephen Warren
2013-03-20 15:31   ` Albert ARIBAUD
2013-01-16  2:26 ` [U-Boot] [PATCH V5 REPOST 6/7] mmc: add bcm2835 driver Stephen Warren
2013-02-03 11:27   ` Albert ARIBAUD
2013-02-15  3:05     ` Stephen Warren
2013-03-10  6:34     ` Stephen Warren [this message]
2013-03-11  6:35       ` Albert ARIBAUD
2013-03-15 22:51         ` Stephen Warren
2013-03-16  8:09           ` Albert ARIBAUD
2013-03-20 14:33             ` Albert ARIBAUD
2013-03-20 15:31   ` Albert ARIBAUD
2013-01-16  2:26 ` [U-Boot] [PATCH V5 REPOST 7/7] ARM: rpi_b: enable SD controller, add related env/cmds Stephen Warren
2013-03-20 15:31   ` Albert ARIBAUD
2013-03-20 15:30 ` [U-Boot] [PATCH V5 REPOST 1/7] ARM: bcm2835: add mailbox driver Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513C296D.9030002@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.