From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@dlhnet.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight
Date: Mon, 11 Mar 2013 14:00:39 +0100 [thread overview]
Message-ID: <513DD577.103@redhat.com> (raw)
In-Reply-To: <513DC561.7080802@dlhnet.de>
Il 11/03/2013 12:52, Peter Lieven ha scritto:
>>
>> For example, qcow1 (and VHDX) will already call it, but that's a bug and
>> should be fixed otherwise. Your patch will just cause an assertion
>> failure.
>
> In which case can qcow1 (and VHDX) be used in conjunction with an iSCSI
> Target?
No. It is a bug that they are accepted, but we have time to fix it
before 1.5.
Paolo
> Would it be ok for you to assert if iscsi_truncate() is called when there
> are aio's in flight? How can this be checked?
>
> I just want to make sure that nothing nasty happens in that case (such as
> nested event loops).
next prev parent reply other threads:[~2013-03-11 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 10:05 [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight Peter Lieven
2013-03-11 10:16 ` Paolo Bonzini
2013-03-11 10:19 ` Peter Lieven
2013-03-11 11:44 ` Paolo Bonzini
2013-03-11 11:52 ` Peter Lieven
2013-03-11 13:00 ` Paolo Bonzini [this message]
2013-03-13 9:31 ` Kevin Wolf
2013-03-13 10:15 ` Paolo Bonzini
2013-03-19 7:29 ` Peter Lieven
2013-03-19 9:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DD577.103@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@dlhnet.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.