All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] Questions in 802.11 n timestamps traces for aggregated frames ?
Date: Mon, 11 Mar 2013 19:37:09 +0100	[thread overview]
Message-ID: <513E2455.5070509@openwrt.org> (raw)
In-Reply-To: <CAE+zGOivTsAL2Npzte0=TJqeXFQfaiqCej0hS0peRcPBDK6c8Q@mail.gmail.com>

On 2013-03-11 7:20 PM, abhinav narain wrote:
> 
>     Is this being recorded on transmit, or transmit completion? I'm
>     guessing this is transmit completion on the transmit side.
> 
>     Is this information coming from the driver, or from some completion
>     status going up to mac80211?
> 
> Partly from the driver (timestamp and tx aggr flag) and partly from the
> status going to mac80211 (the bitrate array, retx count) and partly from
> the mac header ( sequence number)
> All of them are stored in the radiotap or mac header for each frame
> delivered in userspace in monitor mode.
> 
> The data is recorded from transmit status(You might be referring to it
> as transmit complete)
> i.e net/mac80211/status.c 
> 
> The *attempted rates *array is extracted from *struct ieee80211_tx_info *
> which is part of skb control buffer.I don't really get how is this
> populated/copied from.
> The*timestamp* is got from *ath_tx_status*, which is later stored in the
> ieee80211_tx_info struct to be given to mac80211. Population of
> timestamp is done in driver (ath_tx_complete_buf() ) 
> The *aggr flag *is populated using struct ath_buf
> field  bf->bf_state.bf_type.
One reason I told you to look into rate control is these lines in
minstrel_ht_tx_status:

    /* This packet was aggregated but doesn't carry status info */
    if ((info->flags & IEEE80211_TX_CTL_AMPDU) &&
        !(info->flags & IEEE80211_TX_STAT_AMPDU))
        return;

Any packet with IEEE80211_TX_CTL_AMPDU and not IEEE80211_TX_STAT_AMPDU
does not carry valid rate/retry information. Did you filter your debug
stuff accordingly?

- Felix

  reply	other threads:[~2013-03-11 18:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10 21:01 [ath9k-devel] Questions in 802.11 n timestamps traces for aggregated frames ? abhinav narain
2013-03-10 22:09 ` Adrian Chadd
2013-03-10 22:48   ` abhinav narain
2013-03-11  3:11     ` Adrian Chadd
2013-03-11 18:20       ` abhinav narain
2013-03-11 18:37         ` Felix Fietkau [this message]
2013-03-12 23:48           ` abhinav narain
2013-03-12 23:59             ` Felix Fietkau
2013-03-13 18:44               ` abhinav narain
2013-03-16 20:19               ` abhinav narain
2013-03-16 20:25                 ` Felix Fietkau
2013-03-12 23:59             ` Adrian Chadd
2013-03-13  0:13               ` abhinav narain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513E2455.5070509@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.