All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PULL] : Please pull u-boot-imx -- 3 build failures
Date: Wed, 13 Mar 2013 15:43:45 -0700	[thread overview]
Message-ID: <51410121.2000605@boundarydevices.com> (raw)
In-Reply-To: <CAOMZO5BuGaJ8GjQHLoWDOGwW-MUaRLK_jhxTuXkbNU0WwKV_aw@mail.gmail.com>

Thanks Fabio.

On 03/13/2013 03:40 PM, Fabio Estevam wrote:
> Hi Eric,
>
> On Wed, Mar 13, 2013 at 7:36 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> Hi Albert,
>>
>>
>> On 03/13/2013 03:26 PM, Albert ARIBAUD wrote:
>>>
>>> On Wed, 13 Mar 2013 13:29:55 +0100, Albert ARIBAUD
>>> <albert.u.boot@aribaud.net> wrote:
>>>
>>> <snip>
>>
>>>
>>> However, MAKEALL -a arm fails on three boards: nitrogen6s1g, with an
>>> error, and nitrogen6dl2g and nitrogen6q2g, with a warning.
>>>
>>> nitrogen6s1g:
>>>
>>> nitrogen6x.c:89:17: error: 'CONFIG_DDR_MB' undeclared (first use in
>>> this function)
>>> nitrogen6x.c:89:17: note: each undeclared identifier is reported only
>>> once for each function it appears in
>>>
>>
>> This one's on me.
>>
>> Sorry for not running MAKEALL before submission:
>>
>> The line beginning with nitrogen6s1g should say "DDR_MB=1024", not
>> "SDRAM_MB=1024":
>>
>> http://git.denx.de/u-boot.git/?p=u-boot/u-boot-imx.git;a=blobdiff;f=boards.cfg;h=fb3b197eef192fe5bf5ecaad8bcca5cab3bf1c43;hp=7a0b79dd072f4b8a8c39fe75d638c4d163bdc385;hb=d67b0d97b156f9ec2fc4c838d84b1e510d6e49b4;hpb=7315e3bf2cc95abf9ae53f43ccbd31c6f638aacd
>>
>>
>>> nitrogen6dl2g and nitrogen6q2g:
>>>
>>> nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow]
>>>
>>
>> Looking into this now.
>
> Just fixed it. Will send the patches now.
>

Something like this?

diff --git a/board/boundary/nitrogen6x/nitrogen6x.c 
b/board/boundary/nitrogen6x/nitrogen6x.c
index 0dbb6d2..38e7f78 100644
--- a/board/boundary/nitrogen6x/nitrogen6x.c
+++ b/board/boundary/nitrogen6x/nitrogen6x.c
@@ -86,7 +86,7 @@ DECLARE_GLOBAL_DATA_PTR;

  int dram_init(void)
  {
-       gd->ram_size = CONFIG_DDR_MB * 1024 * 1024;
+       gd->ram_size = (phys_size_t)CONFIG_DDR_MB * 1024 * 1024;

         return 0;
  }

  reply	other threads:[~2013-03-13 22:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13  8:43 [U-Boot] [PULL] : Please pull u-boot-imx Stefano Babic
2013-03-13 12:29 ` Albert ARIBAUD
2013-03-13 22:26   ` [U-Boot] [PULL] : Please pull u-boot-imx -- 3 build failures Albert ARIBAUD
2013-03-13 22:36     ` Eric Nelson
2013-03-13 22:40       ` Fabio Estevam
2013-03-13 22:43         ` Eric Nelson [this message]
2013-03-13 22:44           ` Fabio Estevam
2013-03-13 22:49             ` Eric Nelson
2013-03-14  9:38               ` Stefano Babic
2013-03-14 13:48                 ` Eric Nelson
2013-03-14 14:01                   ` Stefano Babic
2013-03-14  7:27     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51410121.2000605@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.