All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: jerinj@marvell.com, Sunil Kumar Kori <skori@marvell.com>
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag
Date: Mon, 08 Jul 2019 11:07:27 +0200	[thread overview]
Message-ID: <5141529.7f7qfYg9RR@xps> (raw)
In-Reply-To: <20190708043300.44295-1-jerinj@marvell.com>

08/07/2019 06:32, jerinj@marvell.com:
> From: Sunil Kumar Kori <skori@marvell.com>
> 
> Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags
> during fragmentation and reassemble operation implicitly.
> Because of this, application is forced to use checksum offload
> whether it is supported by platform or not.
> 
> Also documentation does not provide any expected value of ol_flags
> in returned mbuf (reassembled or fragmented) so application will never
> come to know that which offloads are enabled. So transmission may be failed
> for the platforms which does not support checksum offload.
> 
> Also, IPv6 does not contain any checksum field in header so setting
> mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid.
> 
> So removing mentioned flag from the library.
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks

PS: I move the release notes from ABI to API changes
as it is an API behaviour change.



  parent reply	other threads:[~2019-07-08  9:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 11:24 [dpdk-dev] [PATCH 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-16 11:24 ` [dpdk-dev] [PATCH 3/3] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-16 11:42 ` [dpdk-dev] [PATCH v2 0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib Sunil Kumar Kori
2019-05-16 11:42   ` [dpdk-dev] [PATCH v2 1/3] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Sunil Kumar Kori
2019-05-18 15:18     ` Ananyev, Konstantin
2019-06-26 21:10       ` Thomas Monjalon
2019-07-04 16:52         ` Thomas Monjalon
2019-07-05  8:31           ` Ananyev, Konstantin
2019-05-16 11:42   ` [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Sunil Kumar Kori
2019-05-18 15:21     ` Ananyev, Konstantin
2019-05-20  8:09       ` Sunil Kumar Kori
2019-05-20  8:15         ` Ananyev, Konstantin
2019-05-20 10:59     ` [dpdk-dev] [PATCH v3 1/2] " Sunil Kumar Kori
2019-05-20 10:59       ` [dpdk-dev] [PATCH v3 2/2] examples/ip_reassembly: " Sunil Kumar Kori
2019-05-20 11:29         ` Ananyev, Konstantin
2019-05-20 11:28       ` [dpdk-dev] [PATCH v3 1/2] examples/ip_fragmentation: " Ananyev, Konstantin
2019-07-08  4:32       ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ip_frag: remove IP checkum offload flag jerinj
2019-07-08  4:32         ` [dpdk-dev] [PATCH v4 2/3] examples/ip_fragmentation: enable IP checksum offload jerinj
2019-07-08  4:33         ` [dpdk-dev] [PATCH v4 3/3] examples/ip_reassembly: " jerinj
2019-07-08  9:07         ` Thomas Monjalon [this message]
2019-05-16 11:42   ` [dpdk-dev] [PATCH v2 3/3] examples/ip_reassembly: Enabling IP checksum offload in mbuf Sunil Kumar Kori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5141529.7f7qfYg9RR@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=skori@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.